Skip to content

Commit 393a223

Browse files
committed
Improve comments on commented out unit tests
1 parent 6e734ef commit 393a223

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

tests/CommunityToolkit.Mvvm.UnitTests/Test_ObservablePropertyAttribute.cs

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -509,11 +509,9 @@ public void Test_ObservableProperty_NullabilityAnnotations_Complex()
509509
//Assert.AreEqual(NullabilityState.NotNull, rightInfo2.ReadState);
510510
//Assert.AreEqual(NullabilityState.NotNull, rightInfo2.WriteState);
511511

512-
// The commented out lines are to work around a weird behavior of the NullabilityInfo API there.
513-
// Arguably we're pushing them a bit far here, but it's fine. Even with those cases commented out,
514-
// the test is already more than enough, plus we can also double check the behavior by looking at
515-
// the generated code. Thoe lines can be uncommented once the behavior is either clarified, or if
516-
// it happens to be a bug which is then fixed in a future version of .NET, once we upgrade as well.
512+
// The commented out lines are to work around a bug in the NullabilityInfo API in .NET 6.
513+
// This has been fixed for .NET 7: https://github.com/dotnet/runtime/pull/63556. The test
514+
// cases above can be uncommented when the .NET 7 target (or a more recent version) is added.
517515
}
518516
#endif
519517

0 commit comments

Comments
 (0)