Remove try/catch when awaiting tasks, ignore exceptions

This allows exceptions to remain unobserved and propagate to TaskScheduler.UnobservedTaskException. It will also be more efficient, as there is no longer an exception being thrown and handled if there's one.

Author: Sergio0694

CommunityToolkit.Mvvm.SourceGenerators/EmbeddedResources/INotifyPropertyChanged.cs

@@ -389,13 +389,7 @@ private bool SetPropertyAndNotifyOnCompletion<TTask>(ITaskNotifier<TTask> taskNo
 
         async void MonitorTask()
         {
-            try
-            {
-                await newValue!;
-            }
-            catch
-            {
-            }
+            await global::CommunityToolkit.Mvvm.ComponentModel.__Internals.__TaskExtensions.GetAwaitableWithoutEndValidation(newValue!);
 
             if (ReferenceEquals(taskNotifier.Task, newValue))
             {

CommunityToolkit.Mvvm.SourceGenerators/EmbeddedResources/ObservableObject.cs

@@ -437,13 +437,7 @@ private bool SetPropertyAndNotifyOnCompletion<TTask>(ITaskNotifier<TTask> taskNo
 
         async void MonitorTask()
         {
-            try
-            {
-                await newValue!;
-            }
-            catch
-            {
-            }
+            await global::CommunityToolkit.Mvvm.ComponentModel.__Internals.__TaskExtensions.GetAwaitableWithoutEndValidation(newValue!);
 
             if (ReferenceEquals(taskNotifier.Task, newValue))
             {

CommunityToolkit.Mvvm/ComponentModel/ObservableObject.cs

@@ -19,6 +19,9 @@
 using System.Diagnostics.CodeAnalysis;
 using System.Runtime.CompilerServices;
 using System.Threading.Tasks;
+using CommunityToolkit.Mvvm.ComponentModel.__Internals;
+
+#pragma warning disable CS0618
 
 namespace CommunityToolkit.Mvvm.ComponentModel;
 
@@ -525,14 +528,8 @@ private bool SetPropertyAndNotifyOnCompletion<TTask>(ITaskNotifier<TTask> taskNo
         // which would result in a confusing behavior for users.
         async void MonitorTask()
         {
-            try
-            {
-                // Await the task and ignore any exceptions
-                await newValue!;
-            }
-            catch
-            {
-            }
+            // Await the task and ignore any exceptions
+            await newValue!.GetAwaitableWithoutEndValidation();
 
             // Only notify if the property hasn't changed
             if (ReferenceEquals(taskNotifier.Task, newValue))

CommunityToolkit.Mvvm/Input/AsyncRelayCommand.cs

@@ -7,6 +7,9 @@
 using System.Runtime.CompilerServices;
 using System.Threading;
 using System.Threading.Tasks;
+using CommunityToolkit.Mvvm.ComponentModel.__Internals;
+
+#pragma warning disable CS0618
 
 namespace CommunityToolkit.Mvvm.Input;
 
@@ -213,13 +216,7 @@ private set
 
             static async void MonitorTask(AsyncRelayCommand @this, Task task)
             {
-                try
-                {
-                    await task;
-                }
-                catch
-                {
-                }
+                await task.GetAwaitableWithoutEndValidation();
 
                 if (ReferenceEquals(@this.executionTask, task))
                 {

CommunityToolkit.Mvvm/Input/AsyncRelayCommand{T}.cs

@@ -7,6 +7,9 @@
 using System.Runtime.CompilerServices;
 using System.Threading;
 using System.Threading.Tasks;
+using CommunityToolkit.Mvvm.ComponentModel.__Internals;
+
+#pragma warning disable CS0618
 
 namespace CommunityToolkit.Mvvm.Input;
 
@@ -197,13 +200,7 @@ private set
 
             static async void MonitorTask(AsyncRelayCommand<T> @this, Task task)
             {
-                try
-                {
-                    await task;
-                }
-                catch
-                {
-                }
+                await task.GetAwaitableWithoutEndValidation();
 
                 if (ReferenceEquals(@this.executionTask, task))
                 {