Add codegen test for filename hints on Roslyn 4.0.1

Author: Sergio0694

src/CommunityToolkit.Mvvm.SourceGenerators/Extensions/SourceProductionContextExtensions.cs

@@ -24,7 +24,7 @@ public static void AddSource(this SourceProductionContext context, string name,
 #if !ROSLYN_4_3_1_OR_GREATER
         // We're fine with the extra allocation in the few cases where adjusting the filename is necessary.
         // This will only ever be done when code generation is executed again anyway, which is a slow path.
-        name = name.Replace('+', '_').Replace('`', '_');
+        name = name.Replace('+', '.').Replace('`', '_');
 #endif
 
         // Add the UTF8 text for the input compilation unit

tests/CommunityToolkit.Mvvm.SourceGenerators.Roslyn401.UnitTests/CommunityToolkit.Mvvm.SourceGenerators.Roslyn401.UnitTests.csproj

@@ -8,7 +8,7 @@
     <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Analyzer.Testing.MSTest" Version="1.1.1" />
     <PackageReference Include="Microsoft.CodeAnalysis.CSharp.CodeFix.Testing" Version="1.1.1" />
     <PackageReference Include="Microsoft.CodeAnalysis.CSharp.CodeFix.Testing.MSTest" Version="1.1.1" />
-    <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.4.0" />
+    <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.0.1" />
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.4.1" />
     <PackageReference Include="MSTest.TestAdapter" Version="3.0.1" />
     <PackageReference Include="MSTest.TestFramework" Version="3.0.1" />

tests/CommunityToolkit.Mvvm.SourceGenerators.Roslyn431.UnitTests/CommunityToolkit.Mvvm.SourceGenerators.Roslyn431.UnitTests.csproj

@@ -2,6 +2,7 @@
 
   <PropertyGroup>
     <TargetFrameworks>net472;net6.0;net7.0</TargetFrameworks>
+    <DefineConstants>$(DefineConstants);ROSLYN_4_3_1_OR_GREATER</DefineConstants>
   </PropertyGroup>
 
   <ItemGroup>

tests/CommunityToolkit.Mvvm.SourceGenerators.UnitTests/Test_SourceGeneratorsCodegen.cs

@@ -193,6 +193,92 @@ public object? A
         VerifyGenerateSources(source, new[] { new ObservablePropertyGenerator() }, ("MyApp.MyViewModel.g.cs", result));
     }
 
+    [TestMethod]
+    public void ObservablePropertyWithinGenericAndNestedTypes()
+    {
+        string source = """
+            using System.ComponentModel;
+            using CommunityToolkit.Mvvm.ComponentModel;
+
+            #nullable enable
+
+            namespace MyApp;
+            
+            partial class Foo
+            {
+                partial class MyViewModel<T> : ObservableObject
+                {
+                    [ObservableProperty]
+                    private string? a;
+                }
+            }
+            """;
+
+        string result = """
+            // <auto-generated/>
+            #pragma warning disable
+            #nullable enable
+            namespace MyApp
+            {
+                partial class Foo
+                {
+                    partial class MyViewModel<T>
+                    {
+                        /// <inheritdoc cref="a"/>
+                        [global::System.CodeDom.Compiler.GeneratedCode("CommunityToolkit.Mvvm.SourceGenerators.ObservablePropertyGenerator", "8.1.0.0")]
+                        [global::System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage]
+                        public string? A
+                        {
+                            get => a;
+                            set
+                            {
+                                if (!global::System.Collections.Generic.EqualityComparer<string?>.Default.Equals(a, value))
+                                {
+                                    OnAChanging(value);
+                                    OnAChanging(default, value);
+                                    OnPropertyChanging(global::CommunityToolkit.Mvvm.ComponentModel.__Internals.__KnownINotifyPropertyChangingArgs.A);
+                                    a = value;
+                                    OnAChanged(value);
+                                    OnAChanged(default, value);
+                                    OnPropertyChanged(global::CommunityToolkit.Mvvm.ComponentModel.__Internals.__KnownINotifyPropertyChangedArgs.A);
+                                }
+                            }
+                        }
+
+                        /// <summary>Executes the logic for when <see cref="A"/> is changing.</summary>
+                        /// <param name="value">The new property value being set.</param>
+                        /// <remarks>This method is invoked right before the value of <see cref="A"/> is changed.</remarks>
+                        [global::System.CodeDom.Compiler.GeneratedCode("CommunityToolkit.Mvvm.SourceGenerators.ObservablePropertyGenerator", "8.1.0.0")]
+                        partial void OnAChanging(string? value);
+                        /// <summary>Executes the logic for when <see cref="A"/> is changing.</summary>
+                        /// <param name="oldValue">The previous property value that is being replaced.</param>
+                        /// <param name="newValue">The new property value being set.</param>
+                        /// <remarks>This method is invoked right before the value of <see cref="A"/> is changed.</remarks>
+                        [global::System.CodeDom.Compiler.GeneratedCode("CommunityToolkit.Mvvm.SourceGenerators.ObservablePropertyGenerator", "8.1.0.0")]
+                        partial void OnAChanging(string? oldValue, string? newValue);
+                        /// <summary>Executes the logic for when <see cref="A"/> just changed.</summary>
+                        /// <param name="value">The new property value that was set.</param>
+                        /// <remarks>This method is invoked right after the value of <see cref="A"/> is changed.</remarks>
+                        [global::System.CodeDom.Compiler.GeneratedCode("CommunityToolkit.Mvvm.SourceGenerators.ObservablePropertyGenerator", "8.1.0.0")]
+                        partial void OnAChanged(string? value);
+                        /// <summary>Executes the logic for when <see cref="A"/> just changed.</summary>
+                        /// <param name="oldValue">The previous property value that was replaced.</param>
+                        /// <param name="newValue">The new property value that was set.</param>
+                        /// <remarks>This method is invoked right after the value of <see cref="A"/> is changed.</remarks>
+                        [global::System.CodeDom.Compiler.GeneratedCode("CommunityToolkit.Mvvm.SourceGenerators.ObservablePropertyGenerator", "8.1.0.0")]
+                        partial void OnAChanged(string? oldValue, string? newValue);
+                    }
+                }
+            }
+            """;
+
+#if ROSLYN_4_3_1_OR_GREATER
+        VerifyGenerateSources(source, new[] { new ObservablePropertyGenerator() }, ("MyApp.Foo+MyViewModel`1.g.cs", result));
+#else
+        VerifyGenerateSources(source, new[] { new ObservablePropertyGenerator() }, ("MyApp.Foo.MyViewModel_1.g.cs", result));
+#endif
+    }
+
     /// <summary>
     /// Generates the requested sources
     /// </summary>
@@ -212,7 +298,7 @@ from assembly in AppDomain.CurrentDomain.GetAssemblies()
             let reference = MetadataReference.CreateFromFile(assembly.Location)
             select reference;
 
-        SyntaxTree syntaxTree = CSharpSyntaxTree.ParseText(source, CSharpParseOptions.Default.WithLanguageVersion(LanguageVersion.CSharp11));
+        SyntaxTree syntaxTree = CSharpSyntaxTree.ParseText(source, CSharpParseOptions.Default.WithLanguageVersion(LanguageVersion.CSharp10));
 
         // Create a syntax tree with the input source
         CSharpCompilation compilation = CSharpCompilation.Create(