Rename [NotifyRecipients] to [NotifyPropertyChangedRecipients]

Author: Sergio0694

CommunityToolkit.Mvvm.SourceGenerators/ComponentModel/Models/PropertyInfo.cs

@@ -20,7 +20,7 @@ namespace CommunityToolkit.Mvvm.SourceGenerators.ComponentModel.Models;
 /// <param name="PropertyChangingNames">The sequence of property changing properties to notify.</param>
 /// <param name="PropertyChangedNames">The sequence of property changed properties to notify.</param>
 /// <param name="NotifiedCommandNames">The sequence of commands to notify.</param>
-/// <param name="NotifyRecipients">Whether or not the generated property also broadcasts changes.</param>
+/// <param name="NotifyPropertyChangedRecipients">Whether or not the generated property also broadcasts changes.</param>
 /// <param name="NotifyDataErrorInfo">Whether or not the generated property also validates its value.</param>
 /// <param name="ForwardedAttributes">The sequence of forwarded attributes for the generated property.</param>
 internal sealed record PropertyInfo(
@@ -30,7 +30,7 @@ internal sealed record PropertyInfo(
     ImmutableArray<string> PropertyChangingNames,
     ImmutableArray<string> PropertyChangedNames,
     ImmutableArray<string> NotifiedCommandNames,
-    bool NotifyRecipients,
+    bool NotifyPropertyChangedRecipients,
     bool NotifyDataErrorInfo,
     ImmutableArray<AttributeInfo> ForwardedAttributes)
 {
@@ -48,7 +48,7 @@ protected override void AddToHashCode(ref HashCode hashCode, PropertyInfo obj)
             hashCode.AddRange(obj.PropertyChangingNames);
             hashCode.AddRange(obj.PropertyChangedNames);
             hashCode.AddRange(obj.NotifiedCommandNames);
-            hashCode.Add(obj.NotifyRecipients);
+            hashCode.Add(obj.NotifyPropertyChangedRecipients);
             hashCode.Add(obj.NotifyDataErrorInfo);
             hashCode.AddRange(obj.ForwardedAttributes, AttributeInfo.Comparer.Default);
         }
@@ -63,7 +63,7 @@ protected override bool AreEqual(PropertyInfo x, PropertyInfo y)
                 x.PropertyChangingNames.SequenceEqual(y.PropertyChangingNames) &&
                 x.PropertyChangedNames.SequenceEqual(y.PropertyChangedNames) &&
                 x.NotifiedCommandNames.SequenceEqual(y.NotifiedCommandNames) &&
-                x.NotifyRecipients == y.NotifyRecipients &&
+                x.NotifyPropertyChangedRecipients == y.NotifyPropertyChangedRecipients &&
                 x.NotifyDataErrorInfo == y.NotifyDataErrorInfo &&
                 x.ForwardedAttributes.SequenceEqual(y.ForwardedAttributes, AttributeInfo.Comparer.Default);
         }

CommunityToolkit.Mvvm.SourceGenerators/ComponentModel/ObservablePropertyGenerator.Execute.cs

@@ -91,7 +91,7 @@ internal static class Execute
             ImmutableArray<AttributeInfo>.Builder forwardedAttributes = ImmutableArray.CreateBuilder<AttributeInfo>();
             bool notifyRecipients = false;
             bool notifyDataErrorInfo = false;
-            bool hasOrInheritsClassLevelNotifyRecipients = false;
+            bool hasOrInheritsClassLevelNotifyPropertyChangedRecipients = false;
             bool hasOrInheritsClassLevelNotifyDataErrorInfo = false;
             bool hasAnyValidationAttributes = false;
 
@@ -104,11 +104,11 @@ internal static class Execute
             // The current property is always notified
             propertyChangedNames.Add(propertyName);
 
-            // Get the class-level [NotifyRecipients] setting, if any
+            // Get the class-level [NotifyPropertyChangedRecipients] setting, if any
             if (TryGetIsNotifyingRecipients(fieldSymbol, out bool isBroadcastTargetValid))
             {
                 notifyRecipients = isBroadcastTargetValid;
-                hasOrInheritsClassLevelNotifyRecipients = true;
+                hasOrInheritsClassLevelNotifyPropertyChangedRecipients = true;
             }
 
             // Get the class-level [NotifyDataErrorInfo] setting, if any
@@ -129,7 +129,7 @@ internal static class Execute
                 }
 
                 // Check whether the property should also notify recipients
-                if (TryGetIsNotifyingRecipients(fieldSymbol, attributeData, builder, hasOrInheritsClassLevelNotifyRecipients, out isBroadcastTargetValid))
+                if (TryGetIsNotifyingRecipients(fieldSymbol, attributeData, builder, hasOrInheritsClassLevelNotifyPropertyChangedRecipients, out isBroadcastTargetValid))
                 {
                     notifyRecipients = isBroadcastTargetValid;
 
@@ -424,10 +424,10 @@ bool IsCommandNameValidWithGeneratedMembers(string commandName)
         /// </summary>
         /// <param name="fieldSymbol">The input <see cref="IFieldSymbol"/> instance to process.</param>
         /// <param name="isBroadcastTargetValid">Whether or not the the property is in a valid target that can notify recipients.</param>
-        /// <returns>Whether or not the generated property for <paramref name="fieldSymbol"/> is in a type annotated with <c>[NotifyRecipients]</c>.</returns>
+        /// <returns>Whether or not the generated property for <paramref name="fieldSymbol"/> is in a type annotated with <c>[NotifyPropertyChangedRecipients]</c>.</returns>
         private static bool TryGetIsNotifyingRecipients(IFieldSymbol fieldSymbol, out bool isBroadcastTargetValid)
         {
-            if (fieldSymbol.ContainingType?.HasOrInheritsAttributeWithFullyQualifiedName("global::CommunityToolkit.Mvvm.ComponentModel.NotifyRecipientsAttribute") == true)
+            if (fieldSymbol.ContainingType?.HasOrInheritsAttributeWithFullyQualifiedName("global::CommunityToolkit.Mvvm.ComponentModel.NotifyPropertyChangedRecipientsAttribute") == true)
             {
                 // If the containing type is valid, track it
                 if (fieldSymbol.ContainingType.InheritsFromFullyQualifiedName("global::CommunityToolkit.Mvvm.ComponentModel.ObservableRecipient") ||
@@ -456,23 +456,23 @@ private static bool TryGetIsNotifyingRecipients(IFieldSymbol fieldSymbol, out bo
         /// <param name="fieldSymbol">The input <see cref="IFieldSymbol"/> instance to process.</param>
         /// <param name="attributeData">The <see cref="AttributeData"/> instance for <paramref name="fieldSymbol"/>.</param>
         /// <param name="diagnostics">The current collection of gathered diagnostics.</param>
-        /// <param name="hasOrInheritsClassLevelNotifyRecipients">Indicates wether the containing type of <paramref name="fieldSymbol"/> has or inherits <c>[NotifyRecipients]</c>.</param>
+        /// <param name="hasOrInheritsClassLevelNotifyPropertyChangedRecipients">Indicates wether the containing type of <paramref name="fieldSymbol"/> has or inherits <c>[NotifyPropertyChangedRecipients]</c>.</param>
         /// <param name="isBroadcastTargetValid">Whether or not the the property is in a valid target that can notify recipients.</param>
-        /// <returns>Whether or not the generated property for <paramref name="fieldSymbol"/> used <c>[NotifyRecipients]</c>.</returns>
+        /// <returns>Whether or not the generated property for <paramref name="fieldSymbol"/> used <c>[NotifyPropertyChangedRecipients]</c>.</returns>
         private static bool TryGetIsNotifyingRecipients(
             IFieldSymbol fieldSymbol,
             AttributeData attributeData,
             ImmutableArray<Diagnostic>.Builder diagnostics,
-            bool hasOrInheritsClassLevelNotifyRecipients,
+            bool hasOrInheritsClassLevelNotifyPropertyChangedRecipients,
             out bool isBroadcastTargetValid)
         {
-            if (attributeData.AttributeClass?.HasFullyQualifiedName("global::CommunityToolkit.Mvvm.ComponentModel.NotifyRecipientsAttribute") == true)
+            if (attributeData.AttributeClass?.HasFullyQualifiedName("global::CommunityToolkit.Mvvm.ComponentModel.NotifyPropertyChangedRecipientsAttribute") == true)
             {
                 // Emit a diagnostic if the attribute is unnecessary
-                if (hasOrInheritsClassLevelNotifyRecipients)
+                if (hasOrInheritsClassLevelNotifyPropertyChangedRecipients)
                 {
                     diagnostics.Add(
-                        UnnecessaryNotifyRecipientsAttributeOnFieldWarning,
+                        UnnecessaryNotifyPropertyChangedRecipientsAttributeOnFieldWarning,
                         fieldSymbol,
                         fieldSymbol.ContainingType,
                         fieldSymbol.Name);
@@ -489,7 +489,7 @@ private static bool TryGetIsNotifyingRecipients(
 
                 // Otherwise just emit the diagnostic and then ignore the attribute
                 diagnostics.Add(
-                    InvalidContainingTypeForNotifyRecipientsFieldError,
+                    InvalidContainingTypeForNotifyPropertyChangedRecipientsFieldError,
                     fieldSymbol,
                     fieldSymbol.ContainingType,
                     fieldSymbol.Name);
@@ -505,7 +505,7 @@ private static bool TryGetIsNotifyingRecipients(
         }
 
         /// <summary>
-        /// Checks whether a given type using <c>[NotifyRecipients]</c> is valid and creates a <see cref="Diagnostic"/> if not.
+        /// Checks whether a given type using <c>[NotifyPropertyChangedRecipients]</c> is valid and creates a <see cref="Diagnostic"/> if not.
         /// </summary>
         /// <param name="typeSymbol">The input <see cref="INamedTypeSymbol"/> instance to process.</param>
         /// <returns>The <see cref="Diagnostic"/> for <paramref name="typeSymbol"/>, if not a valid type.</returns>
@@ -516,7 +516,7 @@ private static bool TryGetIsNotifyingRecipients(
                 !typeSymbol.HasOrInheritsAttributeWithFullyQualifiedName("global::CommunityToolkit.Mvvm.ComponentModel.ObservableRecipientAttribute"))
             {
                 return Diagnostic.Create(
-                    InvalidTypeForNotifyRecipientsError,
+                    InvalidTypeForNotifyPropertyChangedRecipientsError,
                     typeSymbol.Locations.FirstOrDefault(),
                     typeSymbol);
             }
@@ -671,7 +671,7 @@ public static MemberDeclarationSyntax GetPropertySyntax(PropertyInfo propertyInf
                 string name => IdentifierName(name)
             };
 
-            if (propertyInfo.NotifyRecipients)
+            if (propertyInfo.NotifyPropertyChangedRecipients)
             {
                 // If broadcasting changes are required, also store the old value.
                 // This code generates a statement as follows:
@@ -769,7 +769,7 @@ public static MemberDeclarationSyntax GetPropertySyntax(PropertyInfo propertyInf
             }
 
             // Also broadcast the change, if requested
-            if (propertyInfo.NotifyRecipients)
+            if (propertyInfo.NotifyPropertyChangedRecipients)
             {
                 // This code generates a statement as follows:
                 //

CommunityToolkit.Mvvm.SourceGenerators/ComponentModel/ObservablePropertyGenerator.cs

@@ -38,13 +38,13 @@ public void Initialize(IncrementalGeneratorInitializationContext context)
             fieldSymbols
             .Where(static item => item.HasAttributeWithFullyQualifiedName("global::CommunityToolkit.Mvvm.ComponentModel.ObservablePropertyAttribute"));
 
-        // Get diagnostics for fields using [NotifyPropertyChangedFor], [NotifyCanExecuteChangedFor], [NotifyRecipients] and [NotifyDataErrorInfo], but not [ObservableProperty]
+        // Get diagnostics for fields using [NotifyPropertyChangedFor], [NotifyCanExecuteChangedFor], [NotifyPropertyChangedRecipients] and [NotifyDataErrorInfo], but not [ObservableProperty]
         IncrementalValuesProvider<Diagnostic> fieldSymbolsWithOrphanedDependentAttributeWithErrors =
             fieldSymbols
             .Where(static item =>
                 (item.HasAttributeWithFullyQualifiedName("global::CommunityToolkit.Mvvm.ComponentModel.NotifyPropertyChangedForAttribute") ||
                  item.HasAttributeWithFullyQualifiedName("global::CommunityToolkit.Mvvm.ComponentModel.NotifyCanExecuteChangedForAttribute") ||
-                 item.HasAttributeWithFullyQualifiedName("global::CommunityToolkit.Mvvm.ComponentModel.NotifyRecipientsAttribute") ||
+                 item.HasAttributeWithFullyQualifiedName("global::CommunityToolkit.Mvvm.ComponentModel.NotifyPropertyChangedRecipientsAttribute") ||
                  item.HasAttributeWithFullyQualifiedName("global::CommunityToolkit.Mvvm.ComponentModel.NotifyDataErrorInfoAttribute")) &&
                  !item.HasAttributeWithFullyQualifiedName("global::CommunityToolkit.Mvvm.ComponentModel.ObservablePropertyAttribute"))
             .Select(static (item, _) => Execute.GetDiagnosticForFieldWithOrphanedDependentAttributes(item));
@@ -143,14 +143,14 @@ public void Initialize(IncrementalGeneratorInitializationContext context)
                 static (node, _) => node is ClassDeclarationSyntax { AttributeLists.Count: > 0 },
                 static (context, _) => (INamedTypeSymbol)context.SemanticModel.GetDeclaredSymbol(context.Node)!);
 
-        // Filter only the type symbols with [NotifyRecipients] and create diagnostics for them
+        // Filter only the type symbols with [NotifyPropertyChangedRecipients] and create diagnostics for them
         IncrementalValuesProvider<Diagnostic> notifyRecipientsErrors =
             classSymbols
-            .Where(static item => item.HasAttributeWithFullyQualifiedName("global::CommunityToolkit.Mvvm.ComponentModel.NotifyRecipientsAttribute"))
+            .Where(static item => item.HasAttributeWithFullyQualifiedName("global::CommunityToolkit.Mvvm.ComponentModel.NotifyPropertyChangedRecipientsAttribute"))
             .Select(static (item, _) => Execute.GetIsNotifyingRecipientsDiagnosticForType(item))
             .Where(static item => item is not null)!;
 
-        // Output the diagnostics for [NotifyRecipients]
+        // Output the diagnostics for [NotifyPropertyChangedRecipients]
         context.ReportDiagnostics(notifyRecipientsErrors);
 
         // Filter only the type symbols with [NotifyDataErrorInfo] and create diagnostics for them