Skip to content

Add a OnCropChanged event to the ImageCropper #3163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
michael-hawker opened this issue Mar 11, 2020 · 5 comments
Open

Add a OnCropChanged event to the ImageCropper #3163

michael-hawker opened this issue Mar 11, 2020 · 5 comments
Labels
controls 🎛️ good first issue Issues identified as good for first-time contributors Hacktoberfest Hacktoberfest is a month-long celebration of open source software help wanted Issues identified as good community contribution opportunities improvements ✨

Comments

@michael-hawker
Copy link
Member

If it is not too late yet... I am really missing a OnCropChanged event in the ImageCropper...
I would like to provide to the user a pixel dimension information about the Rect she currently crops to... All that event would have to do is fire when the crop has changed, it does not even have to transmit the new crop Rect....

Originally posted by @jhwheuer in #3062 (comment)
@ghost
Copy link

ghost commented Mar 11, 2020

Hello michael-hawker, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

@ghost ghost added the needs triage 🔍 label Mar 11, 2020
@michael-hawker
Copy link
Member Author

@jhwheuer great idea, adding it as its own issue, as it can be done earlier than 7.0.

@michael-hawker michael-hawker added this to the 6.1 milestone Mar 11, 2020
@michael-hawker
Copy link
Member Author

@HHChaos you think you could add this? I imagine it should be pretty straight-forward?

@michael-hawker michael-hawker changed the title Add a **OnCropChanged** event to the **ImageCropper** Add a OnCropChanged event to the ImageCropper Mar 11, 2020
@HHChaos
Copy link
Contributor

HHChaos commented Mar 13, 2020

@HHChaos you think you could add this? I imagine it should be pretty straight-forward?

@michael-hawker Yes, this will be useful and I will do it in my free time

@HHChaos HHChaos mentioned this issue Mar 22, 2020
Closed
7 tasks
@ghost ghost added the In-PR 🚀 label Mar 22, 2020
@ghost ghost removed the In-PR 🚀 label Apr 1, 2020
@Kyaa-dost Kyaa-dost modified the milestones: 6.1, 7.0 Jun 22, 2020
@Kyaa-dost
Copy link
Contributor

@HHChaos update on this?

@michael-hawker michael-hawker modified the milestones: 7.0, 7.1 Jan 6, 2021
@ghost ghost modified the milestone: 7.1 Jan 6, 2021
@michael-hawker michael-hawker added good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities labels Sep 17, 2021
@michael-hawker michael-hawker modified the milestones: 7.1, 7.2/8.0? Sep 17, 2021
@ghost ghost removed this from the 7.2/8.0? milestone Sep 17, 2021
@michael-hawker michael-hawker added the Hacktoberfest Hacktoberfest is a month-long celebration of open source software label Oct 7, 2021
@michael-hawker michael-hawker mentioned this issue Apr 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
controls 🎛️ good first issue Issues identified as good for first-time contributors Hacktoberfest Hacktoberfest is a month-long celebration of open source software help wanted Issues identified as good community contribution opportunities improvements ✨
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add CroppedRegionChanged event for ImageCropper. HHChaos/WindowsCommunityToolkit
3 participants
@HHChaos @michael-hawker @Kyaa-dost