Skip to content

Commit f732fc1

Browse files
authored
Merge pull request #3383 from windows-toolkit/nonEOLNetCore
Updated TFM of Notifications package from netcoreapp3.0 to netcoreapp3.1.
2 parents a21a44f + 3b20838 commit f732fc1

File tree

5 files changed

+10
-31
lines changed

5 files changed

+10
-31
lines changed

Microsoft.Toolkit.Services/Microsoft.Toolkit.Services.csproj

Lines changed: 5 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,11 @@
1919
<DefineConstants Condition="'$(DisableImplicitFrameworkDefines)' != 'true'">$(DefineConstants);WINRT</DefineConstants>
2020
</PropertyGroup>
2121

22+
<PropertyGroup Condition="'$(TargetFramework)' == 'net462'">
23+
<UseWpf>true</UseWpf>
24+
<EnableDefaultPageItems>false</EnableDefaultPageItems>
25+
</PropertyGroup>
26+
2227
<ItemGroup>
2328
<ProjectReference Include="..\Microsoft.Toolkit.Parsers\Microsoft.Toolkit.Parsers.csproj" />
2429
<ProjectReference Include="..\Microsoft.Toolkit\Microsoft.Toolkit.csproj" />
@@ -40,28 +45,9 @@
4045
</ItemGroup>
4146

4247
<ItemGroup Condition="'$(TargetFramework)'=='net462'">
43-
<Reference Include="System.Data" />
44-
<Reference Include="System.ComponentModel" />
45-
<Reference Include="System.Drawing" />
46-
<Reference Include="System.Windows" />
47-
<Reference Include="System.Windows.Forms" />
4848
<Reference Include="System.Web" />
49-
<Reference Include="System.Xaml">
50-
<RequiredTargetFramework>4.0</RequiredTargetFramework>
51-
</Reference>
52-
<Reference Include="WindowsBase" />
53-
<Reference Include="PresentationCore" />
54-
<Reference Include="PresentationFramework" />
5549
<PackageReference Include="Microsoft.Toolkit.Wpf.UI.Controls.WebView" Version="[5.0.0-preview.gb86cb1c4cb,)" />
5650
<PackageReference Include="Microsoft.Toolkit.Forms.UI.Controls.WebView" Version="[5.0.0-preview.gb86cb1c4cb,)" />
57-
<Page Update="PlatformSpecific\NetFramework\PopupWPF.xaml">
58-
<Generator>MSBuild:Compile</Generator>
59-
<SubType>Designer</SubType>
60-
</Page>
61-
<Compile Update="PlatformSpecific\NetFramework\PopupWPF.xaml.cs">
62-
<DependentUpon>PlatformSpecific\NetFramework\PopupWPF.xaml</DependentUpon>
63-
<SubType>Code</SubType>
64-
</Compile>
6551
</ItemGroup>
6652

6753
<ItemGroup Condition="!('$(TargetFramework)'=='uap10.0.16299')">

Microsoft.Toolkit.Uwp.Notifications/Microsoft.Toolkit.Uwp.Notifications.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<Project Sdk="MSBuild.Sdk.Extras">
22

33
<PropertyGroup>
4-
<TargetFrameworks>netstandard1.4;uap10.0;native;net461;netcoreapp3.0</TargetFrameworks>
4+
<TargetFrameworks>netstandard1.4;uap10.0;native;net461;netcoreapp3.1</TargetFrameworks>
55
<DefineConstants>$(DefineConstants);NETFX_CORE</DefineConstants>
66
<Title>Windows Community Toolkit Notifications</Title>
77
<Description>

UnitTests/UnitTests.UWP/Helpers/Test_StorageFileHelper.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ namespace UnitTests.Helpers
1515
public class Test_StorageFileHelper
1616
{
1717
private const string Sampletext = "Lorem ipsum dolor sit amet";
18-
private const string Filename = "filename.txt";
18+
private const string Filename = "Test_StorageFileHelper_file.txt";
1919
private const string PackagedFilePath = @"Assets\Samples\lorem.txt";
2020

2121
[TestCategory("Helpers")]

UnitTests/UnitTests.UWP/Helpers/Test_StreamHelper.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ namespace UnitTests.Helpers
1717
public class Test_StreamHelper
1818
{
1919
private const string SampleText = "Lorem ipsum dolor sit amet";
20-
private const string Filename = "filename.txt";
20+
private const string Filename = "Test_StreamHelper_file.txt";
2121
private const string PackagedFilePath = @"Assets\Samples\lorem.txt";
2222

2323
[TestCategory("Helpers")]

azure-pipelines.yml

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,16 +21,9 @@ steps:
2121
displayName: Setup Environment Variables
2222

2323
- task: NuGetToolInstaller@0
24-
displayName: Use NuGet 5.0.0
24+
displayName: Use NuGet 5.6.0
2525
inputs:
26-
versionSpec: 5.0.0
27-
28-
- task: UseDotNet@2
29-
inputs:
30-
packageType: 'sdk'
31-
version: '3.1.200'
32-
performMultiLevelLookup: true
33-
displayName: Use .NET Core sdk 3
26+
versionSpec: 5.6.0
3427

3528
- task: DotNetCoreCLI@2
3629
inputs:

0 commit comments

Comments
 (0)