Skip to content

Commit f6c65a5

Browse files
committed
Fix TokenizingTextBox header to behave like normal headers
1 parent 0cb2ea6 commit f6c65a5

File tree

1 file changed

+25
-12
lines changed

1 file changed

+25
-12
lines changed

Microsoft.Toolkit.Uwp.UI.Controls.Input/TokenizingTextBox/TokenizingTextBox.xaml

Lines changed: 25 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -65,18 +65,34 @@
6565
<ControlTemplate x:Key="TokenizingTextBoxTemplate"
6666
TargetType="controls:TokenizingTextBox">
6767
<Grid Name="RootPanel">
68+
<Grid.RowDefinitions>
69+
<RowDefinition Height="Auto"/>
70+
<RowDefinition Height="Auto"/>
71+
</Grid.RowDefinitions>
72+
73+
<ContentPresenter Content="{TemplateBinding Header}"
74+
ContentTemplate="{TemplateBinding HeaderTemplate}"
75+
Transitions="{TemplateBinding HeaderTransitions}"
76+
FontWeight="Normal"
77+
Foreground="{ThemeResource TextControlHeaderForeground}"
78+
Margin="{ThemeResource TextBoxTopHeaderMargin}"
79+
TextWrapping="Wrap"
80+
VerticalAlignment="Top" />
6881
<Border x:Name="BackgroundVisual"
82+
Grid.Row="1"
6983
Background="{TemplateBinding Background}"
7084
BorderBrush="{TemplateBinding BorderBrush}"
7185
BorderThickness="{TemplateBinding BorderThickness}" />
7286

7387
<Border x:Name="FocusVisual"
88+
Grid.Row="1"
7489
Background="{ThemeResource SystemControlBackgroundAltHighBrush}"
7590
BorderBrush="{ThemeResource TextControlBorderBrushFocused}"
7691
BorderThickness="{TemplateBinding BorderThickness}"
7792
Opacity="0" /> <!-- Background in WinUI is TextControlBackgroundFocused, but that uses a different resource in WinUI than system -->
7893

7994
<ScrollViewer x:Name="ScrollViewer"
95+
Grid.Row="1"
8096
AutomationProperties.AccessibilityView="Raw"
8197
BringIntoViewOnFocusChange="{TemplateBinding ScrollViewer.BringIntoViewOnFocusChange}"
8298
HorizontalScrollBarVisibility="{TemplateBinding ScrollViewer.HorizontalScrollBarVisibility}"
@@ -95,25 +111,22 @@
95111
Margin="{StaticResource TokenizingTextBoxPresenterMargin}"
96112
Footer="{TemplateBinding Footer}"
97113
FooterTemplate="{TemplateBinding FooterTemplate}"
98-
FooterTransitions="{TemplateBinding FooterTransitions}"
99-
Header="{TemplateBinding Header}"
100-
HeaderTemplate="{TemplateBinding HeaderTemplate}"
101-
HeaderTransitions="{TemplateBinding HeaderTransitions}" />
114+
FooterTransitions="{TemplateBinding FooterTransitions}"/>
102115
</ScrollViewer>
103116

104117
<VisualStateManager.VisualStateGroups>
105118
<VisualStateGroup x:Name="CommonStates">
106119
<VisualState x:Name="Disabled">
107120
<Storyboard>
108121
<ObjectAnimationUsingKeyFrames Storyboard.TargetName="BackgroundVisual"
109-
Storyboard.TargetProperty="Background">
122+
Storyboard.TargetProperty="Background">
110123
<DiscreteObjectKeyFrame KeyTime="0"
111-
Value="{ThemeResource TextControlBackgroundDisabled}" />
124+
Value="{ThemeResource TextControlBackgroundDisabled}" />
112125
</ObjectAnimationUsingKeyFrames>
113126
<ObjectAnimationUsingKeyFrames Storyboard.TargetName="BackgroundVisual"
114-
Storyboard.TargetProperty="BorderBrush">
127+
Storyboard.TargetProperty="BorderBrush">
115128
<DiscreteObjectKeyFrame KeyTime="0"
116-
Value="{ThemeResource TextControlBorderBrushDisabled}" />
129+
Value="{ThemeResource TextControlBorderBrushDisabled}" />
117130
</ObjectAnimationUsingKeyFrames>
118131

119132
</Storyboard>
@@ -122,14 +135,14 @@
122135
<VisualState x:Name="PointerOver">
123136
<Storyboard>
124137
<ObjectAnimationUsingKeyFrames Storyboard.TargetName="BackgroundVisual"
125-
Storyboard.TargetProperty="BorderBrush">
138+
Storyboard.TargetProperty="BorderBrush">
126139
<DiscreteObjectKeyFrame KeyTime="0"
127-
Value="{ThemeResource TextControlBorderBrushPointerOver}" />
140+
Value="{ThemeResource TextControlBorderBrushPointerOver}" />
128141
</ObjectAnimationUsingKeyFrames>
129142
<ObjectAnimationUsingKeyFrames Storyboard.TargetName="BackgroundVisual"
130-
Storyboard.TargetProperty="Background">
143+
Storyboard.TargetProperty="Background">
131144
<DiscreteObjectKeyFrame KeyTime="0"
132-
Value="{ThemeResource TextControlBackgroundPointerOver}" />
145+
Value="{ThemeResource TextControlBackgroundPointerOver}" />
133146
</ObjectAnimationUsingKeyFrames>
134147
</Storyboard>
135148
</VisualState>

0 commit comments

Comments
 (0)