Skip to content

Commit d85e1a7

Browse files
authored
Merge pull request #3162 from vgromfeld/u/vgromfeld/removeTaskFromResult
Replace Task.FromResult by Task.CompletedTask
2 parents ef65272 + cc09820 commit d85e1a7

File tree

2 files changed

+4
-10
lines changed

2 files changed

+4
-10
lines changed

Microsoft.Toolkit.Uwp/Deferred/EventHandlerExtensions.cs

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,7 @@
33
// See the LICENSE file in the project root for more information.
44

55
using System;
6-
using System.Collections.Generic;
76
using System.Linq;
8-
using System.Text;
97
using System.Threading;
108
using System.Threading.Tasks;
119

@@ -16,8 +14,6 @@ namespace Microsoft.Toolkit.Uwp.Deferred
1614
/// </summary>
1715
public static class EventHandlerExtensions
1816
{
19-
private static readonly Task CompletedTask = Task.FromResult(0);
20-
2117
/// <summary>
2218
/// Use to invoke an async <see cref="EventHandler{TEventArgs}"/> using <see cref="DeferredEventArgs"/>.
2319
/// </summary>
@@ -46,7 +42,7 @@ public static Task InvokeAsync<T>(this EventHandler<T> eventHandler, object send
4642
{
4743
if (eventHandler == null)
4844
{
49-
return CompletedTask;
45+
return Task.CompletedTask;
5046
}
5147

5248
var tasks = eventHandler.GetInvocationList()
@@ -59,7 +55,7 @@ public static Task InvokeAsync<T>(this EventHandler<T> eventHandler, object send
5955

6056
var deferral = eventArgs.GetCurrentDeferralAndReset();
6157

62-
return deferral?.WaitForCompletion(cancellationToken) ?? CompletedTask;
58+
return deferral?.WaitForCompletion(cancellationToken) ?? Task.CompletedTask;
6359
})
6460
.ToArray();
6561

Microsoft.Toolkit.Uwp/Deferred/TypedEventHandlerExtensions.cs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@ namespace Microsoft.Toolkit.Uwp.Deferred
1515
/// </summary>
1616
public static class TypedEventHandlerExtensions
1717
{
18-
private static readonly Task CompletedTask = Task.FromResult(0);
19-
2018
/// <summary>
2119
/// Use to invoke an async <see cref="TypedEventHandler{TSender, TResult}"/> using <see cref="DeferredEventArgs"/>.
2220
/// </summary>
@@ -47,7 +45,7 @@ public static Task InvokeAsync<S, R>(this TypedEventHandler<S, R> eventHandler,
4745
{
4846
if (eventHandler == null)
4947
{
50-
return CompletedTask;
48+
return Task.CompletedTask;
5149
}
5250

5351
var tasks = eventHandler.GetInvocationList()
@@ -60,7 +58,7 @@ public static Task InvokeAsync<S, R>(this TypedEventHandler<S, R> eventHandler,
6058

6159
var deferral = eventArgs.GetCurrentDeferralAndReset();
6260

63-
return deferral?.WaitForCompletion(cancellationToken) ?? CompletedTask;
61+
return deferral?.WaitForCompletion(cancellationToken) ?? Task.CompletedTask;
6462
})
6563
.ToArray();
6664

0 commit comments

Comments
 (0)