Skip to content

Commit a4710a7

Browse files
authored
Merge pull request #3217 from windows-toolkit/enableNetCoreTests
Enabled .NetCore tests.
2 parents f42a884 + a8d78f7 commit a4710a7

File tree

4 files changed

+36
-9
lines changed

4 files changed

+36
-9
lines changed

.runsettings

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
<?xml version="1.0" encoding="utf-8"?>
2+
<RunSettings>
3+
<MSTest>
4+
<MaxCpuCount>0</MaxCpuCount>
5+
<Parallelize>
6+
<Workers>0</Workers>
7+
<Scope>ClassLevel</Scope>
8+
</Parallelize>
9+
</MSTest>
10+
</RunSettings>

UnitTests/UnitTests.Notifications.NetCore/UnitTests.Notifications.NetCore.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
</PropertyGroup>
1111

1212
<ItemGroup>
13-
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.4.0" />
13+
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.0.1" />
1414
<PackageReference Include="MSTest.TestAdapter" Version="2.1.0" />
1515
<PackageReference Include="MSTest.TestFramework" Version="2.1.0" />
1616
</ItemGroup>

azure-pipelines.yml

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,14 @@ steps:
2828
- task: UseDotNet@2
2929
inputs:
3030
packageType: 'sdk'
31-
version: '3.1.101'
32-
displayName: Use .NET Core sdk
31+
version: '2.1.202' # This SDK contains .Net Core 2.0.9, which we still need to run some of our .Net Core Tests
32+
displayName: Use .NET Core sdk 2
33+
34+
- task: UseDotNet@2
35+
inputs:
36+
packageType: 'sdk'
37+
version: '3.1.200'
38+
displayName: Use .NET Core sdk 3
3339

3440
- task: DotNetCoreCLI@2
3541
inputs:
@@ -50,7 +56,7 @@ steps:
5056
- task: PublishTestResults@2
5157
inputs:
5258
testResultsFormat: 'VSTest'
53-
testResultsFiles: '**/VsTestResults.xml'
59+
testResultsFiles: '**/VsTestResults*.trx'
5460
displayName: Publish Test Results
5561
condition: succeededOrFailed()
5662

build/build.cake

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -265,22 +265,33 @@ public string getMSTestAdapterPath(){
265265
Task("Test")
266266
.Description("Runs all Tests")
267267
.IsDependentOn("Build")
268-
.Does(() =>
268+
.Does(() =>
269269
{
270270
var vswhere = VSWhereLatest(new VSWhereLatestSettings
271271
{
272272
IncludePrerelease = false
273273
});
274-
274+
275275
var testSettings = new VSTestSettings
276276
{
277277
ToolPath = vswhere + "/Common7/IDE/CommonExtensions/Microsoft/TestWindow/vstest.console.exe",
278278
TestAdapterPath = getMSTestAdapterPath(),
279-
ArgumentCustomization = arg => arg.Append("/logger:trx;LogFileName=VsTestResults.xml /framework:FrameworkUap10"),
279+
ArgumentCustomization = arg => arg.Append("/logger:trx;LogFileName=VsTestResultsUwp.trx /framework:FrameworkUap10"),
280280
};
281281

282-
VSTest(baseDir + "/**/UnitTests.*.appxrecipe", testSettings);
283-
});
282+
VSTest(baseDir + "/**/Release/**/UnitTests.*.appxrecipe", testSettings);
283+
}).DoesForEach(GetFiles(baseDir + "/**/UnitTests.*.NetCore.csproj"), (file) =>
284+
{
285+
var testSettings = new DotNetCoreTestSettings
286+
{
287+
Configuration = "Release",
288+
NoBuild = true,
289+
Logger = "trx;LogFilePrefix=VsTestResults",
290+
Verbosity = DotNetCoreVerbosity.Normal,
291+
ArgumentCustomization = arg => arg.Append($"-s {baseDir}/.runsettings"),
292+
};
293+
DotNetCoreTest(file.FullPath, testSettings);
294+
}).DeferOnError();
284295

285296

286297

0 commit comments

Comments
 (0)