Fixed inconsistency with ReadOnlySpan2D<T>.Slice parameters

Author: Sergio0694

Microsoft.Toolkit.HighPerformance/Memory/ReadOnlySpan2D{T}.cs

@@ -803,15 +803,15 @@ public ref T DangerousGetReferenceAt(int i, int j)
         /// </summary>
         /// <param name="row">The target row to map within the current instance.</param>
         /// <param name="column">The target column to map within the current instance.</param>
-        /// <param name="width">The width to map within the current instance.</param>
         /// <param name="height">The height to map within the current instance.</param>
+        /// <param name="width">The width to map within the current instance.</param>
         /// <exception cref="ArgumentException">
         /// Thrown when either <paramref name="height"/>, <paramref name="width"/> or <paramref name="height"/>
         /// are negative or not within the bounds that are valid for the current instance.
         /// </exception>
         /// <returns>A new <see cref="ReadOnlySpan2D{T}"/> instance representing a slice of the current one.</returns>
         [Pure]
-        public ReadOnlySpan2D<T> Slice(int row, int column, int width, int height)
+        public ReadOnlySpan2D<T> Slice(int row, int column, int height, int width)
         {
             if ((uint)row >= Height)
             {
@@ -823,14 +823,14 @@ public ReadOnlySpan2D<T> Slice(int row, int column, int width, int height)
                 ThrowHelper.ThrowArgumentOutOfRangeExceptionForColumn();
             }
 
-            if ((uint)width > (this.width - column))
+            if ((uint)height > (Height - row))
             {
-                ThrowHelper.ThrowArgumentOutOfRangeExceptionForWidth();
+                ThrowHelper.ThrowArgumentOutOfRangeExceptionForHeight();
             }
 
-            if ((uint)height > (Height - row))
+            if ((uint)width > (this.width - column))
             {
-                ThrowHelper.ThrowArgumentOutOfRangeExceptionForHeight();
+                ThrowHelper.ThrowArgumentOutOfRangeExceptionForWidth();
             }
 
             nint shift = ((nint)(uint)this.stride * (nint)(uint)row) + (nint)(uint)column;

UnitTests/UnitTests.HighPerformance.Shared/Memory/Test_ReadOnlySpan2D{T}.cs

@@ -412,7 +412,7 @@ public void Test_ReadOnlySpan2DT_Slice_1()
 
             ReadOnlySpan2D<int> span2d = new ReadOnlySpan2D<int>(array);
 
-            ReadOnlySpan2D<int> slice1 = span2d.Slice(1, 1, 2, 1);
+            ReadOnlySpan2D<int> slice1 = span2d.Slice(1, 1, 1, 2);
 
             Assert.AreEqual(slice1.Length, 2);
             Assert.AreEqual(slice1.Height, 1);
@@ -431,11 +431,11 @@ public void Test_ReadOnlySpan2DT_Slice_1()
 
             Assert.ThrowsException<ArgumentOutOfRangeException>(() => new ReadOnlySpan2D<int>(array).Slice(-1, 1, 1, 1));
             Assert.ThrowsException<ArgumentOutOfRangeException>(() => new ReadOnlySpan2D<int>(array).Slice(1, -1, 1, 1));
-            Assert.ThrowsException<ArgumentOutOfRangeException>(() => new ReadOnlySpan2D<int>(array).Slice(1, 1, -1, 1));
             Assert.ThrowsException<ArgumentOutOfRangeException>(() => new ReadOnlySpan2D<int>(array).Slice(1, 1, 1, -1));
+            Assert.ThrowsException<ArgumentOutOfRangeException>(() => new ReadOnlySpan2D<int>(array).Slice(1, 1, -1, 1));
             Assert.ThrowsException<ArgumentOutOfRangeException>(() => new ReadOnlySpan2D<int>(array).Slice(10, 1, 1, 1));
-            Assert.ThrowsException<ArgumentOutOfRangeException>(() => new ReadOnlySpan2D<int>(array).Slice(1, 12, 12, 1));
-            Assert.ThrowsException<ArgumentOutOfRangeException>(() => new ReadOnlySpan2D<int>(array).Slice(1, 1, 1, 55));
+            Assert.ThrowsException<ArgumentOutOfRangeException>(() => new ReadOnlySpan2D<int>(array).Slice(1, 12, 1, 12));
+            Assert.ThrowsException<ArgumentOutOfRangeException>(() => new ReadOnlySpan2D<int>(array).Slice(1, 1, 55, 1));
         }
 
         [TestCategory("ReadOnlySpan2DT")]
@@ -458,7 +458,7 @@ public void Test_ReadOnlySpan2DT_Slice_2()
             Assert.AreEqual(slice1[0, 0], 1);
             Assert.AreEqual(slice1[1, 1], 5);
 
-            ReadOnlySpan2D<int> slice2 = slice1.Slice(1, 0, 2, 1);
+            ReadOnlySpan2D<int> slice2 = slice1.Slice(1, 0, 1, 2);
 
             Assert.AreEqual(slice2.Length, 2);
             Assert.AreEqual(slice2.Height, 1);