Skip to content

Commit 82e2bbb

Browse files
committed
Replaced ResourceLoader with ResourceManager, for better debugging experience.
1 parent c9df5b8 commit 82e2bbb

File tree

2 files changed

+16
-7
lines changed

2 files changed

+16
-7
lines changed

CommunityToolkit.WinUI.UI/Converters/ResourceNameToResourceStringConverter.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ namespace CommunityToolkit.WinUI.UI.Converters
1313
/// </summary>
1414
public sealed class ResourceNameToResourceStringConverter : IValueConverter
1515
{
16-
private readonly ResourceLoader _resourceLoader = new ResourceLoader();
16+
private readonly ResourceManager _resourceManager = new ResourceManager();
1717

1818
/// <summary>
1919
/// Take the source string as a resource name that will be looked up in the App Resources.
@@ -31,7 +31,7 @@ public object Convert(object value, Type targetType, object parameter, string la
3131
return string.Empty;
3232
}
3333

34-
return _resourceLoader.GetString(value.ToString());
34+
return _resourceManager.MainResourceMap.TryGetValue(value.ToString()).ValueAsString;
3535
}
3636

3737
/// <summary>

CommunityToolkit.WinUI/Extensions/StringExtensions.cs

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,13 @@ namespace CommunityToolkit.WinUI
1111
/// </summary>
1212
public static class StringExtensions
1313
{
14-
private static readonly ResourceLoader Loader;
14+
private static readonly ResourceManager ResourceManager;
1515

1616
static StringExtensions()
1717
{
1818
try
1919
{
20-
Loader = new ResourceLoader();
20+
ResourceManager = new ResourceManager();
2121
}
2222
catch
2323
{
@@ -47,7 +47,7 @@ public static string GetViewLocalized(this string resourceKey, UIContext uiConte
4747
/// <returns>string value for given resource or empty string if not found.</returns>
4848
public static string GetLocalized(this string resourceKey)
4949
{
50-
return Loader?.GetString(resourceKey);
50+
return ResourceManager.MainResourceMap.TryGetValue(resourceKey)?.ValueAsString;
5151
}
5252

5353
/*
@@ -75,11 +75,20 @@ public static string GetLocalized(this string resourceKey, UIContext uiContext)
7575
public static string GetLocalized(this string resourceKey, string resourcePath)
7676
{
7777
// Try and retrieve resource at app level first.
78-
var result = Loader?.GetString(resourceKey);
78+
var result = ResourceManager.MainResourceMap.TryGetValue(resourceKey)?.ValueAsString;
7979

8080
if (string.IsNullOrEmpty(result))
8181
{
82-
result = new ResourceLoader(ResourceLoader.GetDefaultResourceFilePath(), resourcePath).GetString(resourceKey);
82+
var manager = new ResourceManager();
83+
var subTree = manager.MainResourceMap.TryGetSubtree(resourcePath);
84+
if (subTree != null)
85+
{
86+
var r = subTree.TryGetValue(resourceKey);
87+
if (r != null)
88+
{
89+
result = r.ValueAsString;
90+
}
91+
}
8392
}
8493

8594
return result;

0 commit comments

Comments
 (0)