Skip to content

Commit 738b950

Browse files
committed
Merge branch 'master' of https://github.com/dpaulino/WindowsCommunityToolkit-1 into feature/control-width-trigger
2 parents 5a523c9 + 2d74076 commit 738b950

File tree

43 files changed

+957
-191
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

43 files changed

+957
-191
lines changed

.github/ISSUE_TEMPLATE/bug_report.md

Lines changed: 25 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -4,23 +4,26 @@ about: Create a report to help us fix something that isn't working as expected
44
title: ''
55
labels: "bug :bug:"
66
assignees: ''
7-
87
---
98

109
<!-- 🚨 PLEASE DO NOT SKIP ANY INSTRUCTIONS AND INFORMATION MENTIONED BELOW AS THEY ARE ALL REQUIRED AND ESSENTIAL TO INVESTIGATE THE ISSUE. ISSUES WITH MISSING INFORMATION MAY BE CLOSED WITHOUT INVESTIGATION
1110
...
12-
IF NOT CERTAIN ABOUT THE ISSUE AND REQUIRE MORE CLARITY THEN PLEASE POST ON "QUESTIONS & HELP" CATEGORY OF THE DISCUSSIONS PLATFORM [https://github.com/CommunityToolkit/WindowsCommunityToolkit/discussions/categories/questions-help] WHERE YOU CAN DISCUSS AND ENAGAGE WITH THE COMMUNITY TO GAIN FURTHER CLAIRITY REGARDING THE ISSUE 🚨 -->
11+
IF NOT CERTAIN ABOUT THE ISSUE AND REQUIRE MORE CLARITY THEN PLEASE POST ON "QUESTIONS & HELP" CATEGORY OF THE DISCUSSIONS PLATFORM [https://github.com/CommunityToolkit/WindowsCommunityToolkit/discussions/categories/questions-help] WHERE YOU CAN DISCUSS AND ENGAGE WITH THE COMMUNITY TO GAIN FURTHER CLARITY REGARDING THE ISSUE 🚨 -->
1312

1413
## Describe the bug
14+
1515
A clear and concise description of what the bug is.
1616

1717
- [ ] Is this bug a regression in the toolkit? If so, what toolkit version did you last see it work:
1818

1919
## Steps to Reproduce
2020

21-
- [ ] Can this be reproduced in the Sample App? (Either in a sample as-is or with new XAML pasted in the editor.) If so, please provide custom XAML or steps to reproduce. If not, let us know why it can't be reproduced (e.g. more complex setup, environment, dependencies, etc...) <!-- Being able to reproduce the problem in the sample app, really stream-lines the whole process in being able to discover, resolve, and validate bug fixes. -->
21+
- [ ] Can this be reproduced in the Sample App? (Either in a sample as-is or with new XAML pasted in the editor.) If so, please provide custom XAML or steps to reproduce. If not, let us know why it can't be reproduced (e.g. more complex setup, environment, dependencies, etc...)
22+
23+
<!-- Being able to reproduce the problem in the sample app, really stream-lines the whole process in being able to discover, resolve, and validate bug fixes. -->
2224

2325
Steps to reproduce the behavior:
26+
2427
1. Given the following environment (Sample App w/ XAML, Project with Isolated setup, etc...)
2528
2. Go to '...'
2629
3. Click on '....'
@@ -30,46 +33,52 @@ Steps to reproduce the behavior:
3033
<!-- Provide as many code-snippets or XAML snippets where appropriate. -->
3134

3235
## Expected behavior
33-
A clear and concise description of what you expected to happen.
36+
37+
<!-- A clear and concise description of what you expected to happen. -->
3438

3539
## Screenshots
36-
If applicable, add screenshots to help explain your problem.
40+
41+
<!-- If applicable, add screenshots to help explain your problem. -->
3742

3843
## Environment
39-
<!-- Check one or more of the following options with "x" -->
40-
```
41-
NuGet Package(s):
44+
45+
<!-- Check one or more of the following options with "x" and replace the {build_number} and {minor_version} with the actual values -->
46+
47+
NuGet Package(s): <!-- Which NuGet Packages have you used -->
4248

4349
Package Version(s):
4450

4551
Windows 10 Build Number:
52+
4653
- [ ] Fall Creators Update (16299)
4754
- [ ] April 2018 Update (17134)
4855
- [ ] October 2018 Update (17763)
4956
- [ ] May 2019 Update (18362)
5057
- [ ] May 2020 Update (19041)
51-
- [ ] Insider Build (build number: )
58+
- [ ] Insider Build ({build_number})
5259

5360
App min and target version:
61+
5462
- [ ] Fall Creators Update (16299)
5563
- [ ] April 2018 Update (17134)
5664
- [ ] October 2018 Update (17763)
5765
- [ ] May 2019 Update (18362)
5866
- [ ] May 2020 Update (19041)
59-
- [ ] Insider Build (xxxxx)
67+
- [ ] Insider Build ({build_number})
6068

6169
Device form factor:
70+
6271
- [ ] Desktop
6372
- [ ] Xbox
6473
- [ ] Surface Hub
6574
- [ ] IoT
6675

67-
Visual Studio
68-
- [ ] 2017 (version: )
69-
- [ ] 2019 (version: )
70-
- [ ] 2019 Preview (version: )
76+
Visual Studio version:
7177

72-
```
78+
- [ ] 2017 (15.{minor_version})
79+
- [ ] 2019 (16.{minor_version})
80+
- [ ] 2022 (17.{minor_version})
7381

7482
## Additional context
75-
Add any other context about the problem here.
83+
84+
<!-- Add any other context about the problem here. -->

.github/ISSUE_TEMPLATE/documentation.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ about: I have a documentation suggestion or question
44
title: "[Docs]"
55
labels: documentation
66
assignees: ''
7-
87
---
98

109
<!--

.github/ISSUE_TEMPLATE/feature_request.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,27 +4,27 @@ about: I have a new idea or improvement for the toolkit
44
title: "[Feature]"
55
labels: "feature request :mailbox_with_mail:"
66
assignees: ''
7-
87
---
98

109
<!-- 🚨 PLEASE PROVIDE DETAILED INFORMATION AND DO NOT SKIP ANY INSTRUCTIONS AND INFORMATION MENTIONED BELOW AS THEY ARE ALL REQUIRED AND ESSENTIAL TO HELP US UNDERSTAND THE FEATURE.
1110
...
12-
IF NOT CERTAIN ABOUT THE FEATURE AND REQUIRE MORE CLARITY THEN PLEASE POST ON "IDEAS" CATEGORY OF THE DISCUSSIONS PLATFORM [https://github.com/CommunityToolkit/WindowsCommunityToolkit/discussions/categories/ideas] WHERE YOU CAN DISCUSS AND ENAGAGE WITH THE COMMUNITY TO GAIN FURTHER CLAIRITY REGARDING THE FEATURE 🚨 -->
11+
IF NOT CERTAIN ABOUT THE FEATURE AND REQUIRE MORE CLARITY THEN PLEASE POST ON "IDEAS" CATEGORY OF THE DISCUSSIONS PLATFORM [https://github.com/CommunityToolkit/WindowsCommunityToolkit/discussions/categories/ideas] WHERE YOU CAN DISCUSS AND ENGAGE WITH THE COMMUNITY TO GAIN FURTHER CLARITY REGARDING THE FEATURE 🚨 -->
1312

1413
## Describe the problem this feature would solve
14+
1515
<!-- Please describe or link to any existing issues or discussions.
1616
A clear and concise description of what the problem is, starting with the user story.
1717
Provide examples of the restrictions in the current environment that hinders the work your users or you want to perform. What are the ways this new feature will help transform and deliver those results?
1818
For example, I am currently using the InfiniteCanvas control which lacks the TabbedCommandBar control feature. I am looking to improve user experience therefore i would like to use that in my project to provide ease of accessibility and a user-friendly interface. This new feature will provide quick access to the toolbar, enhance space utilization, etc [...] -->
1919

20-
2120
## Describe the solution
22-
<!-- A clear and concise description of what you want to happen. Define how do you think it will help the community and adds value to the toolkit? -->
2321

22+
<!-- A clear and concise description of what you want to happen. Define how do you think it will help the community and adds value to the toolkit? -->
2423

2524
## Describe alternatives you've considered
26-
<!-- A clear and concise description of any alternative solutions or features you've considered. -->
2725

26+
<!-- A clear and concise description of any alternative solutions or features you've considered. -->
2827

2928
## Additional context & Screenshots
29+
3030
<!-- Add any other context or screenshots about the feature request here.-->

.github/ISSUE_TEMPLATE/question.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ about: I have a question about how to use something in the toolkit.
44
title: "[Question]"
55
labels: "question :grey_question:"
66
assignees: ''
7-
87
---
98

109
<!--

.github/ISSUE_TEMPLATE/win32_controls.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ about: I have an issue with a Toolkit WPF or WinForms control
44
title: "[Win32]"
55
labels:
66
assignees: ''
7-
87
---
98

109
<!--

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,19 @@
11
<!-- 🚨 Please Do Not skip any instructions and information mentioned below as they are all required and essential to evaluate and test the PR. By fulfilling all the required information you will be able to reduce the volume of questions and most likely help merge the PR faster 🚨 -->
22

3-
<!-- 👉 It is imperative to resolve ONE ISSUE PER PR and avoid making multiple changes unless the changes interrelate with each other -->
3+
<!-- 👉 It is imperative to resolve ONE ISSUE PER PR and avoid making multiple changes unless the changes interrelate with each other -->
44

55
<!-- 📝 Please always keep the "☑️ Allow edits by maintainers" button checked in the Pull Request Template as it increases collaboration with the Toolkit maintainers by permitting commits to your PR branch (only) created from your fork. This can let us quickly make fixes for minor typos or forgotten StyleCop issues during review without needing to wait on you doing extra work. Let us help you help us! 🎉 -->
66

7+
## Fixes
78

8-
## Fixes #
9-
<!-- Add the relevant issue number after the "#" mentioned above (for ex: "## Fixes #1234") which will automatically close the issue once the PR is merged. -->
9+
<!-- Add the relevant issue number after the word "Fixes" mentioned above (for ex: "## Fixes #1234") which will automatically close the issue once the PR is merged. -->
1010

1111
<!-- Add a brief overview here of the feature/bug & fix. -->
1212

1313
## PR Type
14+
1415
What kind of change does this PR introduce?
16+
1517
<!-- Please uncomment one or more options below that apply to this PR. -->
1618

1719
<!-- - Bugfix -->
@@ -23,30 +25,30 @@ What kind of change does this PR introduce?
2325
<!-- - Sample app changes -->
2426
<!-- - Other... Please describe: -->
2527

26-
2728
## What is the current behavior?
28-
<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->
2929

30+
<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->
3031

3132
## What is the new behavior?
32-
<!-- Describe how was this issue resolved or changed? -->
3333

34+
<!-- Describe how was this issue resolved or changed? -->
3435

3536
## PR Checklist
3637

37-
Please check if your PR fulfills the following requirements:
38+
Please check if your PR fulfills the following requirements: <!-- and remove the ones that are not applicable to the current PR -->
3839

39-
- [ ] Tested code with current [supported SDKs](../readme.md#supported)
40-
- [ ] Pull Request has been submitted to the documentation repository [instructions](..\contributing.md#docs). Link: <!-- docs PR link -->
40+
- [ ] Tested code with current [supported SDKs](../#supported)
41+
- [ ] Pull Request has been submitted to the documentation repository [instructions](../blob/main/Contributing.md#docs). Link: <!-- docs PR link -->
4142
- [ ] Sample in sample app has been added / updated (for bug fixes / features)
42-
- [ ] Icon has been created (if new sample) following the [Thumbnail Style Guide and templates](https://github.com/CommunityToolkit/WindowsCommunityToolkit-design-assets)
43+
- [ ] Icon has been created (if new sample) following the [Thumbnail Style Guide and templates](https://github.com/CommunityToolkit/WindowsCommunityToolkit-design-assets)
4344
- [ ] New major technical changes in the toolkit have or will be added to the [Wiki](https://github.com/CommunityToolkit/WindowsCommunityToolkit/wiki) e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
4445
- [ ] Tests for the changes have been added (for bug fixes / features) (if applicable)
45-
- [ ] Header has been added to all new source files (run *build/UpdateHeaders.bat*)
46+
- [ ] Header has been added to all new source files (run _build/UpdateHeaders.bat_)
4647
- [ ] Contains **NO** breaking changes
4748

4849
<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below.
49-
Please note that breaking changes are likely to be rejected within minor release cycles or held until major versions. -->
50-
50+
Please note that breaking changes are likely to be rejected within minor release cycles or held until major versions. -->
5151

5252
## Other information
53+
54+
<!-- Please add any other information that might be helpful to reviewers. -->

CODE_OF_CONDUCT.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,9 @@ members of the project's leadership.
6868
## Attribution
6969

7070
This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4,
71-
available at https://www.contributor-covenant.org/version/1/4/code-of-conduct.html
71+
available at <https://www.contributor-covenant.org/version/1/4/code-of-conduct.html>
7272

7373
[homepage]: https://www.contributor-covenant.org
7474

7575
For answers to common questions about this code of conduct, see
76-
https://www.contributor-covenant.org/faq
76+
<https://www.contributor-covenant.org/faq>

Contributing.md

Lines changed: 27 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,39 +1,46 @@
1-
# Contributing to the Windows Community Toolkit :sparkles::sparkles:
1+
# Contributing to the Windows Community Toolkit
22

33
Thank you for exhibiting interest in contributing to the Windows Community Toolkit. The team is delighted to welcome you onboard to our exciting and growing project. Any contribution or value added go a long way to enhance the project!
44

55
In the next few steps, you will be able to see a glimpse of ways you can contribute to the Windows Community Toolkit.
66

7-
:rotating_light: **It is highly recommended to visit [Windows Community Toolkit Wiki](https://aka.ms/wct/wiki) where you can find complete and detail-oriented content of this page** :rotating_light:
7+
🚨 **It is highly recommended to visit [Windows Community Toolkit Wiki](https://aka.ms/wct/wiki) where you can find complete and detail-oriented content of this page** 🚨
88

9-
## <a name="question"></a> Questions :grey_question:
10-
Due to the high volume of incoming issues please keep our GitHub issues for bug reports and feature requests. For general questions, there is a higher chance of getting your question answered on [StackOverflow](https://stackoverflow.com/questions/tagged/windows-community-toolkit) where questions should be tagged with the tag windows-community-toolkit.
9+
## ❔ Questions <a name="question"></a>
10+
11+
Due to the high volume of incoming issues please keep our GitHub issues for bug reports and feature requests. For general questions, there is a higher chance of getting your question answered on [StackOverflow](https://stackoverflow.com/questions/tagged/windows-community-toolkit) where questions should be tagged with the tag `windows-community-toolkit`.
1112

1213
For missing documentation related question, please file an issue at [Microsoft Docs](https://github.com/MicrosoftDocs/WindowsCommunityToolkitDocs/issues/new).
1314

14-
## <a name="bug"></a> Fix a Bug :bug:
15-
If you find any bug, you can help the community by [submitting an issue](https://github.com/CommunityToolkit/WindowsCommunityToolkit/issues/new?assignees=&labels=bug+%3Abug%3A&template=bug_report.md&title=). Once the issue is filed, feel free to start working on the PR and submit a PR.
15+
## 🐛 Fix a Bug <a name="bug"></a>
16+
17+
If you find any bug, you can help the community by [submitting an issue](https://github.com/CommunityToolkit/WindowsCommunityToolkit/issues/new?template=bug_report.md&labels=bug+:bug:&title=[Bug]). Once the issue is filed, feel free to start working on the PR and submit a PR.
18+
19+
## 👌 Good First Issue <a name="issue"></a>
20+
21+
If this is your first time contributing to the Windows Community Toolkit (_WCT_) and do not have advanced level programming experience, we have got you covered 💥 WCT has a list of [good first issue](https://github.com/CommunityToolkit/WindowsCommunityToolkit/labels/good%20first%20issue) that can be a great entryway to find and fix any issues that best fit your expertise or technical background.
1622

17-
## <a name="issue"></a>Good First Issue :ok_hand:
18-
If this is your first time contributing to the Windows Community Toolkit and do not have advanced level programming experience, we have got you covered :boom: WCT has a list of [good first issue](https://github.com/CommunityToolkit/WindowsCommunityToolkit/labels/good%20first%20issue%20%3Aok_hand%3A) that can be a great entryway to find and fix any issues that best fit your expertise or technical background.
23+
## 🙋 Help Wanted <a name="help"></a>
1924

20-
## <a name="help"></a>Help Wanted :raising_hand:
21-
WCT has a list of issues that are labeled as [help wanted](https://github.com/CommunityToolkit/WindowsCommunityToolkit/labels/help%20wanted%20%3Araising_hand%3A). The level of complexity in the list can vary but if you have an advanced level of programming experience, feel free to jump in to solve these issues.
25+
WCT also has a list of issues that are labeled as [help wanted](https://github.com/CommunityToolkit/WindowsCommunityToolkit/labels/help%20wanted). The level of complexity in the list can vary but if you have an advanced level of programming experience, feel free to jump in to solve these issues.
2226

23-
## <a name="feature"></a>Add New Feature :mailbox_with_mail:
24-
* To contribute a new feature, fill out the [Feature Request Template](https://github.com/CommunityToolkit/WindowsCommunityToolkit/issues/new?assignees=&labels=feature+request+%3Amailbox_with_mail%3A&template=feature_request.md&title=%5BFeature%5D) and provide detailed information to express the proposal.
25-
* Once the Feature Request is submitted, it will be open for discussion.
26-
* If it gets approved by the team, proceed to submit a PR of the proposed Feature.
27-
* If the PR contains an error-free code and the reviewer signs off, the PR will be merged.
27+
## 📬 Add New Feature <a name="feature"></a>
2828

29-
## <a name="docs"></a> Add or Improve Documentation :page_with_curl:
29+
* To contribute a new feature, fill out the [Feature Request Template](https://github.com/CommunityToolkit/WindowsCommunityToolkit/issues/new?template=feature_request.md&labels=feature+request+:mailbox_with_mail:&title=[Feature]) and provide detailed information to express the proposal.
30+
* Once the Feature Request is submitted, it will be open for discussion.
31+
* If it gets approved by the team, proceed to submit a PR of the proposed Feature.
32+
* If the PR contains an error-free code and the reviewer signs off, the PR will be merged.
33+
34+
## 📝 Add or Improve Documentation <a name="docs"></a>
3035

3136
Due to the involvement of multiple steps to add or improve documents; it is required to visit [Windows Community Toolkit Wiki](https://aka.ms/wct/wiki) and follow contribution guidelines.
3237

33-
## <a name="pr"></a>Create, Submit or Review Pull Request :rocket:
34-
Anyone with write access can create a Pull Request by forking the Windows Community Toolkit Repository. Here is how you can [Create a Pull Request from fork](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork). Once you fork the Windows Community Toolkit repo, it is essential to create all changes in the feature branch of your forked repository. If you have the changes in the forked feature branch, you can then create a Pull Request in the main Windows Community Toolkit.
38+
## 🚀 Create, Submit or Review Pull Request <a name="pr"></a>
39+
40+
Anyone can create a Pull Request by forking the Windows Community Toolkit Repository. Here is how you can [Create a Pull Request from fork](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork). Once you fork the Windows Community Toolkit repo, it is essential to create all changes in the feature branch of your forked repository. If you have the changes in the forked feature branch, you can then create a Pull Request in the main Windows Community Toolkit.
3541

3642
Please visit [Windows Community Toolkit Wiki](https://aka.ms/wct/wiki) for detailed information and steps it requires to Submit or Review Pull Request.
3743

38-
# ThankYou :heart::heart:
39-
**Thank you so much for contributing to this amazing project. We hope you will continue to add value and find yourself as a highly reliable source to the Windows Community Toolkit**
44+
## 💙 Thank You
45+
46+
**Thank you so much for contributing to this amazing project. We hope you will continue to add value and find yourself as a highly reliable source to the Windows Community Toolkit.**

0 commit comments

Comments
 (0)