Skip to content

Commit 59174fe

Browse files
Merge branch 'master' into testsCI+UnitTestFixes
2 parents 200f05e + 5e01ab6 commit 59174fe

File tree

2 files changed

+23
-4
lines changed

2 files changed

+23
-4
lines changed

Microsoft.Toolkit.Uwp.UI.Controls/MarkdownTextBlock/MarkdownTextBlock.Methods.cs

Lines changed: 22 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,9 @@ private void RenderMarkdown()
4848
// Disconnect from OnClick handlers.
4949
UnhookListeners();
5050

51+
// Clear everything that exists.
52+
_listeningHyperlinks.Clear();
53+
5154
var markdownRenderedArgs = new MarkdownRenderedEventArgs(null);
5255

5356
// Make sure we have something to parse.
@@ -174,23 +177,38 @@ private void RenderMarkdown()
174177
MarkdownRendered?.Invoke(this, markdownRenderedArgs);
175178
}
176179

177-
private void UnhookListeners()
180+
private void HookListeners()
178181
{
179-
// Clear any hyper link events if we have any
182+
// Re-hook all hyper link events we currently have
180183
foreach (object link in _listeningHyperlinks)
181184
{
182185
if (link is Hyperlink hyperlink)
183186
{
184187
hyperlink.Click -= Hyperlink_Click;
188+
hyperlink.Click += Hyperlink_Click;
185189
}
186190
else if (link is Image image)
187191
{
188192
image.Tapped -= NewImagelink_Tapped;
193+
image.Tapped += NewImagelink_Tapped;
189194
}
190195
}
196+
}
191197

192-
// Clear everything that exists.
193-
_listeningHyperlinks.Clear();
198+
private void UnhookListeners()
199+
{
200+
// Unhook any hyper link events if we have any
201+
foreach (object link in _listeningHyperlinks)
202+
{
203+
if (link is Hyperlink hyperlink)
204+
{
205+
hyperlink.Click -= Hyperlink_Click;
206+
}
207+
else if (link is Image image)
208+
{
209+
image.Tapped -= NewImagelink_Tapped;
210+
}
211+
}
194212
}
195213

196214
/// <summary>

Microsoft.Toolkit.Uwp.UI.Controls/MarkdownTextBlock/MarkdownTextBlock.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ private void ThemeListener_ThemeChanged(Helpers.ThemeListener sender)
4747
private void OnLoaded(object sender, RoutedEventArgs e)
4848
{
4949
RegisterThemeChangedHandler();
50+
HookListeners();
5051

5152
// Register for property callbacks that are owned by our parent class.
5253
_fontSizePropertyToken = RegisterPropertyChangedCallback(FontSizeProperty, OnPropertyChanged);

0 commit comments

Comments
 (0)