Merge remote-tracking branch 'origin/master' into u/vgromfeld/bindableAttributeRemoved

Author: vgromfeld

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,10 +1,10 @@
-## Fixes #<!-- Link to relevant issue (for ex: #1234) which will automatically close the issue once the PR is merged -->
+## Fixes #<!-- Link to relevant issue (for ex: #1234) which will automatically close the issue once the PR is merged. -->
 
-<!-- Add a brief overview here of the feature/bug & fix -->
+<!-- Add a brief overview here of the feature/bug & fix. -->
 
 ## PR Type
 What kind of change does this PR introduce?
-<!-- Please uncomment one ore more that apply to this PR -->
+<!-- Please uncomment one or more that apply to this PR. -->
 
 <!-- - Bugfix -->
 <!-- - Feature -->
@@ -38,7 +38,7 @@ Please check if your PR fulfills the following requirements:
 - [ ] Contains **NO** breaking changes
 
 <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. 
-     Please note that breaking changes are likely to be rejected -->
+     Please note that breaking changes are likely to be rejected. -->
 
 
 ## Other information

CODE_OF_CONDUCT.md

@@ -0,0 +1,76 @@
+# Contributor Covenant Code of Conduct
+
+## Our Pledge
+
+In the interest of fostering an open and welcoming environment, we as
+contributors and maintainers pledge to making participation in our project and
+our community a harassment-free experience for everyone, regardless of age, body
+size, disability, ethnicity, sex characteristics, gender identity and expression,
+level of experience, education, socio-economic status, nationality, personal
+appearance, race, religion, or sexual identity and orientation.
+
+## Our Standards
+
+Examples of behavior that contributes to creating a positive environment
+include:
+
+* Using welcoming and inclusive language
+* Being respectful of differing viewpoints and experiences
+* Gracefully accepting constructive criticism
+* Focusing on what is best for the community
+* Showing empathy towards other community members
+
+Examples of unacceptable behavior by participants include:
+
+* The use of sexualized language or imagery and unwelcome sexual attention or
+ advances
+* Trolling, insulting/derogatory comments, and personal or political attacks
+* Public or private harassment
+* Publishing others' private information, such as a physical or electronic
+ address, without explicit permission
+* Other conduct which could reasonably be considered inappropriate in a
+ professional setting
+
+## Our Responsibilities
+
+Project maintainers are responsible for clarifying the standards of acceptable
+behavior and are expected to take appropriate and fair corrective action in
+response to any instances of unacceptable behavior.
+
+Project maintainers have the right and responsibility to remove, edit, or
+reject comments, commits, code, wiki edits, issues, and other contributions
+that are not aligned to this Code of Conduct, or to ban temporarily or
+permanently any contributor for other behaviors that they deem inappropriate,
+threatening, offensive, or harmful.
+
+## Scope
+
+This Code of Conduct applies both within project spaces and in public spaces
+when an individual is representing the project or its community. Examples of
+representing a project or community include using an official project e-mail
+address, posting via an official social media account, or acting as an appointed
+representative at an online or offline event. Representation of a project may be
+further defined and clarified by project maintainers.
+
+## Enforcement
+
+Instances of abusive, harassing, or otherwise unacceptable behavior may be
+reported by contacting the project team at conduct@dotnetfoundation.org. All
+complaints will be reviewed and investigated and will result in a response that
+is deemed necessary and appropriate to the circumstances. The project team is
+obligated to maintain confidentiality with regard to the reporter of an incident.
+Further details of specific enforcement policies may be posted separately.
+
+Project maintainers who do not follow or enforce the Code of Conduct in good
+faith may face temporary or permanent repercussions as determined by other
+members of the project's leadership.
+
+## Attribution
+
+This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4,
+available at https://www.contributor-covenant.org/version/1/4/code-of-conduct.html
+
+[homepage]: https://www.contributor-covenant.org
+
+For answers to common questions about this code of conduct, see
+https://www.contributor-covenant.org/faq

azure-pipelines.yml

@@ -52,8 +52,14 @@ steps:
 #- powershell: .\build\Install-WindowsSdkISO.ps1 17763
 #  displayName: Insider SDK
 
-- powershell: .\build\build.ps1 -target=Default
-  displayName: Build 
+- powershell: .\build\build.ps1 -target=Build
+  displayName: Build
+
+- powershell: .\build\build.ps1 -target=Test
+  displayName: Test
+
+- powershell: .\build\build.ps1 -target=Package
+  displayName: Package
 
 - task: PublishTestResults@2
   inputs:

build/build.cake

@@ -94,6 +94,14 @@ void VerifyHeaders(bool Replace)
     }
 }
 
+void RetrieveVersion()
+{
+	Information("\nRetrieving version...");
+    var results = StartPowershellFile(versionClient);
+    Version = results[1].Properties["NuGetPackageVersion"].Value.ToString();
+    Information("\nBuild Version: " + Version);
+}
+
 //////////////////////////////////////////////////////////////////////
 // DEFAULT TASK
 //////////////////////////////////////////////////////////////////////
@@ -137,14 +145,11 @@ Task("Version")
 
     NuGetInstall(new []{"nerdbank.gitversioning"}, installSettings);
 
-    Information("\nRetrieving version...");
-    var results = StartPowershellFile(versionClient);
-    Version = results[1].Properties["NuGetPackageVersion"].Value.ToString();
-    Information("\nBuild Version: " + Version);
+	RetrieveVersion();
 });
 
-Task("Build")
-    .Description("Build all projects and get the assemblies")
+Task("BuildProjects")
+    .Description("Build all projects")
     .IsDependentOn("Version")
     .Does(() =>
 {
@@ -173,9 +178,9 @@ Task("Build")
 });
 
 Task("InheritDoc")
-	.Description("Updates <inheritdoc /> tags from base classes, interfaces, and similar methods")
-	.IsDependentOn("Build")
-	.Does(() =>
+    .Description("Updates <inheritdoc /> tags from base classes, interfaces, and similar methods")
+    .IsDependentOn("BuildProjects")
+    .Does(() =>
 {
 	Information("\nDownloading InheritDoc...");
 	var installSettings = new NuGetInstallSettings {
@@ -201,9 +206,13 @@ Task("InheritDoc")
     Information("\nFinished generating documentation with InheritDoc");
 });
 
+Task("Build")
+    .Description("Build all projects runs InheritDoc")
+    .IsDependentOn("BuildProjects")
+    .IsDependentOn("InheritDoc");
+
 Task("Package")
 	.Description("Pack the NuPkg")
-	.IsDependentOn("InheritDoc")
 	.Does(() =>
 {
 	// Invoke the pack target in the end
@@ -236,12 +245,14 @@ Task("Package")
     buildSettings.SetPlatformTarget(PlatformTarget.x86);
     MSBuild(Solution, buildSettings);
 
+    RetrieveVersion();
+
     var nuGetPackSettings = new NuGetPackSettings
 	{
 		OutputDirectory = nupkgDir,
         Version = Version
 	};
-
+	
     var nuspecs = GetFiles("./*.nuspec");
     foreach (var nuspec in nuspecs)
     {
@@ -264,7 +275,6 @@ public string getMSTestAdapterPath(){
 
 Task("Test")
 	.Description("Runs all Tests")
-	.IsDependentOn("Build")
     .Does(() =>
 {
 	var vswhere = VSWhereLatest(new VSWhereLatestSettings
@@ -300,7 +310,8 @@ Task("Test")
 //////////////////////////////////////////////////////////////////////
 
 Task("Default")
-	.IsDependentOn("Test")
+    .IsDependentOn("Build")
+    .IsDependentOn("Test")
     .IsDependentOn("Package");
 
 Task("UpdateHeaders")

contributing.md

@@ -36,12 +36,11 @@ For every contribution, you must:
 * target master branch (or an appropriate release branch if appropriate for a bug fix)
 
 * If adding a new feature
-    * Before starting coding, **you should open an uservoice entry** under "Windows Community Toolkit" on [Uservoice](https://wpdev.uservoice.com/forums/110705-universal-windows-platform/category/193402-uwp-community-toolkit) and start discussing with the community to see if your idea/feature is interesting enough.
+    * Before starting coding, **you should open an [issue](https://github.com/windows-toolkit/WindowsCommunityToolkit/issues/new?assignees=&labels=feature+request+%3Amailbox_with_mail%3A&template=feature_request.md&title=%5BFeature%5D)** and start discussing with the community to see if your idea/feature is interesting enough.
     * Add or update a sample for the [Sample app](https://github.com/windows-toolkit/WindowsCommunityToolkit/tree/master/Microsoft.Toolkit.Uwp.SampleApp)
         * If creating a new sample, create a new icon by following the [Thumbnail Style Guide and templates](https://github.com/Microsoft/UWPCommunityToolkit-design-assets)
     * Add or update unit tests (if applicable)
 
-
 PR has to be validated by at least two core members before being merged.
 
 Once merged, you can get a pre-release package of the toolkit by adding this ([Nuget repo](https://dotnet.myget.org/F/uwpcommunitytoolkit/api/v3/index.json) | [Gallery](https://dotnet.myget.org/gallery/uwpcommunitytoolkit)) to your Visual Studio.

readme.md

@@ -188,7 +188,7 @@ Do you want to contribute? Here are our [contribution guidelines](https://github
 
 This project has adopted the code of conduct defined by the [Contributor Covenant](http://contributor-covenant.org/)
 to clarify expected behavior in our community.
-For more information see the [.NET Foundation Code of Conduct](http://dotnetfoundation.org/code-of-conduct).
+For more information see the [.NET Foundation Code of Conduct](CODE_OF_CONDUCT.md).
 
 ## Roadmap
 Read what we [plan for next iterations](https://github.com/windows-toolkit/WindowsCommunityToolkit/milestones), and feel free to ask questions.