Skip to content

Commit 26d32b3

Browse files
Merge pull request #2895 from windows-toolkit/mhawker/sample-fixes
Minor Sample App/Doc Changes
2 parents 6d65c4c + dd9219f commit 26d32b3

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

Microsoft.Toolkit.Uwp.SampleApp/SamplePages/TextToolbar/TextToolbar.bind

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
xmlns:converters="using:Microsoft.Toolkit.Uwp.UI.Converters"
66
xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
77
xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
8+
xmlns:contract7Present="http://schemas.microsoft.com/winfx/2006/xaml/presentation?IsApiContractPresent(Windows.Foundation.UniversalApiContract,7)"
89
mc:Ignorable="d">
910

1011
<Page.Resources>
@@ -40,7 +41,8 @@
4041
Padding="10,3"
4142
BorderThickness="1"
4243
BorderBrush="{ThemeResource SystemControlForegroundChromeHighBrush}"
43-
Foreground="{ThemeResource SystemControlForegroundBaseMediumBrush}" />
44+
Foreground="{ThemeResource SystemControlForegroundBaseMediumBrush}"
45+
contract7Present:SelectionFlyout="{x:Null}"/>
4446
<Grid x:Name="MD"
4547
Grid.Row="1"
4648
Margin="0, 16"

Microsoft.Toolkit.Uwp.SampleApp/SamplePages/TextToolbar/TextToolbarPage.xaml.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ private void Previewer_LinkClicked(object sender, LinkClickedEventArgs e)
157157
try
158158
{
159159
var link = new Uri(e.Link);
160-
var linkOpen = Task.Run(() => Launcher.LaunchUriAsync(link));
160+
_ = Launcher.LaunchUriAsync(link);
161161
}
162162
catch
163163
{

Microsoft.Toolkit.Uwp/Helpers/SystemInformation.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -224,6 +224,7 @@ void App_VisibilityChanged(Windows.UI.Core.CoreWindow sender, Windows.UI.Core.Vi
224224
/// Launches the store app so the user can leave a review.
225225
/// </summary>
226226
/// <returns>A <see cref="Task"/> representing the asynchronous operation.</returns>
227+
/// <remarks>This method needs to be called from your UI thread.</remarks>
227228
public static async Task LaunchStoreForReviewAsync()
228229
{
229230
await Launcher.LaunchUriAsync(new Uri(string.Format("ms-windows-store://review/?PFN={0}", Package.Current.Id.FamilyName)));

0 commit comments

Comments
 (0)