Skip to content

Better support for NotifyCollectionChanged event #298

Open
@michael-hawker

Description

@michael-hawker

Describe the bug

We have 6 explicit places we reference the NotifyCollectionChanged event in the Toolkit: https://github.com/search?q=repo%3ACommunityToolkit%2FWindows%20NotifyCollectionChanged&type=code

  • MetadataControl - Updates everything all the time regardless
  • WrapLayout/StaggeredLayout - Does something with Indexes? Probably need update?
  • IsNullOrEmptyStateTrigger - Just uses it as an indicator to check collection size, so should be good
  • InterspersedObservableCollection (TokenizingTextBox) - Looks like it handles multiple changes already, but could probably use tests for this scenario? (Actually, looks like we didn't bring their original test file forward from the old repo ☹)
  • AdvancedCollectionView - if more than one resets the collection, so doesn't care, but un-optimal

If/When dotnet/runtime#18087 gets implemented, it'd be good for the Toolkit to just be ready and work. Many of our other collection controls are just based on ListViewBase and don't do anything too special, so I think we should be good other from the above?

Steps to reproduce

N/A

Expected behavior

Should work with multiple items in a collection changed event.

Screenshots

No response

Code Platform

  • UWP
  • WinAppSDK / WinUI 3
  • Web Assembly (WASM)
  • Android
  • iOS
  • MacOS
  • Linux / GTK

Windows Build Number

  • Windows 10 1809 (Build 17763)
  • Windows 10 1903 (Build 18362)
  • Windows 10 1909 (Build 18363)
  • Windows 10 2004 (Build 19041)
  • Windows 10 20H2 (Build 19042)
  • Windows 10 21H1 (Build 19043)
  • Windows 10 21H2 (Build 19044)
  • Windows 10 22H2 (Build 19045)
  • Windows 11 21H2 (Build 22000)
  • Other (specify)

Other Windows Build number

No response

App minimum and target SDK version

  • Windows 10, version 1809 (Build 17763)
  • Windows 10, version 1903 (Build 18362)
  • Windows 10, version 1909 (Build 18363)
  • Windows 10, version 2004 (Build 19041)
  • Windows 10, version 2104 (Build 20348)
  • Windows 11, version 22H2 (Build 22000)
  • Other (specify)

Other SDK version

No response

Visual Studio Version

No response

Visual Studio Build Number

No response

Device form factor

No response

Additional context

No response

Help us help you

No, I'm unable to contribute a solution.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions