Fix IsNullOrEmptyStateTrigger for Uno to consider FEs as non-empty (#452)

Youssef1313 · Arlodotexe · web-flow · commit 815d629851d5 · 2024-07-09T20:44:33.000Z
* Fix `IsNullOrEmptyStateTrigger` for Uno to consider FEs as non-empty

* Added regression tracking for workaround

* Fix build error

---------

Co-authored-by: Arlo &lt;arlo.godfrey@outlook.com&gt;
diff --git a/components/Triggers/src/IsNullOrEmptyStateTrigger.cs b/components/Triggers/src/IsNullOrEmptyStateTrigger.cs
@@ -117,8 +117,13 @@ private static bool IsNullOrEmpty(object val)
         }
 
         // Object is not an ICollection, check for an empty IEnumerable
-        var valEnumerable = val as IEnumerable;
-        if (valEnumerable != null)
+        if (val is IEnumerable valEnumerable
+// Workaround to regression introduced in https://github.com/unoplatform/uno/pull/16834
+// Track https://github.com/unoplatform/uno/issues/17311 for cleanup
+#if HAS_UNO
+            && val is not FrameworkElement
+#endif
+            )
         {
             foreach (var item in valEnumerable)
             {

Original file line number	Diff line number	Diff line change
`@@ -117,8 +117,13 @@ private static bool IsNullOrEmpty(object val)`
`117`	`117`	`}`
`118`	`118`
`119`	`119`	`// Object is not an ICollection, check for an empty IEnumerable`
`120`		`- var valEnumerable = val as IEnumerable;`
`121`		`- if (valEnumerable != null)`
	`120`	`+ if (val is IEnumerable valEnumerable`
	`121`	`+// Workaround to regression introduced in https://github.com/unoplatform/uno/pull/16834`
	`122`	`+// Track https://github.com/unoplatform/uno/issues/17311 for cleanup`
	`123`	`+#if HAS_UNO`
	`124`	`+ && val is not FrameworkElement`
	`125`	`+#endif`
	`126`	`+ )`
`122`	`127`	`{`
`123`	`128`	`foreach (var item in valEnumerable)`
`124`	`129`	`{`