Skip to content

Commit b121eb5

Browse files
committed
Remove error for 'HasWindowsUIXaml'
1 parent ce1cffc commit b121eb5

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

MultiTarget/MultiTargetIdentifiers.props

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -78,10 +78,11 @@
7878
<Error Condition="'$(IsNetstandard)' == 'true' AND '$(IsUno)' == 'true'" Text="Projects cannot MultiTarget both netstandard and Uno Platform." />
7979

8080
<!--
81-
UWP XAML can only be enabled for UWP projects. No need to warn for UWP XAML
82-
being disabled when WinUI 2 is used, as that will already fail to build.
81+
UWP XAML can only be enabled for UWP projects. No need to warn for UWP XAML being disabled
82+
when WinUI 2 is used, as that will already fail to build. Note that we don't emit an error
83+
for legacy UWP, as otherwise setting this property would require handling conditions to
84+
filter TFMs, which is very clunky. Instead, it'll just be a no-op for legacy UWP projects.
8385
-->
8486
<Error Condition="'$(HasWindowsUIXaml)' == 'true' AND '$(IsUwp)' != 'true'" Text="Projects cannot reference Windows UI XAML if they're not targeting UWP." />
85-
<Error Condition="'$(HasWindowsUIXaml)' == 'false' AND '$(IsUwp)' == 'true' AND '$(MultiTargetPlatformIdentifier)' != 'windows'" Text="Projects cannot disabl Windows UI XAML if they're targeting legacy UWP." />
8687
</Target>
8788
</Project>

0 commit comments

Comments
 (0)