Skip to content

Commit a7a04cd

Browse files
committed
Fixed PackageId being overridden by MSBuild.Sdk.Extras import
1 parent c7ae0a0 commit a7a04cd

File tree

3 files changed

+11
-6
lines changed

3 files changed

+11
-6
lines changed

MultiTarget/Library.props

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,4 @@
2828

2929
<!-- Import Uno and native dependencies for all multitargeted library projects. -->
3030
<Import Project="$(MSBuildProjectDirectory)\Dependencies.props" Condition="Exists('$(MSBuildProjectDirectory)\Dependencies.props')" />
31-
32-
<Sdk Condition="'$(IsUwp)' == 'true'" Name="MSBuild.Sdk.Extras" Version="3.0.23" />
3331
</Project>

ToolkitComponent.SampleProject.props

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@
66
<!-- Set up the MultiTarget system -->
77
<Import Project="$(ToolingDirectory)\MultiTarget\Library.props" />
88

9+
<Sdk Condition="'$(IsUwp)' == 'true'" Name="MSBuild.Sdk.Extras" Version="3.0.23" />
10+
911
<!-- Import this component's source project -->
1012
<ItemGroup>
1113
<ProjectReference Include="$(MSBuildProjectDirectory)\..\src\*.csproj" />

ToolkitComponent.SourceProject.props

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,23 @@
33
<Error Condition="$(ToolkitComponentName) == ''" Message="ToolkitComponentName is not defined. Please check your csproj." />
44
</Target>
55

6-
<!-- Set up the MultiTarget system -->
7-
<Import Project="$(ToolingDirectory)\MultiTarget\Library.props" />
8-
96
<PropertyGroup>
107
<DateForVersion Condition="'$(DateForVersion)' == ''">$([System.DateTime]::UtcNow.ToString(yyMMdd))</DateForVersion>
118
<Version Condition="'$(Version)' == ''">$(MajorVersion).$(MinorVersion).$(DateForVersion)</Version>
129
<Version Condition="'$(PreviewVersion)' != ''">$(Version)-$(PreviewVersion)</Version>
10+
</PropertyGroup>
11+
12+
<!-- Set up the MultiTarget system -->
13+
<Import Project="$(ToolingDirectory)\MultiTarget\Library.props" />
14+
15+
<PropertyGroup>
1316
<PackageId Condition="'$(PackageId)' == ''">$(PackageIdPrefix).$(PackageIdVariant).$(ToolkitComponentName)</PackageId>
1417
</PropertyGroup>
1518

19+
<Sdk Condition="'$(IsUwp)' == 'true'" Name="MSBuild.Sdk.Extras" Version="3.0.23" />
20+
1621
<!-- Auto Generate our own Assembly Info -->
17-
<PropertyGroup>
22+
<PropertyGroup>
1823
<!-- Turn-off .NET based AssemblyInfo.cs generator, see below -->
1924
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
2025
</PropertyGroup>

0 commit comments

Comments
 (0)