Skip to content

Commit 35c03df

Browse files
authored
Merge pull request #61 from CommunityToolkit/fix/dependencies/system.collections.immutable-
Remove System.Collections.Immutable dependency where not needed
2 parents 6ebcc6d + ae15b1d commit 35c03df

File tree

8 files changed

+6
-10
lines changed

8 files changed

+6
-10
lines changed

CommunityToolkit.Tooling.SampleGen.Tests/ToolkitSampleMetadataTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
using Microsoft.CodeAnalysis.CSharp;
99
using Microsoft.CodeAnalysis.Text;
1010
using Microsoft.VisualStudio.TestTools.UnitTesting;
11+
using System.Collections.Immutable;
1112
using System.ComponentModel.DataAnnotations;
1213

1314
namespace CommunityToolkit.Tooling.SampleGen.Tests;

CommunityToolkit.Tooling.SampleGen/ToolkitSampleMetadataGenerator.Documentation.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
using CommunityToolkit.Tooling.SampleGen.Metadata;
88
using Microsoft.CodeAnalysis;
99
using Microsoft.CodeAnalysis.Text;
10+
using System.Collections.Immutable;
1011

1112
namespace CommunityToolkit.Tooling.SampleGen;
1213

CommunityToolkit.Tooling.TestGen.Tests/UIThreadTestMethodTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
using Microsoft.CodeAnalysis;
88
using Microsoft.CodeAnalysis.CSharp;
99
using Microsoft.VisualStudio.TestTools.UnitTesting;
10+
using System.Collections.Immutable;
1011

1112
namespace CommunityToolkit.Tooling.TestGen.Tests;
1213

GlobalUsings.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77

88
global using System;
99
global using System.Collections.Generic;
10-
global using System.Collections.Immutable;
1110
global using System.Collections.ObjectModel;
1211
global using System.ComponentModel;
1312
global using System.Diagnostics;

MultiTarget/Library.props

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
<Import Project="$(ToolingDirectory)\MultiTarget\DefinedConstants.props" />
1919

2020
<!-- Add platform package dependencies -->
21-
<Import Project="$(ToolingDirectory)\MultiTarget\PackageReferences\Netstandard.props" Condition="$(IsNetstandard) == 'true'" />
2221
<Import Project="$(ToolingDirectory)\MultiTarget\PackageReferences\Uno.props" Condition="$(IsUno) == 'true'" />
2322
<Import Project="$(ToolingDirectory)\MultiTarget\PackageReferences\Uwp.props" Condition="$(IsUwp) == 'true'"/>
2423
<Import Project="$(ToolingDirectory)\MultiTarget\PackageReferences\WinAppSdk.props" Condition="$(IsWinAppSdk) == 'true'"/>

MultiTarget/PackageReferences/Netstandard.props

Lines changed: 0 additions & 5 deletions
This file was deleted.
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
<Project>
22
<ItemGroup>
33
<PackageReference Condition="'$(HasWinUI)' == 'true'" Include="Microsoft.UI.Xaml" Version="2.7.0" />
4-
<PackageReference Include="System.Collections.Immutable" Version="5.0.0" />
54
</ItemGroup>
65
</Project>

ToolkitComponent.SampleProject.props

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,14 @@
22
<Target Name="CheckComponentName">
33
<Error Condition="$(ToolkitComponentName) == ''" Message="ToolkitComponentName is not defined. Please check your csproj." />
44
</Target>
5-
5+
66
<!-- Set up the MultiTarget system -->
77
<Import Project="$(ToolingDirectory)\MultiTarget\Library.props" />
88

99
<!-- Import this component's source project -->
1010
<ItemGroup>
1111
<ProjectReference Include="$(MSBuildProjectDirectory)\..\src\*.csproj" />
12+
<PackageReference Include="System.Collections.Immutable" Version="5.0.0" />
1213
</ItemGroup>
1314

1415
<ItemGroup>
@@ -25,7 +26,7 @@
2526
<!-- Manually include XAML files, except under UWP in Release mode. The files already exist in the final app package (with some modifications) -->
2627
<Content Condition="!('$(IsUwp)' == 'true' AND '$(Configuration)' == 'Release')" Include="**\*.xaml" Exclude="bin\**\*.xaml;obj\**\*.xaml" />
2728

28-
<!-- Manually include .cs and .md files -->
29+
<!-- Manually include .cs and .md files -->
2930
<Content Include="**\*.cs" Exclude="bin\**\*.cs;obj\**\*.cs" />
3031
<Content Include="**\*.md" Exclude="bin\**\*.md;obj\**\*.md" />
3132
</ItemGroup>

0 commit comments

Comments
 (0)