diff --git a/Directory.Build.props b/Directory.Build.props index d1825cea9f..51c6c1b95f 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -170,6 +170,7 @@ xUnit3002: Classes which are JSON serializable should not be tested for their concrete type XC0045: Binding: Property not found XC0103: Consider attributing the markup extension with [RequireService] or [AcceptEmptyServiceProvider] if it doesn't require any + XC0618: Property, Property setter or BindableProperty "BackgroundColor" is deprecated IL2***: Trim Warnings IL3***: AOT Warnings RS2007: Analyzer release file 'AnalyzerReleases.Shipped.md' has a missing or invalid release header--> @@ -182,7 +183,7 @@ xUnit1000,xUnit1001,xUnit1002,xUnit1003,xUnit1004,xUnit1005,xUnit1006,xUnit1007,xUnit1008,xUnit1009,xUnit1010,xUnit1011,xUnit1012,xUnit1013,xUnit1014,xUnit1015,xUnit1016,xUnit1017,xUnit1018,xUnit1019,xUnit1020,xUnit1021,xUnit1022,xUnit1023,xUnit1024,xUnit1025,xUnit1026,xUnit1027,xUnit1028,xUnit1029,xUnit1030,xUnit1031,xUnit1032,xUnit1033,xUnit1034,xUnit1035,xUnit1036,xUnit1037,xUnit1038,xUnit1039,xUnit1040,xUnit1041,xUnit1042,xUnit1043,xUnit1048,xUnit1049,xUnit1050,xUnit1051, xUnit2000,xUnit2001,xUnit2002,xUnit2003,xUnit2004,xUnit2005,xUnit2006,xUnit2007,xUnit2008,xUnit2009,xUnit2010,xUnit2011,xUnit2012,xUnit2013,xUnit2014,xUnit2015,xUnit2016,xUnit2017,xUnit2018,xUnit2019,xUnit2020,xUnit2021,xUnit2022,xUnit2023,xUnit2024,xUnit2025,xUnit2026,xUnit2027,xUnit2028,xUnit2029,xUnit2030,xUnit2031,xUnit2032, xUnit3000,xUnit3001,xUnit3002, - XC0045,XC0103, + XC0045,XC0103,XC0618, IL2001,IL2002,IL2003,IL2004,IL2005,IL2006,IL2007,IL2008,IL2009, IL2010,IL2011,IL2012,IL2013,IL2014,IL2015,IL2016,IL2017,IL2018,IL2019, IL2020,IL2021,IL2022,IL2023,IL2024,IL2025,IL2026,IL2027,IL2028,IL2029, diff --git a/samples/CommunityToolkit.Maui.Sample/App.xaml b/samples/CommunityToolkit.Maui.Sample/App.xaml index a513007377..9167b3b42b 100644 --- a/samples/CommunityToolkit.Maui.Sample/App.xaml +++ b/samples/CommunityToolkit.Maui.Sample/App.xaml @@ -10,42 +10,34 @@ diff --git a/samples/CommunityToolkit.Maui.Sample/AppShell.xaml.cs b/samples/CommunityToolkit.Maui.Sample/AppShell.xaml.cs index 18600e20b9..12721c1b46 100644 --- a/samples/CommunityToolkit.Maui.Sample/AppShell.xaml.cs +++ b/samples/CommunityToolkit.Maui.Sample/AppShell.xaml.cs @@ -120,7 +120,6 @@ public partial class AppShell : Shell CreateViewModelMapping(), CreateViewModelMapping(), CreateViewModelMapping(), - CreateViewModelMapping(), CreateViewModelMapping(), CreateViewModelMapping(), CreateViewModelMapping(), @@ -129,17 +128,16 @@ public partial class AppShell : Shell CreateViewModelMapping(), CreateViewModelMapping(), CreateViewModelMapping(), - CreateViewModelMapping(), - CreateViewModelMapping(), + CreateViewModelMapping(), + CreateViewModelMapping(), CreateViewModelMapping(), CreateViewModelMapping(), CreateViewModelMapping(), + CreateViewModelMapping(), + CreateViewModelMapping(), CreateViewModelMapping(), CreateViewModelMapping(), CreateViewModelMapping(), - CreateViewModelMapping(), - CreateViewModelMapping(), - CreateViewModelMapping(), // Add PlatformSpecific View Models CreateViewModelMapping() diff --git a/samples/CommunityToolkit.Maui.Sample/CommunityToolkit.Maui.Sample.csproj b/samples/CommunityToolkit.Maui.Sample/CommunityToolkit.Maui.Sample.csproj index 05c803ebd2..786e13f8a8 100644 --- a/samples/CommunityToolkit.Maui.Sample/CommunityToolkit.Maui.Sample.csproj +++ b/samples/CommunityToolkit.Maui.Sample/CommunityToolkit.Maui.Sample.csproj @@ -35,10 +35,10 @@ CsWinRT1028 - + diff --git a/samples/CommunityToolkit.Maui.Sample/MauiProgram.cs b/samples/CommunityToolkit.Maui.Sample/MauiProgram.cs index c7268cc8be..095d44bca5 100644 --- a/samples/CommunityToolkit.Maui.Sample/MauiProgram.cs +++ b/samples/CommunityToolkit.Maui.Sample/MauiProgram.cs @@ -2,7 +2,6 @@ using CommunityToolkit.Maui.ApplicationModel; using CommunityToolkit.Maui.Markup; using CommunityToolkit.Maui.Media; -using CommunityToolkit.Maui.Sample.Models; using CommunityToolkit.Maui.Sample.Pages; using CommunityToolkit.Maui.Sample.Pages.Alerts; using CommunityToolkit.Maui.Sample.Pages.Behaviors; @@ -120,7 +119,6 @@ public static MauiApp CreateMauiApp() .AddStandardResilienceHandler(static options => options.Retry = new MobileHttpRetryStrategyOptions()); builder.Services.AddSingleton(); - builder.Services.AddSingleton(); RegisterViewsAndViewModels(builder.Services); RegisterEssentials(builder.Services); @@ -245,7 +243,6 @@ static void RegisterViewsAndViewModels(in IServiceCollection services) // Add Views Pages + ViewModels services.AddTransientWithShellRoute(); services.AddTransientWithShellRoute(); - services.AddTransientWithShellRoute(); services.AddTransientWithShellRoute(); services.AddTransientWithShellRoute(); services.AddTransientWithShellRoute(); @@ -254,8 +251,7 @@ static void RegisterViewsAndViewModels(in IServiceCollection services) services.AddTransientWithShellRoute(); services.AddTransientWithShellRoute(); services.AddTransientWithShellRoute(); - services.AddTransientWithShellRoute(); - services.AddTransientWithShellRoute(); + services.AddTransientWithShellRoute(); services.AddTransientWithShellRoute(); services.AddTransientWithShellRoute(); services.AddTransientWithShellRoute(); @@ -267,7 +263,24 @@ static void RegisterViewsAndViewModels(in IServiceCollection services) services.AddTransientWithShellRoute(); // Add Popups + services.AddTransientPopup(); + services.AddTransientPopup(); services.AddTransientPopup(); + services.AddTransientPopup(); + services.AddTransientPopup(); + services.AddTransientPopup(); + services.AddTransientPopup(); + services.AddTransientPopup(); + services.AddTransientPopup(); + services.AddTransientPopup(); + services.AddTransientPopup(); + services.AddTransientPopup(); + services.AddTransientPopup(); + services.AddTransientPopup(); + services.AddTransientPopup(); + services.AddTransientPopup(); + services.AddTransientPopup(); + services.AddTransientPopup(); services.AddTransientPopup(); services.AddTransientPopup(); } diff --git a/samples/CommunityToolkit.Maui.Sample/Models/PopupSize.cs b/samples/CommunityToolkit.Maui.Sample/Models/PopupSize.cs deleted file mode 100644 index 88cef5a44d..0000000000 --- a/samples/CommunityToolkit.Maui.Sample/Models/PopupSize.cs +++ /dev/null @@ -1,22 +0,0 @@ -namespace CommunityToolkit.Maui.Sample.Models; - -public class PopupSizeConstants -{ - public PopupSizeConstants(IDeviceDisplay deviceDisplay) - { - Tiny = new(100, 100); - Small = new(300, 300); - Medium = new(0.4 * (deviceDisplay.MainDisplayInfo.Width / deviceDisplay.MainDisplayInfo.Density), 0.6 * (deviceDisplay.MainDisplayInfo.Height / deviceDisplay.MainDisplayInfo.Density)); - Large = new(0.5 * (deviceDisplay.MainDisplayInfo.Width / deviceDisplay.MainDisplayInfo.Density), 0.8 * (deviceDisplay.MainDisplayInfo.Height / deviceDisplay.MainDisplayInfo.Density)); - } - - // examples for fixed sizes - public Size Tiny { get; } - - public Size Small { get; } - - // examples for relative to screen sizes - public Size Medium { get; } - - public Size Large { get; } -} \ No newline at end of file diff --git a/samples/CommunityToolkit.Maui.Sample/Pages/Views/MediaElement/MediaElementPage.xaml.cs b/samples/CommunityToolkit.Maui.Sample/Pages/Views/MediaElement/MediaElementPage.xaml.cs index 819e1c9441..4963bdeafe 100644 --- a/samples/CommunityToolkit.Maui.Sample/Pages/Views/MediaElement/MediaElementPage.xaml.cs +++ b/samples/CommunityToolkit.Maui.Sample/Pages/Views/MediaElement/MediaElementPage.xaml.cs @@ -1,9 +1,9 @@ using System.ComponentModel; using CommunityToolkit.Maui.Core.Primitives; +using CommunityToolkit.Maui.Extensions; using CommunityToolkit.Maui.Sample.ViewModels.Views; using CommunityToolkit.Maui.Views; using Microsoft.Extensions.Logging; -using LayoutAlignment = Microsoft.Maui.Primitives.LayoutAlignment; namespace CommunityToolkit.Maui.Sample.Pages.Views; @@ -243,35 +243,18 @@ async void ChangeAspectClicked(object? sender, EventArgs e) MediaElement.Aspect = (Aspect)aspectEnum; } - void DisplayPopup(object sender, EventArgs e) + async void DisplayPopup(object sender, EventArgs e) { MediaElement.Pause(); var popupMediaElement = new MediaElement { Source = MediaSource.FromResource("AppleVideo.mp4"), - HeightRequest = 600, - WidthRequest = 600, ShouldAutoPlay = true, ShouldShowPlaybackControls = true, }; - var popup = new Popup - { - VerticalOptions = LayoutAlignment.Center, - HorizontalOptions = LayoutAlignment.Center, - Content = new StackLayout - { - Children = - { - popupMediaElement, - } - } - }; - this.ShowPopup(popup); - popup.Closed += (s, e) => - { - popupMediaElement.Stop(); - popupMediaElement.Handler?.DisconnectHandler(); - }; + await this.ShowPopupAsync(popupMediaElement); + popupMediaElement.Stop(); + popupMediaElement.Handler?.DisconnectHandler(); } } \ No newline at end of file diff --git a/samples/CommunityToolkit.Maui.Sample/Pages/Views/Popup/CustomSizeAndPositionPopupPage.xaml b/samples/CommunityToolkit.Maui.Sample/Pages/Views/Popup/CustomSizeAndPositionPopupPage.xaml deleted file mode 100644 index bdbb5ec219..0000000000 --- a/samples/CommunityToolkit.Maui.Sample/Pages/Views/Popup/CustomSizeAndPositionPopupPage.xaml +++ /dev/null @@ -1,206 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -