Add Minio hosting/client integration #691

Harold-Morgan · 2025-05-18T14:29:15Z

**Closes #606 **

I've added maybe somewhat barebone (but working!) MiniO storage and client (based on the official https://github.com/minio/minio-dotnet library). It was a ton of fun.

I've added

SkipIfKeyedRegistrationIsNotSupported(useKey);

to ConformanceTests.cs/ConnectionInformationIsDelayValidated because this integration doesn't support keyed registrations untill minio/minio-dotnet#1147 is resolved. I hope this isn't too much, but maybe it should've been done in separate PR.

PR Checklist

Other information

ctolkien · 2025-05-22T06:09:06Z

Would love to see this get finished off.

src/CommunityToolkit.Aspire.Hosting.Minio/MinioBuilderExtensions.cs

davidfowl · 2025-05-24T09:41:20Z

src/CommunityToolkit.Aspire.Hosting.Minio/MinioBuilderExtensions.cs

+        IResourceBuilder<ParameterResource>? rootUser = null,
+        IResourceBuilder<ParameterResource>? rootPassword = null,
+        int minioPort = 9000,
+        int minioConsolePort = 9001)


Remove, this is usually fixed

Thanks!

This is usually fixed, and thinking too much about Minio Console should probably be out of scope for now.

davidfowl · 2025-05-24T09:42:27Z

src/CommunityToolkit.Aspire.Hosting.Minio/MinioHealthCheck.cs

+
+namespace CommunityToolkit.Aspire.Hosting.Minio;
+
+internal sealed class MinioHealthCheck : IHealthCheck


You might be able to use the built in http health check instead of the custom one.

Built in http health check using .AddUrlGroup method really looks better

Thx for comment

Well there’s an even more built in method WithHttpHealthCheck

davidfowl · 2025-05-24T09:43:37Z

This looks really good! Left a few comments.

Harold-Morgan · 2025-05-26T20:26:02Z

I've added WithDataVolume/WithDataBindMount methods to this, because even a basic S3-compatible storage integration wihtout the way to permanently store data isn't up to my personal quality standarts

Also working on @davidfowl comments got me thinking that me "inventing" a connection string for MiniO looking like

"Endpoint=http://localhost:2000;AccessKey=minioadmin;SecretKey=p@ssw0rd1"

may not have been such a good idea (here's a link for further reference)

But currently I cannot think about any other convinient way of passing connection parameters to ApiServices in a DistributedApplication.

I'd be genuinely glad to hear any opinions on this

src/CommunityToolkit.Aspire.Hosting.Minio/MinioContainerResource.cs

davidfowl · 2025-05-29T06:10:28Z

may not have been such a good idea (here's a link for further reference)

It's a good idea. Just expose all of the parts of the connection string so the users can make their own connection strings, but having a default is good.

tests/CommunityToolkit.Aspire.Testing/TestDistributedApplicationBuilder.cs

Harold-Morgan · 2025-05-29T19:24:13Z

I've fixed my silly little tests that were conflicting with port randomization

Now it looks ready

aaronpowell

Looks pretty good. Got a few changes I've noted.

Also, the MinIO docs have the IO part in all capitals (as does the NuGet package), but there's inconsistency in the readme/doc comments - can we have that updated to match the product naming please.

src/CommunityToolkit.Aspire.Hosting.Minio/CommunityToolkit.Aspire.Hosting.Minio.csproj

src/CommunityToolkit.Aspire.Hosting.Minio/MinioBuilderExtensions.cs

aaronpowell · 2025-06-03T04:22:07Z

src/CommunityToolkit.Aspire.Hosting.Minio/MinioContainerResource.cs

+    public MinioContainerResource(string name, ParameterResource user, ParameterResource password) : base(name)
+    {
+        RootUser = user;
+        PasswordParameter = password;
+    }


Can you use a primary constructor for this

Yes, it looks much cleaner now, thanks!

src/CommunityToolkit.Aspire.Hosting.Minio/MinioContainerResource.cs

src/CommunityToolkit.Aspire.Minio.Client/MinioClientBuilderExtensionMethods.cs

src/CommunityToolkit.Aspire.Minio.Client/README.md

aaronpowell · 2025-06-03T04:32:25Z

tests/CommunityToolkit.Aspire.Hosting.Minio.Tests/AppHostTests.cs

+        Assert.Equal(HttpStatusCode.OK, createResponse.StatusCode);
+
+        var getResponse = await httpClient.GetAsync($"/buckets/{bucketName}");
+        Assert.Equal(HttpStatusCode.OK, getResponse.StatusCode);


Can we assert on the returned value, not just the status code?

I've expanded the test a bit, so we can actually upload a string object, then download it and check the result

tests/CommunityToolkit.Aspire.Hosting.Minio.Tests/AppHostTests.cs

aaronpowell

@Harold-Morgan - I noticed you've added yourself to the CODEOWNERS - are you happy to be added as a contributor to the repo as the long-term owner of the integration?

Harold-Morgan · 2025-06-04T04:01:29Z

I would definitely be more than happy to be added as a long-term owner of the integration.

I was planning on adding features and solving issues in the future myself, it is a wonderful opportunity to learn!

@aaronpowell I must note that I haven't yet addressed all the comments in this review (but definitely plan to do so), but you have approved it. Is this ok? I think that I definitely must address all of them in this PR before merging

aaronpowell · 2025-06-04T05:59:25Z

Sorry, that was a mistake on the approval - notifications took me to only seeing some of the changes and I forgot I had more on the list outstanding so I've rolled it back to waiting approval.

max2020204 · 2025-06-05T11:36:58Z

When it can be available from NuGet package?

…ce.cs

Co-authored-by: Aaron Powell <me@aaron-powell.com>

aaronpowell · 2025-06-06T05:49:48Z

When it can be available from NuGet package?

A preview package should be on NuGet soon (takes a few days to go through approval), but you can always use the Azure DevOps feed as described on the README

ctolkien · 2025-06-06T06:15:20Z

@Harold-Morgan - thanks for doing this!!

davidfowl · 2025-06-06T08:18:59Z

Really high quality work @Harold-Morgan !

Harold-Morgan · 2025-06-06T15:38:22Z

Really high quality work @Harold-Morgan !

Jokes aside, sincerely thank you and @aaronpowell for help!

I hope and plan to do more

Harold-Morgan force-pushed the minio_integration branch from bced977 to 6d8e405 Compare May 20, 2025 05:36

Harold-Morgan force-pushed the minio_integration branch from 6d8e405 to 1a79db3 Compare May 24, 2025 08:31

davidfowl reviewed May 24, 2025

View reviewed changes

src/CommunityToolkit.Aspire.Hosting.Minio/MinioBuilderExtensions.cs Outdated Show resolved Hide resolved

davidfowl reviewed May 24, 2025

View reviewed changes

davidfowl reviewed May 27, 2025

View reviewed changes

src/CommunityToolkit.Aspire.Hosting.Minio/MinioContainerResource.cs Outdated Show resolved Hide resolved

davidfowl reviewed May 29, 2025

View reviewed changes

tests/CommunityToolkit.Aspire.Testing/TestDistributedApplicationBuilder.cs Outdated Show resolved Hide resolved

Harold-Morgan marked this pull request as ready for review May 29, 2025 15:14

Harold-Morgan marked this pull request as draft May 29, 2025 15:52

Harold-Morgan marked this pull request as ready for review May 29, 2025 19:24

Harold-Morgan requested a review from davidfowl June 2, 2025 14:30

Harold-Morgan force-pushed the minio_integration branch from ce4533d to b23e8b2 Compare June 2, 2025 14:59

aaronpowell requested changes Jun 3, 2025

View reviewed changes

aaronpowell approved these changes Jun 4, 2025

View reviewed changes

aaronpowell requested changes Jun 4, 2025

View reviewed changes

Harold-Morgan added 7 commits June 5, 2025 18:11

Minio integration raw draft

6ed2fa2

Tests draft

7f9cead

Refinement + project structure + tests

f556a63

Documentation draft

8038e30

Tests added to tests.yaml

a3cba12

Fix ubuntu build

28f7542

README.md final draft

20e93db

Harold-Morgan and others added 10 commits June 5, 2025 18:11

DataVolume api added

53e1a5c

Password/user/port parameters api changed

7178b44

Update src/CommunityToolkit.Aspire.Hosting.Minio/MinioContainerResour…

d625e3b

…ce.cs

Randomize ports fxd + new healthcheck

19f7e27

Fix tests

c1b1a7c

Fix slnx support

8ca5d91

Naming inconsistency fxd

67b09bf

Update src/CommunityToolkit.Aspire.Minio.Client/README.md

d860634

Co-authored-by: Aaron Powell <me@aaron-powell.com>

Apiservice test timeout

11557a9

ApiServiceCreateData test now checks file upload/download result

90a326e

Harold-Morgan force-pushed the minio_integration branch from 6fd3a24 to 90a326e Compare June 5, 2025 15:11

MinioContainerResource.cs class structure revamped

e7b0f70

Harold-Morgan requested a review from aaronpowell June 5, 2025 15:43

aaronpowell approved these changes Jun 6, 2025

View reviewed changes

aaronpowell merged commit 0b672c6 into CommunityToolkit:main Jun 6, 2025
94 checks passed

xRoier mentioned this pull request Jun 8, 2025

Question: MinIO NuGet packages publishment date? #721

Closed


		namespace CommunityToolkit.Aspire.Hosting.Minio;

		internal sealed class MinioHealthCheck : IHealthCheck

Add Minio hosting/client integration #691

Add Minio hosting/client integration #691

Uh oh!

Conversation

Harold-Morgan commented May 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

Other information

Uh oh!

ctolkien commented May 22, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

davidfowl commented May 24, 2025

Uh oh!

Harold-Morgan commented May 26, 2025

Uh oh!

Uh oh!

davidfowl commented May 29, 2025

Uh oh!

Uh oh!

Harold-Morgan commented May 29, 2025

Uh oh!

aaronpowell left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aaronpowell left a comment

Choose a reason for hiding this comment

Uh oh!

Harold-Morgan commented Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aaronpowell commented Jun 4, 2025

Uh oh!

max2020204 commented Jun 5, 2025

Uh oh!

Uh oh!

aaronpowell commented Jun 6, 2025

Uh oh!

ctolkien commented Jun 6, 2025

Uh oh!

davidfowl commented Jun 6, 2025

Uh oh!

Harold-Morgan commented Jun 6, 2025

Uh oh!

Uh oh!

Harold-Morgan commented May 18, 2025 •

edited

Loading

Harold-Morgan commented Jun 4, 2025 •

edited

Loading