drivers: led_strip: Make update channels function optional

Makes the update channels function optional, this is only
implemented in one driver so can be safely omitted from most
drivers

Signed-off-by: Jamie McCrae <spam@helper3000.net>

Author: thedjnK

drivers/led_strip/apa102.c

@@ -74,13 +74,6 @@ static int apa102_update_rgb(const struct device *dev, struct led_rgb *pixels,
 	return apa102_update(dev, pixels, sizeof(struct led_rgb) * count);
 }
 
-static int apa102_update_channels(const struct device *dev, uint8_t *channels,
-				  size_t num_channels)
-{
-	/* Not implemented */
-	return -EINVAL;
-}
-
 static size_t apa102_length(const struct device *dev)
 {
 	const struct apa102_config *config = dev->config;
@@ -101,7 +94,6 @@ static int apa102_init(const struct device *dev)
 
 static const struct led_strip_driver_api apa102_api = {
 	.update_rgb = apa102_update_rgb,
-	.update_channels = apa102_update_channels,
 	.length = apa102_length,
 };
 

drivers/led_strip/tlc5971.c

@@ -253,15 +253,6 @@ static int tlc5971_update_rgb(const struct device *dev, struct led_rgb *pixels,
 	return tlc5971_transmit_data(dev, num_pixels);
 }
 
-static int tlc5971_update_channels(const struct device *dev, uint8_t *channels, size_t num_channels)
-{
-	ARG_UNUSED(dev);
-	ARG_UNUSED(channels);
-	ARG_UNUSED(num_channels);
-
-	return -ENOTSUP;
-}
-
 static size_t tlc5971_length(const struct device *dev)
 {
 	const struct tlc5971_config *cfg = dev->config;
@@ -333,7 +324,6 @@ static int tlc5971_init(const struct device *dev)
 
 static const struct led_strip_driver_api tlc5971_api = {
 	.update_rgb = tlc5971_update_rgb,
-	.update_channels = tlc5971_update_channels,
 	.length = tlc5971_length,
 };
 

drivers/led_strip/ws2812_gpio.c

@@ -180,14 +180,6 @@ static int ws2812_gpio_update_rgb(const struct device *dev,
 	return send_buf(dev, (uint8_t *)pixels, num_pixels * config->num_colors);
 }
 
-static int ws2812_gpio_update_channels(const struct device *dev,
-				       uint8_t *channels,
-				       size_t num_channels)
-{
-	LOG_ERR("update_channels not implemented");
-	return -ENOTSUP;
-}
-
 static size_t ws2812_gpio_length(const struct device *dev)
 {
 	const struct ws2812_gpio_cfg *config = dev->config;
@@ -197,7 +189,6 @@ static size_t ws2812_gpio_length(const struct device *dev)
 
 static const struct led_strip_driver_api ws2812_gpio_api = {
 	.update_rgb = ws2812_gpio_update_rgb,
-	.update_channels = ws2812_gpio_update_channels,
 	.length = ws2812_gpio_length,
 };
 

drivers/led_strip/ws2812_i2s.c

@@ -164,13 +164,6 @@ static int ws2812_strip_update_rgb(const struct device *dev, struct led_rgb *pix
 	return ret;
 }
 
-static int ws2812_strip_update_channels(const struct device *dev, uint8_t *channels,
-					size_t num_channels)
-{
-	LOG_ERR("update_channels not implemented");
-	return -ENOTSUP;
-}
-
 static size_t ws2812_strip_length(const struct device *dev)
 {
 	const struct ws2812_i2s_cfg *cfg = dev->config;
@@ -225,7 +218,6 @@ static int ws2812_i2s_init(const struct device *dev)
 
 static const struct led_strip_driver_api ws2812_i2s_api = {
 	.update_rgb = ws2812_strip_update_rgb,
-	.update_channels = ws2812_strip_update_channels,
 	.length = ws2812_strip_length,
 };
 

drivers/led_strip/ws2812_rpi_pico_pio.c

@@ -109,13 +109,6 @@ static int ws2812_led_strip_update_rgb(const struct device *dev, struct led_rgb
 	return 0;
 }
 
-static int ws2812_led_strip_update_channels(const struct device *dev, uint8_t *channels,
-					    size_t num_channels)
-{
-	LOG_DBG("update_channels not implemented");
-	return -ENOTSUP;
-}
-
 static size_t ws2812_led_strip_length(const struct device *dev)
 {
 	const struct ws2812_led_strip_config *config = dev->config;
@@ -125,7 +118,6 @@ static size_t ws2812_led_strip_length(const struct device *dev)
 
 static const struct led_strip_driver_api ws2812_led_strip_api = {
 	.update_rgb = ws2812_led_strip_update_rgb,
-	.update_channels = ws2812_led_strip_update_channels,
 	.length = ws2812_led_strip_length,
 };
 

drivers/led_strip/ws2812_spi.c

@@ -134,14 +134,6 @@ static int ws2812_strip_update_rgb(const struct device *dev,
 	return rc;
 }
 
-static int ws2812_strip_update_channels(const struct device *dev,
-					uint8_t *channels,
-					size_t num_channels)
-{
-	LOG_ERR("update_channels not implemented");
-	return -ENOTSUP;
-}
-
 static size_t ws2812_strip_length(const struct device *dev)
 {
 	const struct ws2812_spi_cfg *cfg = dev_cfg(dev);
@@ -179,7 +171,6 @@ static int ws2812_spi_init(const struct device *dev)
 
 static const struct led_strip_driver_api ws2812_spi_api = {
 	.update_rgb = ws2812_strip_update_rgb,
-	.update_channels = ws2812_strip_update_channels,
 	.length = ws2812_strip_length,
 };
 

include/zephyr/drivers/led_strip.h

@@ -125,7 +125,7 @@ static inline int led_strip_update_rgb(const struct device *dev,
 }
 
 /**
- * @brief		Function to update an LED strip with the given channel array
+ * @brief		Optional function to update an LED strip with the given channel array
  *			(each channel byte corresponding to an individually addressable color
  *			channel or LED. Channels are updated linearly in strip order.
  *
@@ -134,7 +134,8 @@ static inline int led_strip_update_rgb(const struct device *dev,
  * @param num_channels	Length of channels array.
  *
  * @retval		0 on success.
- * @retval		-errno negative errno code on failure.
+ * @retval		-ENOSYS if not implemented.
+ * @retval		-errno negative errno code on other failure.
  *
  * @warning		This routine may overwrite @a channels.
  */
@@ -145,6 +146,10 @@ static inline int led_strip_update_channels(const struct device *dev,
 	const struct led_strip_driver_api *api =
 		(const struct led_strip_driver_api *)dev->api;
 
+	if (api->update_channels == NULL) {
+		return -ENOSYS;
+	}
+
 	return api->update_channels(dev, channels, num_channels);
 }