Use enhanced enum for screen ids and titles (flutter#4940)

Author: kenzieschmoll

packages/devtools_app/lib/src/app.dart

@@ -578,48 +578,51 @@ class CheckboxSetting extends StatelessWidget {
 List<DevToolsScreen> get defaultScreens {
   return <DevToolsScreen>[
     DevToolsScreen<InspectorController>(
-      const InspectorScreen(),
+      InspectorScreen(),
       createController: (_) => InspectorController(
         inspectorTree: InspectorTreeController(),
         detailsTree: InspectorTreeController(),
         treeType: FlutterTreeType.widget,
       ),
     ),
     DevToolsScreen<PerformanceController>(
-      const PerformanceScreen(),
+      PerformanceScreen(),
       createController: (_) => PerformanceController(),
       supportsOffline: true,
     ),
     DevToolsScreen<ProfilerScreenController>(
-      const ProfilerScreen(),
+      ProfilerScreen(),
       createController: (_) => ProfilerScreenController(),
       supportsOffline: true,
     ),
     DevToolsScreen<MemoryController>(
-      const MemoryScreen(),
+      MemoryScreen(),
       createController: (_) => MemoryController(),
     ),
     DevToolsScreen<DebuggerController>(
-      const DebuggerScreen(),
+      DebuggerScreen(),
       createController: (routerDelegate) => DebuggerController(
         routerDelegate: routerDelegate,
       ),
     ),
     DevToolsScreen<NetworkController>(
-      const NetworkScreen(),
+      NetworkScreen(),
       createController: (_) => NetworkController(),
     ),
     DevToolsScreen<LoggingController>(
-      const LoggingScreen(),
+      LoggingScreen(),
       createController: (_) => LoggingController(),
     ),
-    DevToolsScreen<void>(const ProviderScreen(), createController: (_) {}),
+    DevToolsScreen<void>(
+      ProviderScreen(),
+      createController: (_) {},
+    ),
     DevToolsScreen<AppSizeController>(
-      const AppSizeScreen(),
+      AppSizeScreen(),
       createController: (_) => AppSizeController(),
     ),
     DevToolsScreen<VMDeveloperToolsController>(
-      const VMDeveloperToolsScreen(),
+      VMDeveloperToolsScreen(),
       createController: (_) => VMDeveloperToolsController(),
     ),
     // Show the sample DevTools screen.

packages/devtools_app/lib/src/framework/scaffold.dart

@@ -517,13 +517,13 @@ class KeyboardShortcutsState extends State<KeyboardShortcuts>
 }
 
 class SimpleScreen extends Screen {
-  const SimpleScreen(this.child)
+  SimpleScreen(this.child)
       : super(
           id,
           showFloatingDebuggerControls: false,
         );
 
-  static const id = ScreenIds.simple;
+  static final id = ScreenMetaData.simple.id;
 
   final Widget child;
 

packages/devtools_app/lib/src/screens/app_size/app_size_screen.dart

@@ -32,11 +32,11 @@ const initialFractionForTreemap = 0.67;
 const initialFractionForTreeTable = 0.33;
 
 class AppSizeScreen extends Screen {
-  const AppSizeScreen()
+  AppSizeScreen()
       : super.conditional(
           id: id,
           requiresDartVm: true,
-          title: 'App Size',
+          title: ScreenMetaData.appSize.title,
           icon: Octicons.fileZip,
         );
 
@@ -47,7 +47,7 @@ class AppSizeScreen extends Screen {
   ///
   /// This must be different to the top-level appSizePageId which is also used
   /// in routing when to ensure they have unique URLs.
-  static const id = ScreenIds.appSize;
+  static final id = ScreenMetaData.appSize.id;
 
   @visibleForTesting
   static const diffTypeDropdownKey = Key('Diff Tree Type Dropdown');

packages/devtools_app/lib/src/screens/debugger/debugger_screen.dart

@@ -36,16 +36,16 @@ import 'program_explorer_model.dart';
 import 'variables.dart';
 
 class DebuggerScreen extends Screen {
-  const DebuggerScreen()
+  DebuggerScreen()
       : super.conditional(
           id: id,
           requiresDebugBuild: true,
-          title: 'Debugger',
+          title: ScreenMetaData.debugger.title,
           icon: Octicons.bug,
           showFloatingDebuggerControls: false,
         );
 
-  static const id = ScreenIds.debugger;
+  static final id = ScreenMetaData.debugger.id;
 
   @override
   bool showConsole(bool embed) => true;

packages/devtools_app/lib/src/screens/inspector/inspector_screen.dart

@@ -33,16 +33,16 @@ import 'inspector_tree.dart';
 import 'inspector_tree_controller.dart';
 
 class InspectorScreen extends Screen {
-  const InspectorScreen()
+  InspectorScreen()
       : super.conditional(
           id: id,
           requiresLibrary: flutterLibraryUri,
           requiresDebugBuild: true,
-          title: 'Flutter Inspector',
+          title: ScreenMetaData.inspector.title,
           icon: Octicons.deviceMobile,
         );
 
-  static const id = ScreenIds.inspector;
+  static final id = ScreenMetaData.inspector.id;
 
   // There is not enough room to safely show the console in the embed view of
   // the DevTools and IDEs have their own consoles.

packages/devtools_app/lib/src/screens/logging/logging_screen.dart

@@ -27,14 +27,14 @@ final loggingSearchFieldKey = GlobalKey(debugLabel: 'LoggingSearchFieldKey');
 
 /// Presents logs from the connected app.
 class LoggingScreen extends Screen {
-  const LoggingScreen()
+  LoggingScreen()
       : super(
           id,
-          title: 'Logging',
+          title: ScreenMetaData.logging.title,
           icon: Octicons.clippy,
         );
 
-  static const id = ScreenIds.logging;
+  static final id = ScreenMetaData.logging.id;
 
   @override
   String get docPageId => screenId;

packages/devtools_app/lib/src/screens/memory/memory_screen.dart

@@ -24,15 +24,15 @@ import 'panes/chart/memory_vm_chart.dart';
 import 'panes/control/control_pane.dart';
 
 class MemoryScreen extends Screen {
-  const MemoryScreen()
+  MemoryScreen()
       : super.conditional(
           id: id,
           requiresDartVm: true,
-          title: 'Memory',
+          title: ScreenMetaData.memory.title,
           icon: Octicons.package,
         );
 
-  static const id = ScreenIds.memory;
+  static final id = ScreenMetaData.memory.id;
 
   @override
   ValueListenable<bool> get showIsolateSelector =>

packages/devtools_app/lib/src/screens/network/network_screen.dart

@@ -32,15 +32,15 @@ import 'network_request_inspector.dart';
 final networkSearchFieldKey = GlobalKey(debugLabel: 'NetworkSearchFieldKey');
 
 class NetworkScreen extends Screen {
-  const NetworkScreen()
+  NetworkScreen()
       : super.conditional(
           id: id,
           requiresDartVm: true,
-          title: 'Network',
+          title: ScreenMetaData.network.title,
           icon: Icons.network_check,
         );
 
-  static const id = ScreenIds.network;
+  static final id = ScreenMetaData.network.id;
 
   @override
   String get docPageId => screenId;

packages/devtools_app/lib/src/screens/performance/panes/flutter_frames/flutter_frames_chart.dart

@@ -637,7 +637,7 @@ class FlutterFrameTooltip extends StatelessWidget {
                     shaderText,
                     style: textStyle,
                   ),
-                  const MoreInfoLink(
+                  MoreInfoLink(
                     url: preCompileShadersDocsUrl,
                     gaScreenName: gac.performance,
                     gaSelectedItemDescription:

packages/devtools_app/lib/src/screens/performance/performance_screen.dart

@@ -33,16 +33,16 @@ import 'tabbed_performance_view.dart';
 // where applicable.
 
 class PerformanceScreen extends Screen {
-  const PerformanceScreen()
+  PerformanceScreen()
       : super.conditional(
           id: id,
           requiresDartVm: true,
           worksOffline: true,
-          title: 'Performance',
+          title: ScreenMetaData.performance.title,
           icon: Octicons.pulse,
         );
 
-  static const id = ScreenIds.performance;
+  static final id = ScreenMetaData.performance.id;
 
   @override
   String get docPageId => id;