Merge pull request #48 from Coder-Spirit/fix-symbols-import-on-deno

fix: suport nominal-symbols in deno "pkg"

Author: castarco

nominal/deno/internal/Symbols.ts

@@ -1,11 +1,11 @@
-export const __BaseType: unique symbol = Symbol('__BaseType')
-export const __Properties: unique symbol = Symbol('__Properties')
-export const __Brand: unique symbol = Symbol('__Brand')
-
-export const __PropertyName: unique symbol = Symbol('__PropertyName')
-export const __PropertyValues: unique symbol = Symbol('__PropertyValues')
-
-// Some Nominal tricks rely on the fact that this symbol and its type won't be
-// exported as public to the library's users.
-const __ImpossibleSymbol: unique symbol = Symbol('__Impossible')
-export type __Impossible = typeof __ImpossibleSymbol
+// We re-export, instead of directly importing from the package, for
+// compatibility reasons. Typescript and NodeJS are still in very
+// early stages when it comes to ES modules support.
+export {
+  __BaseType,
+  __Properties,
+  __Brand,
+  __PropertyName,
+  __PropertyValues,
+  type __Impossible
+} from 'https://deno.land/x/nominal_symbols@1.0.2/nominal-symbols/deno/index.ts'

nominal/scripts/adaptDeno.ts

@@ -13,5 +13,9 @@ run()
 
 async function run(): Promise<void> {
   const esmDir = join(__dirname, '..', 'deno')
-  await processDirectory(esmDir, '.ts')
+  await processDirectory(
+    esmDir,
+    '.ts',
+    [['@coderspirit/nominal-symbols', 'https://deno.land/x/nominal_symbols@1.0.2/nominal-symbols/deno/index.ts']]
+  )
 }

nominal/scripts/build_deno.sh

@@ -3,6 +3,5 @@
 mkdir -p ./deno \
 && cp -r ./src/* ./deno/ \
 && rm -rf ./deno/__tests__ \
-&& rm ./deno/internal/Symbols.ts \
-&& mv ./deno/internal/Symbols.ts.esm ./deno/internal/Symbols.ts \
+&& rm ./deno/internal/Symbols.ts.esm \
 && ts-node ./scripts/adaptDeno.ts

nominal/scripts/lib/processFiles.ts

@@ -5,6 +5,7 @@ import { join } from 'path'
 export async function processDirectory(
   directoryPath: string,
   ext: string,
+  exactReplacements: ([string, string])[] = []
 ): Promise<void> {
   const fileNames = await readdir(directoryPath)
 
@@ -13,16 +14,17 @@ export async function processDirectory(
     const fileStats = await lstat(filePath)
 
     if (fileStats.isDirectory()) {
-      await processDirectory(filePath, ext)
+      await processDirectory(filePath, ext, exactReplacements)
     } else {
-      await processFile(filePath, ext)
+      await processFile(filePath, ext, exactReplacements)
     }
   }
 }
 
 export async function processFile(
   filePath: string,
   ext: string,
+  exactReplacements: ([string, string])[] = []
 ): Promise<void> {
   const thePattern = /^(.*}\s+from\s+'\.[A-Za-z0-9_./]+)';?\n?$/s
   const hasExtension = /\.(js|ts|d\.ts)$/s
@@ -42,7 +44,14 @@ export async function processFile(
       transformedLines.push(`${theMatch[1] as string}${ext}';`)
       transformed = true
     } else {
-      transformedLines.push(line)
+      let replaced = line
+      for (const [pattern, replacement] of exactReplacements) {
+        if (replaced.includes(pattern)) {
+          replaced = replaced.replace(pattern, replacement)
+          transformed = true
+        }
+      }
+      transformedLines.push(replaced)
     }
   }
 

nominal/src/internal/Symbols.ts

@@ -1,5 +1,5 @@
 // We re-export, instead of directly importing from the package, for
-// compatibility with ES modules & Deno. Typescript and NodeJS are still in very
+// compatibility reasons. Typescript and NodeJS are still in very
 // early stages when it comes to ES modules support.
 export {
   __BaseType,