Skip to content
This repository was archived by the owner on Dec 27, 2023. It is now read-only.

Commit bb7b4ad

Browse files
committed
Added handling of heartbeat message
1 parent 3267898 commit bb7b4ad

File tree

2 files changed

+17
-7
lines changed

2 files changed

+17
-7
lines changed

src/Handlers/HbMessagesHandler.php

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,22 +3,32 @@
33

44
namespace Litipk\JupyterPHP\Handlers;
55

6-
6+
use Litipk\JupyterPHP\JupyterBroker;
77
use Monolog\Logger;
8-
8+
use React\ZMQ\SocketWrapper;
99

1010
final class HbMessagesHandler
1111
{
1212
/** @var Logger */
1313
private $logger;
1414

15-
public function __construct(Logger $logger)
15+
/** @var SocketWrapper */
16+
private $hbSocket;
17+
18+
public function __construct(SocketWrapper $hbSocket, Logger $logger)
1619
{
1720
$this->logger = $logger;
21+
$this->hbSocket = $hbSocket;
1822
}
1923

2024
public function __invoke($msg)
2125
{
2226
$this->logger->debug('Received message', ['processId' => getmypid(), 'msg' => $msg]);
27+
28+
if (['ping'] == $msg) {
29+
$this->hbSocket->send($msg);
30+
} else {
31+
$this->logger->error('Unknown message', ['processId' => getmypid(), 'msg' => $msg]);
32+
}
2333
}
24-
}
34+
}

src/KernelCore.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ public function __construct(JupyterBroker $jupyterBroker, array $connUris, Logge
6060
{
6161
$this->broker = $jupyterBroker;
6262
$this->logger = $logger;
63-
63+
6464
$this->initSockets($connUris);
6565
$this->registerHandlers();
6666
}
@@ -74,7 +74,7 @@ public function run()
7474
}
7575

7676
/**
77-
* @param array[string]string $connUris
77+
* @param array [string]string $connUris
7878
*/
7979
private function initSockets(array $connUris)
8080
{
@@ -111,7 +111,7 @@ private function registerHandlers()
111111
);
112112
$this->hbSocket->on(
113113
'messages',
114-
new HbMessagesHandler($this->logger->withName('HbMessagesHandler'))
114+
new HbMessagesHandler($this->hbSocket, $this->logger->withName('HbMessagesHandler'))
115115
);
116116
$this->iopubSocket->on(
117117
'messages',

0 commit comments

Comments
 (0)