Skip to content
This repository was archived by the owner on Dec 27, 2023. It is now read-only.

Commit 60d8793

Browse files
committed
Fixed issue #10
1 parent f42054d commit 60d8793

File tree

2 files changed

+18
-7
lines changed

2 files changed

+18
-7
lines changed

src/Handlers/ShellMessagesHandler.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212

1313
use Litipk\JupyterPHP\KernelOutput;
1414
use Monolog\Logger;
15-
use Psy\Configuration;
1615
use Psy\Shell;
1716
use React\ZMQ\SocketWrapper;
1817

@@ -93,6 +92,8 @@ public function __invoke(array $msg)
9392
$this->historyAction->call($header, $content);
9493
} elseif ('shutdown_request' === $header['msg_type']) {
9594
$this->shutdownAction->call($header, $content);
95+
} elseif ('comm_open' === $header['msg_type']) {
96+
// TODO: Research about what should be done.
9697
} else {
9798
$this->logger->error('Unknown message type', ['processId' => getmypid(), 'header' => $header]);
9899
}

src/kernel.php

Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,9 @@
1111
use Litipk\JupyterPHP\System\System;
1212
use Monolog\Handler\FingersCrossed\ErrorLevelActivationStrategy;
1313
use Monolog\Handler\FingersCrossedHandler;
14+
use Monolog\Handler\GroupHandler;
1415
use Monolog\Handler\RotatingFileHandler;
16+
use Monolog\Handler\StreamHandler;
1517
use Monolog\Handler\SyslogHandler;
1618
use Monolog\Logger;
1719
use Ramsey\Uuid\Uuid;
@@ -24,16 +26,24 @@
2426

2527
if ('root' === $system->getCurrentUser()) {
2628
if (System::OS_LINUX === $system->getOperativeSystem()) {
27-
$logger->pushHandler(new FingersCrossedHandler(
28-
new SyslogHandler('jupyter-php'),
29-
$loggerActivationStrategy,
30-
128
31-
));
29+
$logger->pushHandler(
30+
new FingersCrossedHandler(
31+
new GroupHandler([
32+
new SyslogHandler('jupyter-php'),
33+
new StreamHandler('php://stdout')
34+
]),
35+
$loggerActivationStrategy,
36+
128
37+
)
38+
);
3239
}
3340
} else {
3441
$system->ensurePath($system->getAppDataDirectory().'/logs');
3542
$logger->pushHandler(new FingersCrossedHandler(
36-
new RotatingFileHandler($system->getAppDataDirectory().'/logs/error.log', 7),
43+
new GroupHandler([
44+
new RotatingFileHandler($system->getAppDataDirectory().'/logs/error.log', 7),
45+
new StreamHandler('php://stdout')
46+
]),
3747
$loggerActivationStrategy,
3848
128
3949
));

0 commit comments

Comments
 (0)