Skip to content
This repository was archived by the owner on Dec 27, 2023. It is now read-only.

Commit c5c2d16

Browse files
committed
Minor code cleanups
1 parent b813af2 commit c5c2d16

File tree

6 files changed

+68
-3
lines changed

6 files changed

+68
-3
lines changed

src/Console/Application.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,9 @@ public function run(InputInterface $input = null, OutputInterface $output = null
7474

7575
/**
7676
* Runs the application's business logic.
77+
* @param InputInterface $input
78+
* @param OutputInterface $output
79+
* @return int
7780
*/
7881
public function doRun(InputInterface $input, OutputInterface $output)
7982
{

src/Installer/Installer.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ protected function executeComposerCommand($installPath, $beVerbose = false)
8787
passthru(
8888
'PATH=' . getenv('PATH') . ' ' .
8989
$this->composerCmd . ' --prefer-dist --no-interaction --working-dir="' .
90-
$installPath .'" create-project litipk/jupyter-php=dev-master pkgs',
90+
$installPath .'" create-project litipk/jupyter-php=0.* pkgs',
9191

9292
$composerStatus
9393
);

src/Installer/LinuxInstaller.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ protected function installKernel()
4242
'argv' => ['php', $this->getInstallPath().'/pkgs/src/kernel.php', '{connection_file}'],
4343
'display_name' => 'PHP',
4444
'language' => 'php',
45-
'env' => new \Stdclass
45+
'env' => new \stdClass
4646
]);
4747

4848
$currentUser = $this->system->getCurrentUser();

src/Installer/MacInstaller.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ protected function installKernel()
4242
'argv' => ['php', $this->getInstallPath().'/pkgs/src/kernel.php', '{connection_file}'],
4343
'display_name' => 'PHP',
4444
'language' => 'php',
45-
'env' => new \Stdclass
45+
'env' => new \stdClass
4646
]);
4747

4848
$currentUser = $this->system->getCurrentUser();

src/Installer/WindowsInstaller.php

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,29 @@ public function __construct(WindowsSystem $system, $composerCmd)
1818
{
1919
parent::__construct($system, $composerCmd);
2020
}
21+
22+
/**
23+
* @return string
24+
*/
25+
protected function getInstallPath()
26+
{
27+
// TODO: Implement getInstallPath() method.
28+
}
29+
30+
/**
31+
*
32+
*/
33+
protected function installKernel()
34+
{
35+
// TODO: Implement installKernel() method.
36+
}
37+
38+
/**
39+
* @param $installPath
40+
* @return mixed
41+
*/
42+
protected function executeSilentComposerCommand($installPath)
43+
{
44+
// TODO: Implement executeSilentComposerCommand() method.
45+
}
2146
}

src/System/WindowsSystem.php

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,4 +47,41 @@ public function getComposerCommand()
4747
{
4848
return 'composer';
4949
}
50+
51+
/**
52+
* Returns true if the path is a "valid" path and is writable (event if the complete path does not yet exist).
53+
* @param string $path
54+
* @return boolean
55+
*/
56+
public function validatePath($path)
57+
{
58+
// TODO: Implement validatePath() method.
59+
}
60+
61+
/**
62+
* @param string $path
63+
* @return string The "absolute path" version of $path.
64+
*/
65+
public function ensurePath($path)
66+
{
67+
// TODO: Implement ensurePath() method.
68+
}
69+
70+
/**
71+
* @param string $path
72+
* @return boolean
73+
*/
74+
protected function isAbsolutePath($path)
75+
{
76+
// TODO: Implement isAbsolutePath() method.
77+
}
78+
79+
/**
80+
* @param string $path
81+
* @return string
82+
*/
83+
protected function getAbsolutePath($path)
84+
{
85+
// TODO: Implement getAbsolutePath() method.
86+
}
5087
}

0 commit comments

Comments
 (0)