More boring work

Author: castarco

src/Command/InstallCommand.php

@@ -15,6 +15,7 @@ final class InstallCommand extends Command
 {
     const RETURN_CODE_OK = 0;
     const RETURN_CODE_INSTALLER_INSTANTIATION_ERROR = 1;
+    const RETURN_CODE_INSTALLER_INSTALL_ERROR = 2;
 
     protected function configure()
     {
@@ -50,14 +51,20 @@ protected function execute(InputInterface $input, OutputInterface $output)
         $io = $this->getIO();
 
         try {
-            $installer = Installer::getInstaller($composerCmd, $installPath);
+            $installer = Installer::getInstaller($composerCmd);
         } catch (\RuntimeException $e) {
             $io->writeError('ERROR: '.$e->getMessage());
             // TODO : Use verbosity levels to enable showing the stacktrace
             return self::RETURN_CODE_INSTALLER_INSTANTIATION_ERROR;
         }
 
-
+        try {
+            $installer->install($installPath);
+        } catch (\RuntimeException $e) {
+            $io->writeError('ERROR: '.$e->getMessage());
+            // TODO : Use verbosity levels to enable showing the stacktrace
+            return self::RETURN_CODE_INSTALLER_INSTALL_ERROR;
+        }
 
         return self::RETURN_CODE_OK;
     }

src/Installer/Installer.php

@@ -19,10 +19,9 @@ abstract class Installer
 
     /**
      * @param null|string $composerCmd
-     * @param null|string $installPath
      * @return Installer
      */
-    public static function getInstaller($composerCmd = null, $installPath = null)
+    public static function getInstaller($composerCmd = null)
     {
         $system = System::getSystem();
         $composerCmd = (null !== $composerCmd) ? $composerCmd : $system->getComposerCommand();
@@ -31,10 +30,6 @@ public static function getInstaller($composerCmd = null, $installPath = null)
             throw new \RuntimeException('Unable to find the composer executable.');
         }
 
-        if (null !== $installPath && !$system->validatePath($installPath)) {
-            throw new \RuntimeException('Invalid install path.');
-        }
-
         if ($system instanceof UnixSystem) {
             return new LinuxInstaller($system, $composerCmd);
         } elseif ($system instanceof MacSystem) {
@@ -46,6 +41,24 @@ public static function getInstaller($composerCmd = null, $installPath = null)
         }
     }
 
+    /**
+     * @param null|string $installPath
+     */
+    public function install($installPath = null)
+    {
+        $installPath = (null !== $installPath) ? $installPath : $this->getInstallPath();
+        if (null !== $installPath && !$this->system->validatePath($installPath)) {
+            throw new \RuntimeException('Invalid install path.');
+        }
+
+        $this->system->ensurePath($installPath);
+    }
+
+    /**
+     * @return string
+     */
+    public abstract function getInstallPath();
+
     /**
      * Installer constructor.
      * @param System $system

src/Installer/LinuxInstaller.php

@@ -18,4 +18,18 @@ public function __construct(UnixSystem $system, $composerCmd)
     {
         parent::__construct($system, $composerCmd);
     }
+
+    /**
+     * @return string
+     */
+    public function getInstallPath()
+    {
+        $currentUser = $this->system->getCurrentUser();
+
+        if ('root' === $currentUser) {
+            return '/opt/jupyter-php';
+        } else {
+            return $this->system->getCurrentUserHome().'/.jupyter-php';
+        }
+    }
 }

src/System/UnixSystem.php

@@ -114,7 +114,13 @@ public function validatePath($path)
      */
     public function ensurePath($path)
     {
+        $absPath = $this->getAbsolutePath($path);
+
+        if (false === mkdir($this->getAbsolutePath($path), 0744, true)) {
+            throw new \RuntimeException('Unable to create the specified directory ('.$absPath.').');
+        }
 
+        return $absPath;
     }
 
     /**