Improved verbosity handling

Author: castarco

src/Command/InstallCommand.php

@@ -59,13 +59,15 @@ protected function execute(InputInterface $input, OutputInterface $output)
         }
 
         try {
-            $installer->install($installPath);
+            $installer->install($installPath, (bool)$input->getOption('verbose'));
         } catch (\RuntimeException $e) {
             $io->writeError('ERROR: '.$e->getMessage());
             // TODO : Use verbosity levels to enable showing the stacktrace
             return self::RETURN_CODE_INSTALLER_INSTALL_ERROR;
         }
 
+        $io->write('<info>The Jupyter-PHP kernel has been successfully installed.</info>');
+
         return self::RETURN_CODE_OK;
     }
 }

src/Installer/Installer.php

@@ -43,16 +43,17 @@ public static function getInstaller($composerCmd = null)
 
     /**
      * @param null|string $installPath
+     * @param bool $beVerbose
      */
-    public function install($installPath = null)
+    public function install($installPath = null, $beVerbose = false)
     {
         $installPath = (null !== $installPath) ? $installPath : $this->getInstallPath();
         if (null !== $installPath && !$this->system->validatePath($installPath)) {
             throw new \RuntimeException('Invalid install path.');
         }
 
         $this->system->ensurePath($installPath);
-        $this->executeComposerCommand($installPath);
+        $this->executeComposerCommand($installPath, $beVerbose);
 
         $this->installKernel();
     }
@@ -69,17 +70,33 @@ protected abstract function installKernel();
 
     /**
      * @param string $installPath
+     * @param bool $beVerbose
      */
-    protected function executeComposerCommand($installPath)
+    protected function executeComposerCommand($installPath, $beVerbose = false)
     {
         $composerStatus = 0;
 
-        echo "\n";
-        passthru(
-            'PATH='.getenv('PATH').' '.$this->composerCmd.' --working-dir="'.$installPath.'" create-project dawehner/jupyter-php pkgs',
-            $composerStatus
-        );
-        echo "\n";
+        if ($beVerbose) {
+            echo "\n";
+            passthru(
+                'PATH=' . getenv('PATH') . ' ' .
+                $this->composerCmd . ' --prefer-dist --no-interaction --working-dir="' .
+                $installPath .'" create-project litipk/jupyter-php=dev-master pkgs',
+
+                $composerStatus
+            );
+            echo "\n";
+        } else {
+            $composerOutputLines = [];
+            $composerOutput = exec(
+                'PATH=' . getenv('PATH') . ' ' .
+                $this->composerCmd . ' --prefer-dist --no-interaction --no-progress --working-dir="' .
+                $installPath .'" create-project litipk/jupyter-php=dev-master pkgs > /dev/null 2>&1 ',
+
+                $composerOutputLines,
+                $composerStatus
+            );
+        }
 
         if ($composerStatus !== 0) {
             throw new \RuntimeException('Error while trying to download Jupyter-PHP dependencies with Composer.');