Partial work

Author: castarco

src/Command/InstallCommand.php

@@ -13,6 +13,9 @@
 
 final class InstallCommand extends Command
 {
+    const RETURN_CODE_OK = 0;
+    const RETURN_CODE_INSTALLER_INSTANTIATION_ERROR = 1;
+
     protected function configure()
     {
         $this
@@ -44,6 +47,18 @@ protected function execute(InputInterface $input, OutputInterface $output)
         $installPath = ($input->hasArgument('path')) ? $input->getArgument('path') : null;
         $composerCmd = ($input->hasArgument('composer_cmd')) ? $input->getArgument('composer_cmd') : null;
 
-        $installer = Installer::getInstaller($installPath, $composerCmd);
+        $io = $this->getIO();
+
+        try {
+            $installer = Installer::getInstaller($composerCmd, $installPath);
+        } catch (\RuntimeException $e) {
+            $io->writeError('ERROR: '.$e->getMessage());
+            // TODO : Use verbosity levels to enable showing the stacktrace
+            return self::RETURN_CODE_INSTALLER_INSTANTIATION_ERROR;
+        }
+
+
+
+        return self::RETURN_CODE_OK;
     }
 }

src/Installer/Installer.php

@@ -4,17 +4,56 @@
 namespace Litipk\JupyterPhpInstaller\Installer;
 
 
+use Litipk\JupyterPhpInstaller\System\MacSystem;
 use Litipk\JupyterPhpInstaller\System\System;
+use Litipk\JupyterPhpInstaller\System\UnixSystem;
+use Litipk\JupyterPhpInstaller\System\WindowsSystem;
 
 abstract class Installer
 {
+    /** @var  System */
+    protected $system;
+
+    /** @var  string */
+    protected $composerCmd;
+
     /**
-     * @param null|string $installPath
      * @param null|string $composerCmd
+     * @param null|string $installPath
      * @return Installer
      */
-    public static function getInstaller($installPath = null, $composerCmd = null)
+    public static function getInstaller($composerCmd = null, $installPath = null)
     {
         $system = System::getSystem();
+        $composerCmd = (null !== $composerCmd) ? $composerCmd : $system->getComposerCommand();
+
+        if (null === $composerCmd || !$system->checkIfCommandExists($composerCmd)) {
+            throw new \RuntimeException('Unable to find the composer executable.');
+        }
+
+        if (null !== $installPath && !$system->validatePath($installPath)) {
+            throw new \RuntimeException('Invalid install path.');
+        }
+
+        if ($system instanceof UnixSystem) {
+            return new LinuxInstaller($system, $composerCmd);
+        } elseif ($system instanceof MacSystem) {
+            return new MacInstaller($system, $composerCmd);
+        } elseif ($system instanceof WindowsSystem) {
+            return new WindowsInstaller($system, $composerCmd);
+        } else {
+            throw new \RuntimeException('This platform is unknown for the installer');
+        }
+    }
+
+    /**
+     * Installer constructor.
+     * @param System $system
+     * @param string $composerCmd
+     */
+    protected function __construct(System $system, $composerCmd)
+    {
+        $this->system = $system;
+        $this->composerCmd = $composerCmd;
     }
 }

src/Installer/LinuxInstaller.php

@@ -4,7 +4,18 @@
 namespace Litipk\JupyterPhpInstaller\Installer;
 
 
+use Litipk\JupyterPhpInstaller\System\UnixSystem;
+
+
 final class LinuxInstaller extends Installer
 {
-
+    /**
+     * LinuxInstaller constructor.
+     * @param UnixSystem $system
+     * @param string $composerCmd
+     */
+    public function __construct(UnixSystem $system, $composerCmd)
+    {
+        parent::__construct($system, $composerCmd);
+    }
 }

src/Installer/MacInstaller.php

@@ -4,7 +4,18 @@
 namespace Litipk\JupyterPhpInstaller\Installer;
 
 
+use Litipk\JupyterPhpInstaller\System\MacSystem;
+
+
 final class MacInstaller extends Installer
 {
-
+    /**
+     * LinuxInstaller constructor.
+     * @param MacSystem $system
+     * @param string $composerCmd
+     */
+    public function __construct(MacSystem $system, $composerCmd)
+    {
+        parent::__construct($system, $composerCmd);
+    }
 }

src/Installer/WindowsInstaller.php

@@ -4,7 +4,18 @@
 namespace Litipk\JupyterPhpInstaller\Installer;
 
 
+use Litipk\JupyterPhpInstaller\System\WindowsSystem;
+
+
 final class WindowsInstaller extends Installer
 {
-
+    /**
+     * LinuxInstaller constructor.
+     * @param WindowsSystem $system
+     * @param string $composerCmd
+     */
+    public function __construct(WindowsSystem $system, $composerCmd)
+    {
+        parent::__construct($system, $composerCmd);
+    }
 }

src/System/System.php

@@ -46,6 +46,34 @@ public abstract function getCurrentUserHome();
      */
     public abstract function checkIfCommandExists($cmdName);
 
+    /** @return string|null */
+    public abstract function getComposerCommand();
+
+    /**
+     * Returns true if the path is a "valid" path and is writable (event if the complete path does not yet exist).
+     * @param string $path
+     * @return boolean
+     */
+    public abstract function validatePath($path);
+
+    /**
+     * @param string $path
+     * @return string The "absolute path" version of $path.
+     */
+    public abstract function ensurePath($path);
+
+    /**
+     * @param string $path
+     * @return boolean
+     */
+    protected abstract function isAbsolutePath($path);
+
+    /**
+     * @param string $path
+     * @return string
+     */
+    protected abstract function getAbsolutePath($path);
+
     /** @return integer */
     private static function guessOperativeSystem()
     {

src/System/UnixSystem.php

@@ -48,4 +48,59 @@ public function checkIfCommandExists($cmdName)
 
         return filter_var($sysResponse, FILTER_VALIDATE_BOOLEAN, FILTER_NULL_ON_FAILURE);
     }
+
+    /** @return string|null */
+    public function getComposerCommand()
+    {
+        $potentialCommands = [
+            'composer', 'composer.phar', './composer.phar', './composer', './bin/composer', './bin/composer.phar',
+            './vendor/bin/composer', './vendor/bin/composer.phar', '../vendor/bin/composer',
+            '../vendor/bin/composer.phar', '../../vendor/bin/composer', '../../vendor/bin/composer.phar'
+        ];
+
+        foreach ($potentialCommands as $potentialCommand) {
+            if ($this->checkIfCommandExists($potentialCommand)) {
+                return $potentialCommand;
+            }
+        }
+
+        return null;
+    }
+
+    /**
+     * Returns true if the path is a "valid" path and is writable (event if the complete path does not yet exist).
+     * @param string $path
+     * @return boolean
+     */
+    public function validatePath($path)
+    {
+        $absPath = $this->getAbsolutePath($path);
+    }
+
+    /**
+     * @param string $path
+     * @return string The "absolute path" version of $path.
+     */
+    public function ensurePath($path)
+    {
+
+    }
+
+    /**
+     * @param string $path
+     * @return bool
+     */
+    protected function isAbsolutePath($path)
+    {
+        return (1 === preg_match('#^/#', $path));
+    }
+
+    /**
+     * @param string $path
+     * @return string
+     */
+    protected function getAbsolutePath($path)
+    {
+        return $this->isAbsolutePath($path) ? $path : (getcwd() . DIRECTORY_SEPARATOR . $path);
+    }
 }

src/System/WindowsSystem.php

@@ -41,4 +41,10 @@ public function checkIfCommandExists($cmdName)
     {
         return true;
     }
+
+    /** @return string */
+    public function getComposerCommand()
+    {
+        return 'composer';
+    }
 }