Add PHPStan and PHP Code Sniffer

Author: TavoNiievez

.github/workflows/main.yml

@@ -11,20 +11,27 @@ jobs:
         php: [8.2, 8.3, 8.4]
 
     steps:
-    - name: Checkout code
-      uses: actions/checkout@v4
+      - name: Checkout code
+        uses: actions/checkout@v4
 
-    - name: Setup PHP
-      uses: shivammathur/setup-php@v2
-      with:
-        php-version: ${{ matrix.php }}
-        coverage: none
+      - name: Setup PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: ${{ matrix.php }}
+          coverage: none
+          tools: phpstan, phpcs
 
-    - name: Validate composer.json and composer.lock
-      run: composer validate
+      - name: Validate composer.json and composer.lock
+        run: composer validate
 
-    - name: Install dependencies
-      run: composer install --prefer-dist --no-progress --no-interaction --no-suggest
+      - name: Install dependencies
+        run: composer install --prefer-dist --no-progress --no-interaction --no-suggest
 
-    - name: Run test suite
-      run: php vendor/bin/codecept run
+      - name: Run PHPStan
+        run: phpstan analyse src
+
+      - name: Run PHPCS
+        run: phpcs --standard=PSR12 src
+
+      - name: Run test suite
+        run: php vendor/bin/codecept run

src/Codeception/Module/AbstractAsserts.php

@@ -147,4 +147,4 @@ abstract class AbstractAsserts extends Module
         markTestIncomplete as public;
         markTestSkipped as public;
     }
-}
+}

src/Codeception/Module/Asserts.php

@@ -5,6 +5,7 @@
 namespace Codeception\Module;
 
 use Throwable;
+
 use function get_debug_type;
 
 /**
@@ -26,6 +27,7 @@ class Asserts extends AbstractAsserts
      *     $this->doSomethingBad();
      * });
      * ```
+     *
      * If you want to check message or throwable code, you can pass them with throwable instance:
      * ```php
      * <?php
@@ -40,7 +42,7 @@ public function expectThrowable(string|Throwable $throwable, callable $callback)
         if (is_object($throwable)) {
             $class = get_class($throwable);
             $msg = $throwable->getMessage();
-            $code = $throwable->getCode();
+            $code = (int) $throwable->getCode();
         } else {
             $class = $throwable;
             $msg = null;
@@ -61,8 +63,12 @@ public function expectThrowable(string|Throwable $throwable, callable $callback)
      * Check if the given throwable matches the expected data,
      * fail (throws an exception) if it does not.
      */
-    protected function checkThrowable(Throwable $throwable, string $expectedClass, ?string $expectedMsg, int|null $expectedCode = null): void
-    {
+    protected function checkThrowable(
+        Throwable $throwable,
+        string $expectedClass,
+        ?string $expectedMsg,
+        int|null $expectedCode = null
+    ): void {
         if (!($throwable instanceof $expectedClass)) {
             $this->fail(sprintf(
                 "Exception of class '%s' expected to be thrown, but class '%s' was caught",