Skip to content

Commit cdda345

Browse files
committed
🐛 (slider)-fix selection bug on disabled slider
1 parent 6705002 commit cdda345

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

lib/slider/index.js

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -133,9 +133,12 @@ class Slider extends React.Component {
133133

134134
startDrag = (ev, left) => {
135135
ev.preventDefault();
136-
const dragEventWithData = e => this.dragEvent(e, left);
137-
document.body.addEventListener('mouseup', () => this.stopDrag(dragEventWithData));
138-
document.body.addEventListener('mousemove', dragEventWithData);
136+
const { disabled } = this.props;
137+
if (!disabled) {
138+
const dragEventWithData = e => this.dragEvent(e, left);
139+
document.body.addEventListener('mouseup', () => this.stopDrag(dragEventWithData));
140+
document.body.addEventListener('mousemove', dragEventWithData);
141+
}
139142
};
140143

141144
stopDrag = (eventCallback) => {
@@ -168,16 +171,16 @@ class Slider extends React.Component {
168171
const leftButtonProps = {
169172
className: theme['slider-button'],
170173
'aria-label': 'slider-button-left',
171-
onMouseDown: !disabled ? (e) => {
174+
onMouseDown: (e) => {
172175
this.startDrag(e, true);
173-
} : undefined,
176+
},
174177
};
175178
const rightButtonProps = {
176179
className: theme['slider-button'],
177180
'aria-label': 'slider-button-right',
178-
onMouseDown: !disabled ? (e) => {
181+
onMouseDown: (e) => {
179182
this.startDrag(e, false);
180-
} : undefined,
183+
},
181184
};
182185
return (
183186
<div {...rootProps}>

0 commit comments

Comments
 (0)