Merge pull request #244 from Codebrahma/slider

🐛  (slider)-bug fixes

Author: rishichawda

lib/slider/index.js

@@ -131,10 +131,14 @@ class Slider extends React.Component {
     }
   };
 
-  startDrag = (_, left) => {
-    const dragEventWithData = e => this.dragEvent(e, left);
-    document.body.addEventListener('mouseup', () => this.stopDrag(dragEventWithData));
-    document.body.addEventListener('mousemove', dragEventWithData);
+  startDrag = (ev, left) => {
+    ev.preventDefault();
+    const { disabled } = this.props;
+    if (!disabled) {
+      const dragEventWithData = e => this.dragEvent(e, left);
+      document.body.addEventListener('mouseup', () => this.stopDrag(dragEventWithData));
+      document.body.addEventListener('mousemove', dragEventWithData);
+    }
   };
 
   stopDrag = (eventCallback) => {
@@ -167,16 +171,16 @@ class Slider extends React.Component {
     const leftButtonProps = {
       className: theme['slider-button'],
       'aria-label': 'slider-button-left',
-      onMouseDown: !disabled ? (e) => {
+      onMouseDown: (e) => {
         this.startDrag(e, true);
-      } : undefined,
+      },
     };
     const rightButtonProps = {
       className: theme['slider-button'],
       'aria-label': 'slider-button-right',
-      onMouseDown: !disabled ? (e) => {
+      onMouseDown: (e) => {
         this.startDrag(e, false);
-      } : undefined,
+      },
     };
     return (
       <div {...rootProps}>

lib/slider/tests/accessibility.test.js

@@ -0,0 +1,21 @@
+import React from 'react';
+import { mount } from 'enzyme';
+import { expect } from 'chai';
+import Slider from '..';
+
+/* eslint-disable no-undef */
+describe('Slider Accessibility tests tests', () => {
+  let wrappedComponent;
+
+  // beforeEach(() => {
+  // });
+
+  afterEach(() => {
+    wrappedComponent.unmount();
+  });
+
+  it('Is disabled when disabled prop is passed', () => {
+    wrappedComponent = mount(<Slider disabled />);
+    expect(wrappedComponent.props().disabled).equals(true);
+  });
+});