This repository was archived by the owner on Oct 26, 2020. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 453
Orhan-week-7 #990
Open
OBakir90
wants to merge
1
commit into
CodeYourFuture:manchester3
Choose a base branch
from
OBakir90:Orhan-week-7
base: manchester3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Orhan-week-7 #990
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
143 changes: 55 additions & 88 deletions
143
week-7/Homework/mandatory/1-debugging-practice/index.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,96 +1,63 @@ | ||
<!DOCTYPE html> | ||
<html> | ||
<head> | ||
<title> </title> | ||
<meta | ||
charset="utf-8" | ||
name="viewport" | ||
content="width=device-width, initial-scale=1.0" | ||
/> | ||
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script> | ||
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script> | ||
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script> | ||
<link | ||
rel="stylesheet" | ||
href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css" | ||
/> | ||
<link rel="stylesheet" type="text/css" href="style.css" /> | ||
</head> | ||
|
||
<body> | ||
<div class="jumbotron text-center"> | ||
<h1>Library</h1> | ||
<p>Add books to your virtual library</p> | ||
</div> | ||
<head> | ||
<title> </title> | ||
<meta charset="utf-8" name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script> | ||
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script> | ||
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script> | ||
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css" /> | ||
<link rel="stylesheet" type="text/css" href="style.css" /> | ||
</head> | ||
|
||
<body> | ||
<div class="jumbotron text-center"> | ||
<h1>Library</h1> | ||
<p>Add books to your virtual library</p> | ||
</div> | ||
|
||
<button data-toggle="collapse" data-target="#demo" class="btn btn-info"> | ||
Add new book | ||
</button> | ||
<button data-toggle="collapse" data-target="#demo" class="btn btn-info"> | ||
Add new book | ||
</button> | ||
|
||
<div id="demo" class="collapse"> | ||
<div class="form-group"> | ||
<label for="title">Title:</label> | ||
<input | ||
type="title" | ||
class="form-control" | ||
id="title" | ||
name="title" | ||
required | ||
/> | ||
<label for="author">Author: </label> | ||
<input | ||
type="author" | ||
class="form-control" | ||
id="author" | ||
name="author" | ||
required | ||
/> | ||
<label for="pages">Pages:</label> | ||
<input | ||
type="number" | ||
class="form-control" | ||
id="pages" | ||
name="pages" | ||
required | ||
/> | ||
<label class="form-check-label"> | ||
<input | ||
type="checkbox" | ||
class="form-check-input" | ||
id="check" | ||
value="" | ||
/>Read | ||
</label> | ||
<input | ||
type="submit" | ||
value="Submit" | ||
class="btn btn-primary" | ||
onclick="submit();" | ||
/> | ||
</div> | ||
<div id="demo" class="collapse"> | ||
<div class="form-group"> | ||
<label for="title">Title:</label> | ||
<input type="title" class="form-control" id="title" name="title" required /> | ||
<label for="author">Author: </label> | ||
<input type="author" class="form-control" id="author" name="author" required /> | ||
<label for="pages">Pages:</label> | ||
<input type="number" class="form-control" id="pages" name="pages" required /> | ||
<label class="form-check-label"> | ||
<input type="checkbox" class="form-check-input" id="check" value="" />Read | ||
</label> | ||
<input type="submit" value="Submit" class="btn btn-primary" onclick="submit();" /> | ||
</div> | ||
</div> | ||
|
||
<table class="table" id="display"> | ||
<thead class="thead-dark"> | ||
<tr> | ||
<th>Title</th> | ||
<th>Author</th> | ||
<th>Number of Pages</th> | ||
<th>Read</th> | ||
<th></th> | ||
</tr> | ||
</thead> | ||
<tbody> | ||
<tr> | ||
<td></td> | ||
<td></td> | ||
<td></td> | ||
<td></td> | ||
<td></td> | ||
</tr> | ||
</tbody> | ||
</table> | ||
|
||
<table class="table" id="display"> | ||
<thead class="thead-dark"> | ||
<tr> | ||
<th>Title</th> | ||
<th>Author</th> | ||
<th>Number of Pages</th> | ||
<th>Read</th> | ||
<th></th> | ||
</tr> | ||
</thead> | ||
<tbody> | ||
<tr> | ||
<td></td> | ||
<td></td> | ||
<td></td> | ||
<td></td> | ||
<td></td> | ||
</tr> | ||
</tbody> | ||
</table> | ||
<script src="script.js"></script> | ||
</body> | ||
|
||
<script src="script.js"></script> | ||
</body> | ||
</html> | ||
</html> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,6 +29,8 @@ const check = document.getElementById("check"); | |
//via Book function and start render function | ||
function submit() { | ||
if ( | ||
author.value == null || | ||
author.value == "" || | ||
title.value == null || | ||
title.value == "" || | ||
pages.value == null || | ||
|
@@ -37,8 +39,8 @@ function submit() { | |
alert("Please fill all fields!"); | ||
return false; | ||
} else { | ||
let book = new Book(title.value, title.value, pages.value, check.checked); | ||
library.push(book); | ||
let book = new Book(title.value, author.value, pages.value, check.checked); | ||
myLibrary.push(book); | ||
render(); | ||
} | ||
} | ||
|
@@ -54,7 +56,7 @@ function render() { | |
let table = document.getElementById("display"); | ||
let rowsNumber = table.rows.length; | ||
//delete old table | ||
for (let n = rowsNumber - 1; n > 0; n-- { | ||
for (let n = rowsNumber - 1; n > 0; n--) { | ||
table.deleteRow(n); | ||
} | ||
//insert updated row and cells | ||
|
@@ -76,7 +78,7 @@ function render() { | |
changeBut.className = "btn btn-success"; | ||
cell4.appendChild(changeBut); | ||
let readStatus = ""; | ||
if (myLibrary[i].check == false) { | ||
if (myLibrary[i].check == true) { | ||
readStatus = "Yes"; | ||
} else { | ||
readStatus = "No"; | ||
|
@@ -89,12 +91,12 @@ function render() { | |
}); | ||
|
||
//add delete button to every row and render again | ||
let delButton = document.createElement("button"); | ||
let delBut = document.createElement("button"); | ||
delBut.id = i + 5; | ||
cell5.appendChild(delBut); | ||
delBut.className = "btn btn-warning"; | ||
delBut.innerHTML = "Delete"; | ||
delBut.addEventListener("clicks", function () { | ||
delBut.addEventListener("click", function () { | ||
alert(`You've deleted title: ${myLibrary[i].title}`); | ||
myLibrary.splice(i, 1); | ||
render(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Perfect work again ! |
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect answers