Misc tweaks to sprint 2 (#48)

* Add package-lock.json

* Misc copy edits and typo fixes

* Add extension to in-sprint querystring parsing

Author: illicitonion

Sprint-2/implement/contains.test.js

@@ -4,10 +4,10 @@ const contains = require("./contains.js");
 Implement a function called contains that checks an object contains a
 particular property
 
-E.g. contains({ a : 1, b: 2 },'a') // returns true
+E.g. contains({a: 1, b: 2}, 'a') // returns true
 as the object contains a key of 'a'
 
-E.g. contains({a : 1, b : 2},'c') // returns false
+E.g. contains({a: 1, b: 2}, 'c') // returns false
 as the object doesn't contains a key of 'c'
 */
 
@@ -20,6 +20,7 @@ as the object doesn't contains a key of 'c'
 // Given an empty object
 // When passed to contains
 // Then it should return false
+test.todo("contains on empty object returns false");
 
 // Given an object with properties
 // When passed to contains with an existing property name
@@ -29,6 +30,6 @@ as the object doesn't contains a key of 'c'
 // When passed to contains with a non-existent property name
 // Then it should return false
 
-// Given invalid parameters like arrays
+// Given invalid parameters like an array
 // When passed to contains
 // Then it should return false or throw an error

Sprint-2/implement/lookup.js

@@ -1,3 +1,5 @@
 function createLookup() {
   // implementation here
 }
+
+module.exports = createLookup;

Sprint-2/implement/lookup.test.js

@@ -1,13 +1,4 @@
-// ======= Test suite is provided below... =======
-
-test("converts a single pair of currency codes", () => {
-  expect(createLookup([["GB", "GBP"]])).toEqual({
-    GB: "GBP",
-  });
-  expect(createLookup([["DE", "EUR"]])).toEqual({
-    DE: "EUR",
-  });
-});
+const createLookup = require("./lookup.js");
 
 test.todo("creates a country currency code lookup for multiple codes");
 

Sprint-2/implement/querystring.js

@@ -0,0 +1,16 @@
+function parseQueryString(queryString) {
+  const queryParams = {};
+  if (queryString.length === 0) {
+    return queryParams;
+  }
+  const keyValuePairs = queryString.split("&");
+
+  for (const pair of keyValuePairs) {
+    const [key, value] = pair.split("=");
+    queryParams[key] = value;
+  }
+
+  return queryParams;
+}
+
+module.exports = parseQueryString;

Sprint-2/implement/querystring.test.js

@@ -0,0 +1,12 @@
+// In the prep, we implemented a function to parse query strings.
+// Unfortunately, it contains several bugs!
+// Below is one test case for an edge case the implementation doesn't handle well.
+// Fix the implementation for this test, and try to think of as many other edge cases as possible - write tests and fix those too.
+
+const parseQueryString = require("./querystring.js")
+
+test("parses querystring values containing =", () => {
+  expect(parseQueryString("equation=x=y+1")).toEqual({
+    "equation": "x=y+1",
+  });
+});

Sprint-2/implement/tally.js

@@ -0,0 +1,3 @@
+function tally() {}
+
+module.exports = tally;

Sprint-2/implement/tally.test.js

@@ -1,3 +1,5 @@
+const tally = require("./tally.js");
+
 /**
  * tally array
  *
@@ -8,8 +10,8 @@
  * For example:
  *
  * tally(['a']), target output: { a: 1 }
- * tally(['a','a','a']), target output: { a: 3 }
- * tally(['a','a','b','c']), target output: { a : 2, b: 1, c: 1 }
+ * tally(['a', 'a', 'a']), target output: { a: 3 }
+ * tally(['a', 'a', 'b', 'c']), target output: { a : 2, b: 1, c: 1 }
  */
 
 // Acceptance criteria:
@@ -21,6 +23,7 @@
 // Given an empty array
 // When passed to tally
 // Then it should return an empty object
+test.todo("tally on an empty array returns an empty object");
 
 // Given an array with duplicate items
 // When passed to tally

Sprint-2/interpret/invert.js

@@ -25,3 +25,5 @@ function invert(obj) {
 // c) What does Object.entries return? Why is it needed in this program?
 
 // d) Explain why the current return value is different from the target output
+
+// e) Fix the implementation of invert (and write tests to prove it's fixed!)