Skip to content

🐞 Git's Discard All Changes Not Correct #1786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
thecoolwinter opened this issue Jul 2, 2024 · 1 comment
Open

🐞 Git's Discard All Changes Not Correct #1786

thecoolwinter opened this issue Jul 2, 2024 · 1 comment
Labels
bug Something isn't working source control

Comments

@thecoolwinter
Copy link
Collaborator

thecoolwinter commented Jul 2, 2024 •
edited
Loading

Description

The "Discard All Changes" functionality isn't quite correct. Right now it just runs git restore . which doesn't handle cases. We can make this feature even better by moving modified and added files to the trash similar to GH Desktop. See their implementation doc here for more details on how this should be handled.

To Reproduce

.

Expected Behavior

CodeEdit's discard changes successfully discards all changes, whether they're unstaged, staged, added, modified, or removed files.

Version Information

CodeEdit: 0.1.0

Additional Context

No response

Screenshots

No response
@thecoolwinter thecoolwinter added the bug Something isn't working label Jul 2, 2024
@thecoolwinter thecoolwinter moved this from 🆕 New to 📋 Todo in CodeEdit Project Jul 2, 2024
@dmythro
Copy link

dmythro commented Dec 31, 2024

There's more: after Discard already open files aren't changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working source control
Projects
CodeEdit Project
Status: 📋 Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmythro @thecoolwinter