FIX: Git History Date bug (#1585)

* Bug fixes

- Correct date isn't displayed in this history tab

- Branch image was slightly to big, compared to Xcode

- Branch menu color was a bit off

- Branch menu indicator wasn't hidden

* Update GitClient+CommitHistory.swift

* Linter

Author: tom-ludwig

CodeEdit/Features/CodeEditUI/Views/ToolbarBranchPicker.swift

@@ -35,8 +35,8 @@ struct ToolbarBranchPicker: View {
             if currentBranch != nil {
                 Image.branch
                     .font(.title3)
-                    .imageScale(.large)
-                    .foregroundColor(controlActive == .inactive ? inactiveColor : .primary)
+                    .imageScale(.medium)
+                    .foregroundColor(controlActive == .inactive ? inactiveColor : .gray)
             } else {
                 Image(systemName: "folder.fill.badge.gearshape")
                     .font(.title3)
@@ -57,9 +57,10 @@ struct ToolbarBranchPicker: View {
                     }, label: {
                         Text(currentBranch.name)
                             .font(.subheadline)
-                            .foregroundColor(controlActive == .inactive ? inactiveColor : .secondary)
+                            .foregroundColor(controlActive == .inactive ? inactiveColor : .gray)
                             .frame(height: 11)
                     })
+                    .menuIndicator(isHovering ? .visible : .hidden)
                     .buttonStyle(.borderless)
                     .padding(.leading, -3)
                 }

CodeEdit/Features/Git/Client/GitClient+CommitHistory.swift

@@ -25,8 +25,11 @@ extension GitClient {
         if let branchName { branchNameString = "--first-parent \(branchName)" }
         if let maxCount { maxCountString = "-n \(maxCount)" }
         let dateFormatter = DateFormatter()
-        dateFormatter.locale = Locale.current
+
+        // Can't use `Locale.current`, since it'd give a nil date outside the US
+        dateFormatter.locale = Locale(identifier: Locale.current.identifier)
         dateFormatter.dateFormat = "EEE, dd MMM yyyy HH:mm:ss Z"
+
         let output = try await run(
             "log --pretty=%h¦%H¦%s¦%aN¦%ae¦%cn¦%ce¦%aD¦ \(maxCountString) \(branchNameString) \(fileLocalPath)"
                 .trimmingCharacters(in: .whitespacesAndNewlines)

CodeEdit/Features/NavigatorArea/SourceControlNavigator/Views/SourceControlNavigatorView.swift

@@ -13,7 +13,7 @@ struct SourceControlNavigatorView: View {
     var body: some View {
         if let sourceControlManager = workspace.workspaceFileManager?.sourceControlManager {
             VStack(spacing: 0) {
-                SourcControlNavigatorTabs()
+                SourceControlNavigatorTabs()
                     .environmentObject(sourceControlManager)
                     .task {
                         do {
@@ -34,7 +34,7 @@ struct SourceControlNavigatorView: View {
     }
 }
 
-struct SourcControlNavigatorTabs: View {
+struct SourceControlNavigatorTabs: View {
     @EnvironmentObject var sourceControlManager: SourceControlManager
     @State private var selectedSection: Int = 0