Skip to content

Commit c6e3573

Browse files
committed
Removed redundant Task creation
1 parent b80b51a commit c6e3573

File tree

1 file changed

+10
-13
lines changed

1 file changed

+10
-13
lines changed

DeadLock/Forms/FrmMain.cs

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -186,10 +186,7 @@ private async void Update(bool showError, bool showNoUpdates)
186186
{
187187
if (MessageBoxAdv.Show(l.MsgVersion + " " + _update.GetUpdateVersion() + " " + l.MsgAvailable + Environment.NewLine + l.MsgDownloadNewVersion, "DeadLock", MessageBoxButtons.YesNo, MessageBoxIcon.Question) == DialogResult.Yes)
188188
{
189-
await Task.Run(() =>
190-
{
191-
new FrmUpdater(_update, _languageManager.GetLanguage()).ShowDialog();
192-
});
189+
new FrmUpdater(_update, _languageManager.GetLanguage()).Show();
193190
}
194191
}
195192
else
@@ -527,7 +524,7 @@ private async void moveToolStripMenuItem_Click(object sender, EventArgs e)
527524
{
528525
if (lsvItems.SelectedItems.Count == 0) return;
529526

530-
ListViewLocker lvl = (ListViewLocker) lsvItems.SelectedItems[0];
527+
ListViewLocker lvl = (ListViewLocker)lsvItems.SelectedItems[0];
531528
Language l = _languageManager.GetLanguage();
532529

533530
CancelSelectedTask(lvl);
@@ -569,7 +566,7 @@ private async void removeToolStripMenuItem_Click(object sender, EventArgs e)
569566
{
570567
if (lsvItems.SelectedItems.Count == 0) return;
571568

572-
ListViewLocker lvl = (ListViewLocker) lsvItems.SelectedItems[0];
569+
ListViewLocker lvl = (ListViewLocker)lsvItems.SelectedItems[0];
573570
Language l = _languageManager.GetLanguage();
574571

575572
CancelSelectedTask(lvl);
@@ -624,15 +621,15 @@ private async void lsvItems_DoubleClick(object sender, EventArgs e)
624621
if (lsvItems.SelectedItems.Count == 0) return;
625622
lsvDetails.Items.Clear();
626623

627-
ListViewLocker lvl = (ListViewLocker) lsvItems.SelectedItems[0];
624+
ListViewLocker lvl = (ListViewLocker)lsvItems.SelectedItems[0];
628625
Language l = _languageManager.GetLanguage();
629626

630627
try
631628
{
632629
CancelSelectedTask(lvl);
633630
await Task.Run(() =>
634631
{
635-
while (lvl.IsRunning()){ }
632+
while (lvl.IsRunning()) { }
636633
});
637634
lvl.SetLocker(new List<ProcessLocker>());
638635

@@ -648,7 +645,7 @@ await Task.Run(() =>
648645

649646
lvl.SetRunning(true);
650647
List<ProcessLocker> lockers = await lvl.GetLockerDetails();
651-
648+
652649
if (!lvl.HasCancelled())
653650
{
654651
if (lockers.Count == 0)
@@ -665,7 +662,7 @@ await Task.Run(() =>
665662

666663
foreach (ProcessLocker p in lockers)
667664
{
668-
ListViewItem lvi = new ListViewItem {Text = p.GetFileName()};
665+
ListViewItem lvi = new ListViewItem { Text = p.GetFileName() };
669666
lvi.SubItems.Add(p.GetFilePath());
670667
lvi.SubItems.Add(p.GetProcessId().ToString());
671668

@@ -697,7 +694,7 @@ private void lsvItems_SelectedIndexChanged(object sender, EventArgs e)
697694
lsvDetails.Items.Clear();
698695
if (lsvItems.SelectedItems.Count == 0) return;
699696

700-
ListViewLocker lvl = (ListViewLocker) lsvItems.SelectedItems[0];
697+
ListViewLocker lvl = (ListViewLocker)lsvItems.SelectedItems[0];
701698
foreach (ProcessLocker p in lvl.GetLockers())
702699
{
703700
ListViewItem lvi = new ListViewItem { Text = p.GetFileName() };
@@ -711,7 +708,7 @@ private void clearItemsToolStripMenuItem_Click(object sender, EventArgs e)
711708
{
712709
foreach (ListViewItem lvi in lsvItems.Items)
713710
{
714-
ListViewLocker lvl = (ListViewLocker) lvi;
711+
ListViewLocker lvl = (ListViewLocker)lvi;
715712
lvl.CancelTask();
716713
}
717714
lsvItems.Items.Clear();
@@ -774,7 +771,7 @@ private void cancelCurrentOperationToolStripMenuItem_Click(object sender, EventA
774771
{
775772
if (lsvItems.SelectedItems.Count == 0) return;
776773

777-
ListViewLocker selected = (ListViewLocker) lsvItems.SelectedItems[0];
774+
ListViewLocker selected = (ListViewLocker)lsvItems.SelectedItems[0];
778775
if (CancelSelectedTask(selected))
779776
{
780777
SetCancelled(selected);

0 commit comments

Comments
 (0)