#170 Test inner range null reference exception. (#173)

* Test inner range null reference exception.

* #169 Test inner range null reference exception

Co-authored-by: Tsar Nikolay <nsmirnov@ics.perm.ru>

Author: b0bi79

ClosedXML.Report/Excel/TempSheetBuffer.cs

@@ -46,7 +46,11 @@ private void Init()
         public IXLCell WriteValue(object value, IXLCell settingCell)
         {
             var xlCell = _sheet.Cell(_row, _clmn);
-            xlCell.CopyFrom(settingCell);
+            if (settingCell != null)
+            {
+                xlCell.CopyFrom(settingCell);
+            }
+
             try
             {
                 xlCell.SetValue(value);

ClosedXML.Report/RangeTemplate.cs

@@ -239,6 +239,12 @@ private void VerticalTable(object[] items, FormulaEvaluator evaluator)
 
         private void RenderCell(FormulaEvaluator evaluator, TemplateCell cell, params Parameter[] pars)
         {
+            if (cell.CellType != TemplateCellType.Formula && cell.CellType != TemplateCellType.Value)
+            {
+                _buff.WriteValue(null, null);
+                return;
+            }
+
             object value;
             try
             {
@@ -363,7 +369,9 @@ private void HorizontalTable(object[] items, FormulaEvaluator evaluator)
                 var clmnStart = _buff.NextAddress;
                 foreach (var cell in _cells)
                 {
-                    if (cell.CellType != TemplateCellType.NewRow)
+                    if (cell.CellType == TemplateCellType.None)
+                        throw new NotSupportedException("Horizontal range does not support subranges.");
+                    else if (cell.CellType != TemplateCellType.NewRow)
                         RenderCell(items, i, evaluator, cell);
                     else
                         _buff.NewRow();

tests/ClosedXML.Report.Tests/TempSheetBufferTests.cs

@@ -45,5 +45,36 @@ public void CanRenderRangeForEmptySet()
                 ws.Cell("B4").Value.Should().Be("");
             }
         }
+
+        [Fact]
+        public void InnerRange()
+        {
+            using (var wb = new XLWorkbook())
+            {
+                // Arrange.
+                const string rangeName = "List";
+                const string innerRangeName = "CustomTotals";
+                const string totalsName = "Totals";
+                var list = new List<string> { "Value1", "Value2" };
+                var ws = wb.AddWorksheet("Sheet1");
+                ws.Cell("B1").Value = "Header";
+                ws.Range("A2:C3").AddToNamed(rangeName);
+                ws.Cell("B2").Value = "{{index+1}}";
+                ws.Cell("C2").Value = "{{item}}";
+                ws.Cell("B3").Value = totalsName;
+                ws.Range("C3:C3").AddToNamed(innerRangeName);
+
+                // Act.
+                var template = new XLTemplate(wb);
+                template.AddVariable(rangeName, list);
+                template.AddVariable(innerRangeName, list.Count);
+                template.Generate();
+
+                // Assert.
+                ws.Cell("B4").Value.Should().Be(totalsName);
+                ws.Range(rangeName).RowCount().Should().Be(3);
+                ws.Range(rangeName).ColumnCount().Should().Be(3);
+            }
+        }
     }
 }