Skip to content

Commit f0f3434

Browse files
authored
Merge pull request #122 from zhicwu/fix-compatibility-issue
Fix compatibility issue
2 parents 0daf7bc + 80d7443 commit f0f3434

File tree

2 files changed

+15
-7
lines changed

2 files changed

+15
-7
lines changed

pom.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,16 @@
55
<groupId>ru.yandex.clickhouse</groupId>
66
<artifactId>clickhouse-jdbc-bridge</artifactId>
77
<packaging>jar</packaging>
8-
<version>2.0.4-SNAPSHOT</version>
8+
<version>2.0.6-SNAPSHOT</version>
99
<name>ClickHouse JDBC Bridge</name>
1010
<url>https://github.com/ClickHouse/clickhouse-jdbc-bridge</url>
1111
<description>JDBC bridge for ClickHouse.</description>
1212
<inceptionYear>2019</inceptionYear>
1313

1414
<properties>
1515
<caffeine.version>2.9.2</caffeine.version>
16-
<dnsjava.version>3.4.1</dnsjava.version>
17-
<vertx.version>3.9.8</vertx.version>
16+
<dnsjava.version>3.4.2</dnsjava.version>
17+
<vertx.version>3.9.9</vertx.version>
1818
<micrometer.version>1.1.19</micrometer.version>
1919
<slf4j.version>1.7.32</slf4j.version>
2020
<hikaricp.version>3.4.5</hikaricp.version>

src/main/java/ru/yandex/clickhouse/jdbcbridge/core/QueryParser.java

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,8 @@ public class QueryParser {
3838
// Otherwise NULLs will be substituted with default values.
3939
// Currently supported only for 'mysql' table function.
4040
private static final String PARAM_EXT_TABLE_USE_NULLS = "external_table_functions_use_nulls";
41-
private static final String PARAM_COLUMNS = "sample_block";
41+
private static final String PARAM_COLUMNS = "columns";
42+
private static final String PARAM_SAMPLE_BLOCK = "sample_block";
4243
private static final String PARAM_QUERY = "query";
4344
private static final String PARAM_DB_NAME = "db_name";
4445
private static final String PARAM_TABLE_NAME = "table_name";
@@ -260,8 +261,12 @@ public static QueryParser fromRequest(RoutingContext ctx, Repository<NamedDataSo
260261

261262
String uri = Objects.requireNonNull(resolver).resolve(req.getParam(PARAM_CONNECTION_STRING));
262263
if (forWrite) {
263-
query = new QueryParser(uri, req.getParam(PARAM_DB_NAME), req.getParam(PARAM_TABLE_NAME),
264-
req.getParam(PARAM_COLUMNS), req.getParam(PARAM_FORMAT_NAME), null, null);
264+
String columns = req.getParam(PARAM_SAMPLE_BLOCK);
265+
if (columns == null) {
266+
columns = req.getParam(PARAM_COLUMNS);
267+
}
268+
query = new QueryParser(uri, req.getParam(PARAM_DB_NAME), req.getParam(PARAM_TABLE_NAME), columns,
269+
req.getParam(PARAM_FORMAT_NAME), null, null);
265270
} else {
266271
String schema = req.getParam(PARAM_SCHEMA);
267272
String table = req.getParam(PARAM_TABLE);
@@ -287,7 +292,10 @@ public static QueryParser fromRequest(RoutingContext ctx, Repository<NamedDataSo
287292
}
288293

289294
if (columns == null) {
290-
columns = req.getParam(PARAM_COLUMNS);
295+
columns = req.getParam(PARAM_SAMPLE_BLOCK);
296+
if (columns == null) {
297+
columns = req.getParam(PARAM_COLUMNS);
298+
}
291299
}
292300

293301
if (schema == null) {

0 commit comments

Comments
 (0)