From 021887bb0c14accad2cc797c293dc51a01c364d4 Mon Sep 17 00:00:00 2001 From: Shaun Struwig <41984034+Blargian@users.noreply.github.com> Date: Tue, 8 Apr 2025 10:53:50 +0200 Subject: [PATCH 1/8] update docs check --- .github/workflows/pull-request.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index 22608a72f37..7a822149046 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -43,9 +43,8 @@ jobs: - name: Docs Check run: | cp -r "$GITHUB_WORKSPACE/ClickHouse" "$TEMP_PATH" - cd "$REPO_COPY/tests/ci" - python3 docs_check.py --force --docs-branch "$GITHUB_REF" - python3 finish_check.py + cd "$REPO_COPY" + python3 python3 -m ci.praktika run Docs - name: Cleanup if: always() run: | From e5a78ce7f4398ebfc46a6b4ba1eb2caf5adc90e7 Mon Sep 17 00:00:00 2001 From: Shaun Struwig <41984034+Blargian@users.noreply.github.com> Date: Tue, 8 Apr 2025 10:56:32 +0200 Subject: [PATCH 2/8] fix typo --- .github/workflows/pull-request.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index 7a822149046..7ed9db25839 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -44,7 +44,7 @@ jobs: run: | cp -r "$GITHUB_WORKSPACE/ClickHouse" "$TEMP_PATH" cd "$REPO_COPY" - python3 python3 -m ci.praktika run Docs + python3 -m ci.praktika run Docs - name: Cleanup if: always() run: | From 6bc76fb2084fea2faaa5f69c5a4d7a3433a7f633 Mon Sep 17 00:00:00 2001 From: Shaun Struwig <41984034+Blargian@users.noreply.github.com> Date: Tue, 8 Apr 2025 11:13:50 +0200 Subject: [PATCH 3/8] remove docs check --- .github/workflows/pull-request.yml | 53 ------------------------------ 1 file changed, 53 deletions(-) delete mode 100644 .github/workflows/pull-request.yml diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml deleted file mode 100644 index 7ed9db25839..00000000000 --- a/.github/workflows/pull-request.yml +++ /dev/null @@ -1,53 +0,0 @@ -# Contact the folks in #dev-ci for this one, it looks like it -# is a partial copy of the CI checks from ClickHouse/ClickHouse - ---- -name: PullRequestCI - -env: - # Force the stdout and stderr streams to be unbuffered - PYTHONUNBUFFERED: 1 - -on: # yamllint disable-line rule:truthy - pull_request: - types: - - synchronize - - reopened - - opened - -# Cancel the previous wf run in PRs. -concurrency: - group: ${{ github.workflow }}-${{ github.ref }} - cancel-in-progress: true - -jobs: - DocsCheck: - runs-on: [self-hosted, func-tester-aarch64] - steps: - - name: Set envs - run: | - cat >> "$GITHUB_ENV" << 'EOF' - TEMP_PATH=${{runner.temp}}/docs_check - REPO_COPY=${{runner.temp}}/docs_check/ClickHouse - EOF - - name: Clear repository - run: | - sudo rm -rf "$GITHUB_WORKSPACE" && mkdir "$GITHUB_WORKSPACE" - sudo rm -rf "$TEMP_PATH" && mkdir -p "$TEMP_PATH" - - name: Check out repository code - uses: actions/checkout@v4 - with: - repository: "ClickHouse/ClickHouse" - path: "ClickHouse" - ref: "master" - - name: Docs Check - run: | - cp -r "$GITHUB_WORKSPACE/ClickHouse" "$TEMP_PATH" - cd "$REPO_COPY" - python3 -m ci.praktika run Docs - - name: Cleanup - if: always() - run: | - docker kill "$(docker ps -q)" ||: - docker rm -f "$(docker ps -a -q)" ||: - sudo rm -fr "$TEMP_PATH" From 27d4c515c1539c28bc537bdf4dc94bcf52e77582 Mon Sep 17 00:00:00 2001 From: Shaun Struwig <41984034+Blargian@users.noreply.github.com> Date: Tue, 8 Apr 2025 11:42:46 +0200 Subject: [PATCH 4/8] dummy change to trigger vercel --- contribute/style-guide.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/contribute/style-guide.md b/contribute/style-guide.md index 7b694031df7..b16d26a66d3 100644 --- a/contribute/style-guide.md +++ b/contribute/style-guide.md @@ -2,7 +2,8 @@ In this document, you will find a number of style guidelines for writing ClickHouse documentation. As documentation is a collective effort, these guidelines are -intended to help all of us ensure quality and consistency across our documentation. +intended to help all of us ensure we maintain quality and consistency across our +documentation. ## YAML front matter From 535599c56ad329312c335ed1b80bd927538fa7bf Mon Sep 17 00:00:00 2001 From: Shaun Struwig <41984034+Blargian@users.noreply.github.com> Date: Tue, 8 Apr 2025 11:53:56 +0200 Subject: [PATCH 5/8] run yarn build on docs check --- .github/workflows/pull-request.yaml | 36 +++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) create mode 100644 .github/workflows/pull-request.yaml diff --git a/.github/workflows/pull-request.yaml b/.github/workflows/pull-request.yaml new file mode 100644 index 00000000000..32de6bfea19 --- /dev/null +++ b/.github/workflows/pull-request.yaml @@ -0,0 +1,36 @@ +name: PullRequestCI + +env: + # Force the stdout and stderr streams to be unbuffered + PYTHONUNBUFFERED: 1 + +on: # yamllint disable-line rule:truthy + pull_request: + types: + - synchronize + - reopened + - opened + +# Cancel the previous wf run in PRs. +concurrency: + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: true + +jobs: + DocsCheck: + runs-on: ubuntu-latest + steps: + - name: Checkout repository + uses: actions/checkout@v3 + + - name: Set up Node.js + uses: actions/setup-node@v3 + with: + node-version: '20' # Adjust Node.js version as needed + cache: 'yarn' # Cache yarn dependencies + + - name: Install dependencies + run: yarn install --frozen-lockfile + + - name: Build + run: yarn build \ No newline at end of file From a9de8aa1d1d0a24b0819dae232eb83828ce7cb0b Mon Sep 17 00:00:00 2001 From: Shaun Struwig <41984034+Blargian@users.noreply.github.com> Date: Tue, 8 Apr 2025 11:58:09 +0200 Subject: [PATCH 6/8] set CI true --- .github/workflows/pull-request.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/pull-request.yaml b/.github/workflows/pull-request.yaml index 32de6bfea19..33c41bc6193 100644 --- a/.github/workflows/pull-request.yaml +++ b/.github/workflows/pull-request.yaml @@ -3,6 +3,7 @@ name: PullRequestCI env: # Force the stdout and stderr streams to be unbuffered PYTHONUNBUFFERED: 1 + CI: true on: # yamllint disable-line rule:truthy pull_request: From bc0017966821bb10ff0e5df10db663ef082aa1e3 Mon Sep 17 00:00:00 2001 From: Shaun Struwig <41984034+Blargian@users.noreply.github.com> Date: Tue, 8 Apr 2025 12:01:37 +0200 Subject: [PATCH 7/8] set CI false to pull ClickHouse/ClickHouse docs --- .github/workflows/pull-request.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pull-request.yaml b/.github/workflows/pull-request.yaml index 33c41bc6193..f8c1646a42b 100644 --- a/.github/workflows/pull-request.yaml +++ b/.github/workflows/pull-request.yaml @@ -3,7 +3,7 @@ name: PullRequestCI env: # Force the stdout and stderr streams to be unbuffered PYTHONUNBUFFERED: 1 - CI: true + CI: false on: # yamllint disable-line rule:truthy pull_request: From fa4943ff58504ea67c02f8183c617525d6a28401 Mon Sep 17 00:00:00 2001 From: Dale McDiarmid Date: Tue, 8 Apr 2025 11:26:16 +0100 Subject: [PATCH 8/8] Update pull-request.yaml --- .github/workflows/pull-request.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pull-request.yaml b/.github/workflows/pull-request.yaml index f8c1646a42b..226eeb17845 100644 --- a/.github/workflows/pull-request.yaml +++ b/.github/workflows/pull-request.yaml @@ -34,4 +34,4 @@ jobs: run: yarn install --frozen-lockfile - name: Build - run: yarn build \ No newline at end of file + run: yarn build