(0.96.22) Make NetCDFWriter work with GPU grids with stretched dimensions (#4441)

* remove view call

* introduce vertically stretched grids to tests

* up patch version

---------

Co-authored-by: Tomas Chor <tomchor@x1000c5s5b0n0h0.chn.perlmutter.nersc.gov>

Author: tomchor

Project.toml

@@ -1,7 +1,7 @@
 name = "Oceananigans"
 uuid = "9e8cae18-63c1-5223-a75c-80ca9d6e9a09"
 authors = ["Climate Modeling Alliance and contributors"]
-version = "0.96.21"
+version = "0.96.22"
 
 [deps]
 Adapt = "79e6a3ab-5dfb-504d-930d-738a2a938a0e"

ext/OceananigansNCDatasetsExt.jl

@@ -60,7 +60,7 @@ function collect_dim(ξ, ℓ, T, N, H, inds, with_halos)
     else
         inds = validate_index(inds, ℓ, T, N, H)
         inds = restrict_to_interior(inds, ℓ, T, N)
-        return collect(view(ξ, inds))
+        return collect(ξ[inds])
     end
 end
 

test/test_netcdf_writer.jl

@@ -104,7 +104,7 @@ function test_netcdf_grid_metrics_rectilinear(arch, FT)
                            topology = (Periodic, Bounded, Bounded),
                            size = (Nx, Ny, Nz),
                            halo = (Hx, Hy, Hz),
-                           extent = (1, 2, 3))
+                           x = (0, 1), y = (0, 2), z = LinRange(0, 3, Nz + 1))
 
     model = NonhydrostaticModel(; grid,
                                   closure = ScalarDiffusivity(ν=4e-2, κ=4e-2),
@@ -333,7 +333,7 @@ function test_netcdf_grid_metrics_latlon(arch, FT)
                                  halo = (Hλ, Hφ, Hz),
                                  longitude = (-15, 15),
                                  latitude = (-10, 10),
-                                 z = (-1000, 0))
+                                 z = LinRange(-1000, 0, Nz + 1))
 
     model = HydrostaticFreeSurfaceModel(; grid,
                                           momentum_advection = VectorInvariant(),