Store valid thermodynamic tendency (#79)

* Update thermodynamic_time_step.jl

* bump

* Update src/SeaIceThermodynamics/thermodynamic_time_step.jl

Author: simone-silvestri

Project.toml

@@ -1,7 +1,7 @@
 name = "ClimaSeaIce"
 uuid = "6ba0ff68-24e6-4315-936c-2e99227c95a4"
 authors = ["Climate Modeling Alliance and contributors"]
-version = "0.3.0"
+version = "0.3.1"
 
 [deps]
 Adapt = "79e6a3ab-5dfb-504d-930d-738a2a938a0e"

src/SeaIceThermodynamics/thermodynamic_time_step.jl

@@ -74,18 +74,22 @@ end
     ℵ⁺   = concentration_thermodynamic_step(ice_thermodynamics.concentration_evolution, ∂t_V, ℵⁿ, hⁿ, hᶜ, Δt)
     h⁺   = Vⁿ⁺¹ / ℵ⁺
 
-    # Save thermodynamic tendency for possible later use
-    @inbounds Gⁿ[i, j, 1] = ∂t_V
-    
     # Treat pathological cases
     h⁺ = ifelse(ℵ⁺ ≤ 0, zero(h⁺), h⁺)
     ℵ⁺ = ifelse(∂t_V == 0, ℵⁿ, ℵ⁺)     # No volume change
     h⁺ = ifelse(∂t_V == 0, hⁿ, h⁺)     # No volume change
     ℵ⁺ = ifelse(h⁺ == 0, zero(ℵ⁺), ℵ⁺) # reset the concentration if there is no sea-ice
-
+    
     # Ridging caused by the thermodynamic step
-    @inbounds ice_concentration[i, j, 1] = ifelse(ℵ⁺ > 1, one(ℵ⁺), ℵ⁺)
-    @inbounds ice_thickness[i, j, 1]     = ifelse(ℵ⁺ > 1,  h⁺ * ℵ⁺, h⁺)
+    ℵⁿ⁺¹ = ifelse(ℵ⁺ > 1, one(ℵ⁺), ℵ⁺)
+    hⁿ⁺¹ = ifelse(ℵ⁺ > 1,  h⁺ * ℵ⁺, h⁺)
+    
+    # Update thermodynamic variables
+    @inbounds ice_concentration[i, j, 1] = ℵⁿ⁺¹
+    @inbounds ice_thickness[i, j, 1]     = hⁿ⁺¹ 
+    
+    # Recompute new thermodynamic tendency, excluding pathological cases and save for possible later use
+    @inbounds Gⁿ[i, j, 1] = (hⁿ⁺¹ * ℵⁿ⁺¹ - hⁿ * ℵⁿ) / Δt
 end
 
 # We parameterize the evolution of ice thickness and concentration
@@ -102,4 +106,4 @@ end
     ℵ⁺ = max(zero(ℵ⁺), ℵ⁺)
 
     return ℵ⁺
-end
+end