Bypass certificate verification in downloader #557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #557 +/- ##
==========================================
- Coverage 14.29% 14.25% -0.05%
==========================================
Files 48 48
Lines 2833 2835 +2
==========================================
- Hits 405 404 -1
- Misses 2428 2431 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
simone-silvestri
approved these changes
Jun 6, 2025
There was a problem hiding this comment.
I guess this PR is a fix for these tests failing? https://github.com/CliMA/ClimaOcean.jl/actions/runs/15485716733/job/43599831576
Yes, this is the same error I ran into using ClimaOcean in the coupler. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ECCO server is sending an SSL certificate chain that includes Entrust intermediate certificates. Since Entrust root certificates have been distrusted by many platforms, this causes certificate validation failures.
This PR works around the issue by bypassing certificate verification in the
netrc_downloader. While the data transfer is still encrypted disabling certificate verification means we no longer confirm the server’s authenticity, which does introduce some security risks.