Change advection defaults #550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This decreases the maximum surface temperature of the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #550 +/- ##
==========================================
- Coverage 14.39% 14.29% -0.10%
==========================================
Files 48 48
Lines 2814 2812 -2
==========================================
- Hits 405 402 -3
- Misses 2409 2410 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
navidcy
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in
mainwe have centered advection in the vertical. This is mostly just for performance. I think we should use the WENO advection scheme also in the vertical as a default, it is a safer and probably more accurate default.People that want to experiment with a more performant simulation can manually change the vertical advection.