debugging net radiation on clima [skip ci]

Author: juliasloan25

.buildkite/Manifest.toml

@@ -1,6 +1,6 @@
 # This file is machine-generated - editing it directly is not advised
 
-julia_version = "1.10.8"
+julia_version = "1.10.0"
 manifest_format = "2.0"
 project_hash = "404dad335da65f39c10339b0364e8bfb81472ec4"
 
@@ -373,7 +373,7 @@ weakdeps = ["SparseArrays"]
 
 [[deps.ClimaAnalysis]]
 deps = ["Artifacts", "Dates", "Interpolations", "NCDatasets", "NaNStatistics", "OrderedCollections", "Reexport", "Statistics", "Unitful"]
-git-tree-sha1 = "b67f8f5f754fde6132bae1a2add06e51cf26227b"
+path = "../../ClimaAnalysis.jl"
 uuid = "29b5916a-a76c-4e73-9657-3c8fd22e65e6"
 version = "0.5.12"
 weakdeps = ["GeoMakie", "Makie"]
@@ -551,7 +551,7 @@ weakdeps = ["Dates", "LinearAlgebra"]
 [[deps.CompilerSupportLibraries_jll]]
 deps = ["Artifacts", "Libdl"]
 uuid = "e66e0078-7015-5450-92f7-15fbd957f2ae"
-version = "1.1.1+0"
+version = "1.0.5+1"
 
 [[deps.CompositionsBase]]
 git-tree-sha1 = "802bb88cd69dfd1509f6670416bd4434015693ad"
@@ -1973,7 +1973,7 @@ version = "0.2.6"
 [[deps.OpenBLAS_jll]]
 deps = ["Artifacts", "CompilerSupportLibraries_jll", "Libdl"]
 uuid = "4536629a-c528-5b80-bd46-f80d51c5b363"
-version = "0.3.23+4"
+version = "0.3.23+2"
 
 [[deps.OpenEXR]]
 deps = ["Colors", "FileIO", "OpenEXR_jll"]
@@ -2992,7 +2992,7 @@ version = "0.15.2+0"
 [[deps.libblastrampoline_jll]]
 deps = ["Artifacts", "Libdl"]
 uuid = "8e850b90-86db-534c-a0d3-1478176c7d93"
-version = "5.11.0+0"
+version = "5.8.0+1"
 
 [[deps.libfdk_aac_jll]]
 deps = ["Artifacts", "JLLWrappers", "Libdl"]

Artifacts.toml

@@ -100,3 +100,6 @@ git-tree-sha1 = "839224a62b59d73073bdb9a5c55d3dc75e30fe33"
     [[ilamb_data.download]]
     sha256 = "64a9a344ebfbb0113014178a1f93a655c401431565907c07fd33aff8860b62d6"
     url = "https://caltech.box.com/shared/static/eii2bfwfp47axfeuysgxlgzbczz27u5g.gz"
+
+[era5_surface_fluxes]
+git-tree-sha1 = "f2cb69e41cba84991054162e794292f98bf0ae34"

experiments/long_runs/data_paper_plots.jl

@@ -82,6 +82,7 @@ function get_sim_var_dict(simdir)
             lwn = lwd - lwu
             lwn.attributes["long_name"] = "Net longwave radiation"
             lwn.attributes["units"] = "W m⁻²"
+            lwn.attributes["start_date"] = lwd.attributes["start_date"]
             return lwn
         end
 
@@ -93,22 +94,27 @@ function get_sim_var_dict(simdir)
             swn = swd - swu
             swn.attributes["long_name"] = "Net shortwave radiation"
             swn.attributes["units"] = "W m⁻²"
+            swn.attributes["start_date"] = swd.attributes["start_date"]
             return swn
         end
 
     return sim_var_dict
 end
 
 function get_obs_var_dict()
+    # era5_data_path = joinpath(
+    #     ClimaLand.Artifacts.era5_monthly_averages_2008_folder_path(),
+    #     "era5_monthly_surface_fluxes_200801-200812.nc",
+    # )
     era5_data_path = joinpath(
-        ClimaLand.Artifacts.era5_monthly_averages_2008_folder_path(),
+        ClimaLand.Artifacts.era5_surface_data2008_path(),
         "era5_monthly_surface_fluxes_200801-200812.nc",
     )
     era5_land_forcing_data_path = joinpath(
         ClimaLand.Artifacts.era5_land_forcing_data2008_folder_path(
             lowres = false,
         ),
-        "era5_2008_0.9x1.25.nc",
+        "era5_2008_1.0x1.0.nc",
     )
 
     # Dict for loading in observational data
@@ -245,15 +251,17 @@ function get_obs_var_dict()
     obs_var_dict["lwd"] =
         (start_date) -> begin
             obs_var = ClimaAnalysis.OutputVar(
-                era5_data_path,
+                era5_land_forcing_data_path,
                 "msdwlwrf",
                 new_start_date = start_date,
                 shift_by = Dates.firstdayofmonth,
             ) # units (W/m²)
             obs_var = ClimaAnalysis.replace(obs_var, missing => NaN)
 
             # Copy data at lon = 0 to lon = 360 to avoid white lines
-            push!(obs_var.dims["longitude"], 360)
+            @show ClimaAnalysis.longitude_name(obs_var)
+            push!(obs_var.dims[ClimaAnalysis.longitude_name(obs_var)], 360)
+            # push!(obs_var.dims["longitude"], 360)
             new_data = cat(obs_var.data, obs_var.data[[1], :, :], dims = 1)
             # Manually set attributes
             attribs = Dict(
@@ -276,7 +284,7 @@ function get_obs_var_dict()
     obs_var_dict["swd"] =
         (start_date) -> begin
             obs_var = ClimaAnalysis.OutputVar(
-                era5_data_path,
+                era5_land_forcing_data_path,
                 "msdwswrf",
                 new_start_date = start_date,
                 shift_by = Dates.firstdayofmonth,
@@ -305,24 +313,51 @@ function get_obs_var_dict()
 
 
     # Compute LWN = LWD - LWU
+    #TODO era5_land_forcing (for lwd) has hourly data, need to resample to monthly
     obs_var_dict["lwn"] =
         (start_date) -> begin
             lwd = obs_var_dict["lwd"](start_date)
             lwu = obs_var_dict["lwu"](start_date)
-            lwn = lwd - lwu
-            lwn.attributes["long_name"] = "Net longwave radiation"
-            lwn.attributes["units"] = "W m⁻²"
-            return lwu
+
+            lwn_data = lwd.data .- lwu.data
+
+            attribs = Dict(
+                "short_name" => "lwn",
+                "long_name" => "Net longwave radiation",
+                "units" => "W m⁻²",
+                "start_date" => start_date,
+            )
+
+            lwn = ClimaAnalysis.OutputVar(
+                attribs,
+                lwd.dims,
+                lwd.dim_attributes,
+                lwn_data, # W/m²
+            )
+
+            return lwn
         end
 
     # Compute SWN = SWD - SWU
     obs_var_dict["swn"] =
         (start_date) -> begin
             swd = obs_var_dict["swd"](start_date)
             swu = obs_var_dict["swu"](start_date)
-            swn = swd - swu
-            swn.attributes["long_name"] = "Net shortwave radiation"
-            swn.attributes["units"] = "W m⁻²"
+            swn_data = swd.data - swu.data
+
+            attribs = Dict(
+                "short_name" => "lwn",
+                "long_name" => "Net shortwave radiation",
+                "units" => "W m⁻²",
+                "start_date" => start_date,
+            )
+
+            swn = ClimaAnalysis.OutputVar(
+                attribs,
+                swd.dims,
+                swd.dim_attributes,
+                swn_data, # W/m²
+            )
             return swn
         end
 

experiments/long_runs/global_paper_plots.jl

@@ -28,7 +28,7 @@ root_path = joinpath(pwd(), "snowy_land_longrun_gpu")
 outdir = "/scratch/clima/slurm-buildkite/climaland-long-runs/3785/climaland-long-runs/snowy_land_longrun_gpu_alpha1/global_diagnostics/output_active/" # on clima
 root_path = outdir
 
-short_names = ["lhf", "shf", "lwu", "swu", "lwn", "swn"]
+short_names = ["lwn", "swn"]#["lhf", "shf", "lwu", "swu", "lwn", "swn"]
 title_stubs = Dict(
     "lhf" => "Latent heat flux",
     "shf" => "Sensible heat flux",
@@ -93,6 +93,7 @@ function make_paper_figures(
         sim_var = sim_var_dict[short_name]()
         sim_var_times = ClimaAnalysis.times(sim_var)
 
+        @show short_name
         obs_var = obs_var_dict[short_name](sim_var.attributes["start_date"])
 
 

experiments/long_runs/paper_plots.jl

@@ -34,6 +34,15 @@ function era5_monthly_averages_2008_folder_path(; context = nothing)
     return @clima_artifact("era5_monthly_averages_2008", context)
 end
 
+
+"""
+    era5_surface_data2008_path(; context)
+Return the path to the folder that contains the ERA5 monthly surface data
+"""
+function era5_surface_data2008_path(; context = nothing)
+    return @clima_artifact("era5_surface_fluxes", context)
+end
+
 """
     era5_lai_forcing_data2008_path(; context)