Skip to content

Commit 85247cd

Browse files
committed
additional unsaved changes/typos resolved, remove FT argument from ModelTools and NeuralDepthmodel setoutscale/settimescale/setbounscale functions
1 parent 3042035 commit 85247cd

File tree

3 files changed

+4
-7
lines changed

3 files changed

+4
-7
lines changed

docs/tutorials/standalone/Snow/base_tutorial.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ pred_model = Chain(
152152
)
153153

154154
# We then specify `Float32` as the `Float` type for the model (it will run faster
155-
# than `Float64`, and changing the model type is as simple as calling `convert_model!(model, T)`
155+
# than `Float64`, and changing the model type is as simple as calling `convert_model(model, T)`
156156
# for Float type `T`), and make the model using our predictive component and boundary functions:
157157
FT = Float32
158158
model = ModelTools.make_model(

experiments/standalone/Snow/snowmip_simulation.jl

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,14 +22,11 @@ using DelimitedFiles
2222

2323
# Site-specific quantities
2424
# Error if no site argument is provided
25-
#=
2625
if length(ARGS) < 1
2726
@error("Please provide a site name as command line argument")
2827
else
2928
SITE_NAME = ARGS[1]
3029
end
31-
=#
32-
SITE_NAME = "cdp"
3330

3431
climaland_dir = pkgdir(ClimaLand)
3532

ext/neural_snow/ModelTools.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -363,7 +363,7 @@ end
363363

364364

365365
"""
366-
setoutscale!(model, scale; dtype)
366+
setoutscale!(model, scale)
367367
368368
Set the output scaling parameter for model usage (i.e. rectifying scaling done on model input).
369369
This may have unintended results or not work for models not created with `make_model()` or `make_model_paper()`.
@@ -386,7 +386,7 @@ end
386386

387387

388388
"""
389-
setboundscale!(model, bound, scale; dtype)
389+
setboundscale!(model, bound, scale)
390390
391391
Permits scaling of the upper or lower boundary function by the provided constant.
392392
This may have unintended results or not work for models not created with `make_model()`.
@@ -425,7 +425,7 @@ end
425425

426426

427427
"""
428-
settimescale!(model, dt; dtype)
428+
settimescale!(model, dt)
429429
Set the timescale parameter for model usage, for a model made with `make_model_paper()`.
430430
Note: this should only be used on models made with `make_model_paper()`,
431431
and not `make_model()`, or it will have unintended consequences. This function represents

0 commit comments

Comments
 (0)