Repair NTuple construction

Author: Espeer5

src/standalone/Vegetation/canopy_parameterizations.jl

@@ -400,7 +400,7 @@ function canopy_sw_rt_two_stream(
 
     # Convert fractional absorption into absorption and return
     # Ensure floating point precision is correct (it may be different for PAR)
-    F_trans = NTuple{length(α_soil), FT}(undef)
+    F_trans = ntuple(_ -> FT(0.0), length(α_soil))
     @. F_trans = FT((1 - F_abs - F_refl) / (1 - α_soil))
     return ntuple(
         i -> (;
@@ -428,7 +428,7 @@ Note that cos(θs) is equal to zero when θs = π/2, and this is a coefficient
 of k₀, which we divide by in this expression. This can amplify small errors
 when θs is near π/2.
 
-This formula is empirical and can yied negative numbers depending on the
+This formula is empirical and can yield negative numbers depending on the
 input, which, when dividing by something very near zero,
 can become large negative numbers.
 

test/standalone/Vegetation/hyperspectral_radiation.jl

@@ -17,10 +17,7 @@ for FT in (Float32, Float64)
         # Set up radiative transfer using 16 band discretization
         spectral_discretization = HyperspectralDiscretization{FT}()
         ρ_leaf = FT.(ntuple(_ -> 0.0, 16))
-        RTparams = BeerLambertParameters(FT;
-            spectral_discretization,
-            ρ_leaf,
-        )
+        RTparams = BeerLambertParameters(FT; spectral_discretization, ρ_leaf)
 
         # Drivers
         θs = FT.(Array(0:0.1:(π / 2)))
@@ -29,19 +26,27 @@ for FT in (Float32, Float64)
         α_soil = FT.(ntuple(_ -> 0.0, 16))
 
         # Test that radiative transfer works
-        output = canopy_sw_rt_beer_lambert.(
-            RTparams.Ω,
-            (RTparams.ρ_leaf,),
-            LAI,
-            K_c,
-            (α_soil,),
-        )
+        output =
+            canopy_sw_rt_beer_lambert.(
+                RTparams.Ω,
+                (RTparams.ρ_leaf,),
+                LAI,
+                K_c,
+                (α_soil,),
+            )
 
         @test length(output) == length(θs)
         @test length(output[1]) == 16
         get_PAR_sum =
-            (rt, sym, PAR_coeff) -> sum(map(x -> getproperty(x, sym), rt) .* PAR_coeff)
-        @test all(get_PAR_sum.(output, :refl, RTparams.spectral_discretization.PAR_proportions) .< 1e-6)
+            (rt, sym, PAR_coeff) ->
+                sum(map(x -> getproperty(x, sym), rt) .* PAR_coeff)
+        @test all(
+            get_PAR_sum.(
+                output,
+                :refl,
+                RTparams.spectral_discretization.PAR_proportions,
+            ) .< 1e-6,
+        )
 
     end
 end