Fix JET.test-call failure in get_boundary (#2142)

Author: charleskawczynski

src/Operators/finitedifference.jl

@@ -185,29 +185,30 @@ boundary_width(
     args...,
 ) = invalid_boundary_condition_error(typeof(op), typeof(bc))
 
+get_boundary(bcs::NamedTuple, name::Symbol) =
+    hasfield(typeof(bcs), name) ? getfield(bcs, name) : NullBoundaryCondition()
+
+get_boundary(bcs::@NamedTuple{}, name::Symbol) = NullBoundaryCondition()
+
 get_boundary(
     op::FiniteDifferenceOperator,
     ::LeftBoundaryWindow{name},
-) where {name} =
-    hasproperty(op.bcs, name) ? getproperty(op.bcs, name) :
-    NullBoundaryCondition()
+) where {name} = get_boundary(op.bcs, name)
 
 get_boundary(
     op::FiniteDifferenceOperator,
     ::RightBoundaryWindow{name},
-) where {name} =
-    hasproperty(op.bcs, name) ? getproperty(op.bcs, name) :
-    NullBoundaryCondition()
+) where {name} = get_boundary(op.bcs, name)
 
 has_boundary(
     op::FiniteDifferenceOperator,
     ::LeftBoundaryWindow{name},
-) where {name} = hasproperty(op.bcs, name)
+) where {name} = hasfield(typeof(op.bcs), name)
 
 has_boundary(
     op::FiniteDifferenceOperator,
     ::RightBoundaryWindow{name},
-) where {name} = hasproperty(op.bcs, name)
+) where {name} = hasfield(typeof(op.bcs), name)
 
 strip_space(op::FiniteDifferenceOperator, parent_space) =
     unionall_type(typeof(op))(

test/Operators/finitedifference/opt_examples.jl

@@ -1,3 +1,7 @@
+#=
+julia --project=.buildkite
+using Revise; include("test/Operators/finitedifference/opt_examples.jl")
+=#
 import ClimaCore
 using ClimaComms
 ClimaComms.@import_required_backends
@@ -47,6 +51,14 @@ function alloc_test_f2c_interp(cfield, ffield)
     @test p == 0 broken = using_cuda
 end
 
+function jet_test_f2c_interp2(cfield, ffield)
+    (; fx, fy, fz, fϕ, fψ) = ffield
+    (; cx, cy, cz, cϕ, cψ) = cfield
+    Ic = Operators.InterpolateF2C()
+    @. cz = cx * cy * Ic(fy) * Ic(fx) * cϕ * cψ
+    return nothing
+end
+
 function alloc_test_c2f_interp(cfield, ffield, If)
     (;fx,fy,fz,fϕ,fψ) = ffield
     (;cx,cy,cz,cϕ,cψ) = cfield
@@ -468,6 +480,9 @@ end
     wvec_glob = Geometry.WVector
 
     alloc_test_f2c_interp(cfield, ffield)
+    if !(ClimaComms.device(ffield) isa ClimaComms.CUDADevice)
+        JET.@test_call jet_test_f2c_interp2(cfield, ffield)
+    end
 
     alloc_test_c2f_interp(
         cfield,